aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Flesh out GN/Android run docs.Gravatar mtklein2016-09-16
| | | | | | | | | | | The process is simple enough that it's clearer to see all the steps laid out. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343263002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2343263002 Review-Url: https://codereview.chromium.org/2343263002
* SkPDF: Implement /ActualText to make text extraction correct.Gravatar halcanary2016-09-16
| | | | | | | | | | | For old API: no change. For new API: LTR text is perfectly extracted, RTL needs better testing. BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322403002 Review-Url: https://codereview.chromium.org/2322403002
* Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 ↵Gravatar rmistry2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/2343903002/ ) Reason for revert: Causing failures: https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812 Original issue's description: > Run SVGs through nanobench on all Perf bots. > > Tested with: > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 > > Example output is here: > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 > Nanobench did run on SVGs. > > BUG=skia:5757 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 > > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52 TBR=jcgregorio@google.com,fmalita@chromium.org,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5757 Review-Url: https://codereview.chromium.org/2348563003
* Is it just me or is this logging just noise?Gravatar mtklein2016-09-16
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343233002 Review-Url: https://codereview.chromium.org/2343233002
* Support Float32 output from SkColorSpaceXformGravatar msarett2016-09-16
| | | | | | | | | | | | | | | * Adds Float32 support to SkColorSpaceXform * Changes API to allows clients to ask for F32, updates clients to new API * Adds Sk4f_load4 and Sk4f_store4 to SkNx * Make use of new xform in SkGr.cpp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339233003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/43d6651111374b5d1e4ddd9030dcf079b448ec47 Review-Url: https://codereview.chromium.org/2339233003
* Build with GN on CT bots.Gravatar mtklein2016-09-16
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347203002 Review-Url: https://codereview.chromium.org/2347203002
* Improve join between the two RRects in SkRRectsGaussianEdgeShaderGravatar robertphillips2016-09-16
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345203003 Review-Url: https://codereview.chromium.org/2345203003
* Promote the N5 to the CQ for real.Gravatar mtklein2016-09-16
| | | | | | | | | The experiment was a great success. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345263002 Review-Url: https://codereview.chromium.org/2345263002
* Run SVGs through nanobench on all Perf bots.Gravatar rmistry2016-09-16
| | | | | | | | | | | | | | Tested with: python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001 Example output is here: https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410 Nanobench did run on SVGs. BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002 Review-Url: https://codereview.chromium.org/2343903002
* Clear stencil buffer before using it for drawingGravatar stani2016-09-16
| | | | | | | | Clear stencil buffer before using it for drawing. This is resolving an issue with a failing android CTS test in drawArc. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004 Review-Url: https://codereview.chromium.org/2342873004
* Revert of Support Float32 output from SkColorSpaceXform (patchset #7 ↵Gravatar msarett2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:140001 of https://codereview.chromium.org/2339233003/ ) Reason for revert: Hitting an assert Original issue's description: > Support Float32 output from SkColorSpaceXform > > * Adds Float32 support to SkColorSpaceXform > * Changes API to allows clients to ask for F32, updates clients to > new API > * Adds Sk4f_load4 and Sk4f_store4 to SkNx > * Make use of new xform in SkGr.cpp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339233003 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/43d6651111374b5d1e4ddd9030dcf079b448ec47 TBR=brianosman@google.com,mtklein@google.com,scroggo@google.com,mtklein@chromium.org,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2347473007
* GN: build get_images_from_skps.Gravatar mtklein2016-09-16
| | | | | | | | | | This also splits :common_flags off of :flags. get_images_from_skps wants :flags but not :common_flags. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338173006 Review-Url: https://codereview.chromium.org/2338173006
* Keeping asserts in release.Gravatar cblume2016-09-16
| | | | | | | | | | | We have a bug that is showing up occasionally in Canary. I want to see if these asserts could provide insight into why the bug happens. BUG=643845 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342903003 Review-Url: https://codereview.chromium.org/2342903003
* Allow GrCaps access from GrDrawContextGravatar bsalomon2016-09-16
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348923002 Review-Url: https://codereview.chromium.org/2348923002
* Support Float32 output from SkColorSpaceXformGravatar msarett2016-09-16
| | | | | | | | | | | | | | * Adds Float32 support to SkColorSpaceXform * Changes API to allows clients to ask for F32, updates clients to new API * Adds Sk4f_load4 and Sk4f_store4 to SkNx * Make use of new xform in SkGr.cpp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339233003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2339233003
* Remove old SkGaussianEdgeShader codeGravatar jvanverth2016-09-16
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345673003 TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2345673003
* Fix Seal_of_Mississippi URL and update version of SVG asset.Gravatar rmistry2016-09-16
| | | | | | | | | BUG=skia:5757 BUG=skia:5767 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342323002 Review-Url: https://codereview.chromium.org/2342323002
* Make SkPngCodec decode progressively.Gravatar scroggo2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a step towards using SkCodec in Chromium, where progressive decoding is necessary. Switch from using png_read_row (which expects all the data to be available) to png_process_data, which uses callbacks when rows are available. Create a new API for SkCodec, which supports progressive decoding and scanline decoding. Future changes will switch the other clients off of startScanlineDecode and get/skip-Scanlines to the new API. Remove SkCodec::kNone_ScanlineOrder, which was only used for interlaced PNG images. In the new API, interlaced PNG fits kTopDown. Also remove updateCurrScanline(), which was only used by the old implementation for interlaced PNG. DMSrcSink: - In CodecSrc::kScanline_Mode, use the new method for scanline decoding for the supported formats (just PNG and PNG-in-ICO for now). fuzz.cpp: - Remove reference to kNone_ScanlineOrder SkCodec: - Add new APIs: - startIncrementalDecode - incrementalDecode - Remove kNone_SkScanlineOrder and updateCurrScanline() - Set fDstInfo and fOptions in getPixels(). This may not be necessary for all implementations, but it simplifies things for SkPngCodec. SkPngCodec: - Implement new APIs - Switch from sk_read_fn/png_read_row etc to png_process_data - Expand AutoCleanPng's role to decode the header and create the SkPngCodec - Make the interlaced PNG decoder report how many lines were initialized during an incomplete decode SkIcoCodec: - Implement the new APIs; supported for PNG in ICO SkSampledCodec: - Call the new method for decoding scanlines, and fall back to the old method if the new version is unimplemented - Remove references to kNone_SkScanlineOrder tests/CodecPartial: - Add a test which decodes part of an image, then finishes the decode, and compares it to the straightforward method tests/CodecTest: - Add a test which decodes all scanlines using the new method - Repurpose the Codec_stripes test to decode using the new method in sections rather than all at once - In the method check(), add a parameter for whether the image supports the new method of scanline decoding, and be explicit about whether an image supports incomplete - Test incomplete PNG decodes. We should have been doing it anyway for non-interlaced (except for an image that is too small - one row), but the new method supports interlaced incomplete as well - Make test_invalid_parameters test the new method - Add a test to ensure that it's safe to fall back to scanline decoding without rewinding BUG=skia:4211 The new version was generally faster than the old version (but not significantly so). Some raw performance differences can be found at https://docs.google.com/a/google.com/spreadsheets/d/1Gis3aRCEa72qBNDRMgGDg3jD-pMgO-FXldlNF9ejo4o/ Design doc can be found at https://docs.google.com/a/google.com/document/d/11Mn8-ePDKwVEMCjs3nWwSjxcSpJ_Cu8DF57KNtUmgLM/ GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1997703003 Review-Url: https://codereview.chromium.org/1997703003
* SkPDF: fix unembeddable text drawn with positioning (broken in 6059dc3)Gravatar halcanary2016-09-16
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347183002 Review-Url: https://codereview.chromium.org/2347183002
* GN: add a flag to implement Android_FrameworkDefs bot.Gravatar mtklein2016-09-16
| | | | | | | | | | | This bot builds Skia with a bunch of defines to mimic the Android roll. Apparently it was supposed to be on the CQ... I'll add the GN version to it when it exists. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343103002 Review-Url: https://codereview.chromium.org/2343103002
* Make Sk2DPathEffect thread safe.Gravatar bungeman2016-09-16
| | | | | | | | | | | | | | SkPathEffects must be thread safe, but SkMatrix is only thread safe if the type mask has already been computed. The constructor for Sk2DPathEffect is currently making the call to 'invert' which sets the type mask, but it is being called with the passed matrix as opposed to the local copy. BUG=skia:5765 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133004 Review-Url: https://codereview.chromium.org/2340133004
* Update GN docs to mention is_official_build and ndk_api.Gravatar mtklein2016-09-16
| | | | | | | | | | | | | is_official_build is the closest approximation to what we'd recommend people ship, and we'll keep tweaking it further toward that goal. I want it to be the first choices people see reading the doc to nudge them to defaulting into that if they don't know better. The familiar old Debug and Release for developers come later. It'd be a fine choice, for instance, for fiddle to build against. I dropped Stripped because that's something is_official_build now does more naturally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342333002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2342333002 Review-Url: https://codereview.chromium.org/2342333002
* GN: enable Vulkan on Android when API >= 24.Gravatar mtklein2016-09-16
| | | | | | | | | | | Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan. The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003 Review-Url: https://codereview.chromium.org/2347843003
* SkFontData to use smart pointers.Gravatar bungeman2016-09-16
| | | | | | | | | | | | | | | | | The SkFontData type is not exposed externally, so any method which uses it can be updated to use smart pointers without affecting external users. Updating this first will make updating the public API much easier. This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It appears that no one outside Skia is currently using SkStream::NewfromFile so this is a good time to update it as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c Review-Url: https://codereview.chromium.org/2339273002
* Add staging for removal of SkRRectsGaussianEdgeShader::Make (for Android)Gravatar robertphillips2016-09-16
| | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347853002 TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2347853002
* Tweak valgrind suppressions for intentional leaks.Gravatar mtklein2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to building the Valgrind bots with GN. It's not clear why these need to leak, but we might as well update the suppressions. The stacks now look like this: Memcheck:Leak match-leak-kinds: possible fun:calloc fun:_dl_allocate_tls fun:pthread_create@@GLIBC_2.2.5 fun:_ZN8SkThreadC1EPFvPvES0_ fun:_Z14nanobench_mainv fun:(below main) We suppress fun:main in that last slot, so just make it ... TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347153002 Review-Url: https://codereview.chromium.org/2347153002
* test/fix/tweak writePicture/readPictureGravatar reed2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347593004 Review-Url: https://codereview.chromium.org/2347593004
* Fix key computation for GrPathsGravatar bsalomon2016-09-15
| | | | | | | Improve tests to ensure paths are receiving valid keys GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873002 Review-Url: https://codereview.chromium.org/2342873002
* GN: port Valgrind bots.Gravatar mtklein2016-09-15
| | | | | | | | | This was suspiciously easy... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342923002 Review-Url: https://codereview.chromium.org/2342923002
* Add GrContextOptions flag to disable distance field path renderer.Gravatar bsalomon2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339213002 Review-Url: https://codereview.chromium.org/2339213002
* Fix color bug in SkRRectsGaussianEdgeShaderGravatar robertphillips2016-09-15
| | | | | | | | | | | | Due to the code at the end of emitCode this shader was darker than the SkGaussianEdgeShader on Android. This CL also removes the unused "pad" parameter. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344963002 NOTREECHECKS=true TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2344963002
* Revert of Update version of SVG asset (patchset #1 id:1 of ↵Gravatar djsollen2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2341043003/ ) Reason for revert: breaking the build Original issue's description: > Update version of SVG asset > > BUG=skia:5757 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003 > > Committed: https://skia.googlesource.com/skia/+/ab00f4222c9fff8c08873e1218e79f49845f95a1 TBR=borenet@google.com,rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5757 Review-Url: https://codereview.chromium.org/2337763007
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot Review-Url: https://codereview.chromium.org/2340463008
* Update version of SVG assetGravatar rmistry2016-09-15
| | | | | | | BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003 Review-Url: https://codereview.chromium.org/2341043003
* Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of ↵Gravatar mtklein2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2340463008/ ) Reason for revert: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304 Original issue's description: > GN: support 32-bit x86 builds > > Take over Ubuntu -x86- bots. > > Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. > We'll want target_cpu="x86" there too. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 > > Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 TBR=jcgregorio@google.com,borenet@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2338173004
* Add storage and computation of SkColor4f version of gradient stops.Gravatar brianosman2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | For now, we still only have the SkColor factory, but the Descriptor can now carry either an SkColor or SkColor4f specified gradient. Base class constructor automatically populates both forms of color, so that legacy raster backend will continue to work, and new backend work can operate directly from the float4 version. On the GPU side, we have similar logic, but GrGradientEffect only keeps one version of colors around: SkColor if the destination is legacy, and SkColor4f (with an optional gamut xform) if the destination is gamma correct. The 4f colors are already linear, and we gamut xform them in setData, so gradients are now fully color-correct in sRGB and F16 modes... ... unless there are more than three stops. Then we use a texture, and that code path isn't handled yet. We have a few choices here (do we use an 8-bit sRGB atlas, or just always use F16 linear atlas so we can share it among both sRGB and wide-gamut rendering). In any case, I'd like to defer that to a second CL. This change does fix the non-texture gradients in the gamut GM. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337313002 Review-Url: https://codereview.chromium.org/2337313002
* GN: support 32-bit x86 buildsGravatar mtklein2016-09-15
| | | | | | | | | | | | Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Review-Url: https://codereview.chromium.org/2340463008
* Blacklist slsrgb + image decoding.Gravatar mtklein2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003 Review-Url: https://codereview.chromium.org/2345723003
* Revert of SkFontData to use smart pointers. (patchset #3 id:40001 of ↵Gravatar bungeman2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2339273002/ ) Reason for revert: Killing Mac Original issue's description: > SkFontData to use smart pointers. > > The SkFontData type is not exposed externally, so any method which uses > it can be updated to use smart pointers without affecting external > users. Updating this first will make updating the public API much > easier. > > This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to > std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It > appears that no one outside Skia is currently using SkStream::NewfromFile > so this is a good time to update it as well. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 > > Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c TBR=mtklein@chromium.org,halcanary@google.com,mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2343933002
* GN: link executables with -rdynamic on Linux.Gravatar mtklein2016-09-15
| | | | | | | | | -rdynamic makes sure the executable exposes all its symbols, which allows things like DM's built-in stack trace dumper to show symbols instead of just addresses. We do this in GYP too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339983005 Review-Url: https://codereview.chromium.org/2339983005
* SkFontData to use smart pointers.Gravatar bungeman2016-09-15
| | | | | | | | | | | | | | | | The SkFontData type is not exposed externally, so any method which uses it can be updated to use smart pointers without affecting external users. Updating this first will make updating the public API much easier. This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It appears that no one outside Skia is currently using SkStream::NewfromFile so this is a good time to update it as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 Review-Url: https://codereview.chromium.org/2339273002
* simple fix?Gravatar mtklein2016-09-15
| | | | | | | | | Scope cmdInfo more tightly to where it's not a null reference. BUG=skia:5759 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342063002 Review-Url: https://codereview.chromium.org/2342063002
* Add ability to create and upload SVGs from a local dirGravatar rmistry2016-09-15
| | | | | | | BUG=skia:5757 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346663003 Review-Url: https://codereview.chromium.org/2346663003
* Fix NoGPU bot, which is compiling in GPU supportGravatar borenet2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003 Review-Url: https://codereview.chromium.org/2342683003
* Remove the unused 16-bit gradient cacheGravatar brianosman2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343863002 Review-Url: https://codereview.chromium.org/2343863002
* More NoGPU compile fixesGravatar brianosman2016-09-15
| | | | | | | | | I can now build 'most' with skia_gpu=0 on my machine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133003 Review-Url: https://codereview.chromium.org/2340133003
* Pass rietveld as the default patch_storage.Gravatar mtklein2016-09-15
| | | | | | | | | | | | Passing around empty strings as command line arguments requires us to be really careful about command line quoting, parsing, etc. It seems easy enough here to just supply the implied value. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003 Review-Url: https://codereview.chromium.org/2323233003
* quad and conic do not intersectGravatar caryclark2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a quad a conic intersect only where the end of one is contained by the convex hull of the other, and the curve contained by the hull is nearly a straight line, treating it as a line may move the end point to the other side of the curve. Detect this by checking to see if the end point is in the hull, and if so, continue to subdivide the curve rather than treating it as a line. This fixes several existing tests that were disabled earlier this year. A typo in SkDCurve::nearPoint() prevented detecting when the end of a line was nearly touching a curve. Also fixed concidence a bit to get the second half of tiger further along. All existing tests, including extended testing in Release and the first half of tiger, work. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338323002 Review-Url: https://codereview.chromium.org/2338323002
* Remove "f" suffix from literal in LCD DF text shader.Gravatar bsalomon2016-09-15
| | | | | | | Also improve DF GP names GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340603003 Review-Url: https://codereview.chromium.org/2340603003
* Fix SampleApp compilation with skia_gpu=0Gravatar brianosman2016-09-15
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347593002 Review-Url: https://codereview.chromium.org/2347593002
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-30 04:59:01 +0000