aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert "hide deprecated underline and strikethru"Gravatar Leon Scroggins2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a01bf9ab748836fc4bf271bd5024151bf1ce2e88. Reason for revert: Breaking Android merge. They access setUnderlineText on their <shudder> subclass of SkPaint. Original change's description: > hide deprecated underline and strikethru > > BUG=skia:6250 > > Change-Id: I85395e4960b16ab91237a74ff35e5b7588965512 > Reviewed-on: https://skia-review.googlesource.com/8600 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=bungeman@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6250 Change-Id: If55f69f061dc4439ca2faa62807a9c5694ebbeb4 Reviewed-on: https://skia-review.googlesource.com/8687 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Disable SkJumper on MSAN builds.Gravatar Mike Klein2017-02-17
| | | | | | | Change-Id: I89c944f5ed1e1a9aee5e73c384a53d86fd13d07e Reviewed-on: https://skia-review.googlesource.com/8683 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* sksl support for geometry shadersGravatar Ethan Nicholas2017-02-17
| | | | | | | | | BUG=skia: Change-Id: I8541b98aadcf4c2484fef73e2f49be3ee38bc1e2 Reviewed-on: https://skia-review.googlesource.com/8409 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* SkJumper: LinuxGravatar Mike Klein2017-02-17
| | | | | | | | | | Just need to take care to match C symbols with asm symbols. Linux doesn't add the leading underscore automatically like Mac and Windows. Change-Id: I488cdfec942b442554ffefdfd006a1305ad77d9d Reviewed-on: https://skia-review.googlesource.com/8667 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Set asmflags when building for iOS.Gravatar Mike Klein2017-02-17
| | | | | | | | | | It's probably best we build iOS assembly with the iOS SDK and the right architecture settings in Clang... Change-Id: I68119641b1f86267ca85434b5a7f6ed37838ce23 Reviewed-on: https://skia-review.googlesource.com/8680 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* use common intermediate device class for clipstack managementGravatar Mike Reed2017-02-17
| | | | | | | | | BUG=skia:6214 Change-Id: I64b849ad7c8dafe423e24e6fccfb3f0c1d096ab0 Reviewed-on: https://skia-review.googlesource.com/8669 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Revert "Roll Recipe DEPS"Gravatar Eric Boren2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 310f4d02c1e2d01181c1db18acf05f2846f94cd4. Reason for revert: Broke uploads Original change's description: > Roll Recipe DEPS > > BUG=skia: > > Change-Id: I3e32207e5809e126d53ee8ec2158eb855c1a26d2 > Reviewed-on: https://skia-review.googlesource.com/8671 > Commit-Queue: Eric Boren <borenet@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> > TBR=borenet@google.com,rmistry@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: If6eed7a72aa7178afd23d0a4a7786e23b27c1ac2 Reviewed-on: https://skia-review.googlesource.com/8681 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Expand use of GrMakeCachedBitmapProxy"Gravatar Robert Phillips2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 561d1f8153c591dac670148a574a7638f3fe8c2d. Reason for revert: ios-device-xcode-clang Original change's description: > Expand use of GrMakeCachedBitmapProxy > > Change-Id: Ic276b9d772763dc16ac6b15a0896578d2d02e06e > Reviewed-on: https://skia-review.googlesource.com/8666 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I5349cfea983cb65c11b5c250e674a841b9691c40 Reviewed-on: https://skia-review.googlesource.com/8677 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll Recipe DEPSGravatar Eric Boren2017-02-17
| | | | | | | | | BUG=skia: Change-Id: I3e32207e5809e126d53ee8ec2158eb855c1a26d2 Reviewed-on: https://skia-review.googlesource.com/8671 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Make mask uintptr_t when calculating alignment.Gravatar Herb Derby2017-02-17
| | | | | | | | | | | A suggestion from from the code review on cl/7614. TBR=mtklein@google.com Change-Id: Icfbe08bfe63ac1e21ed56481dc5251c2af5bb96a Reviewed-on: https://skia-review.googlesource.com/8674 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Expand use of GrMakeCachedBitmapProxyGravatar Robert Phillips2017-02-17
| | | | | | | Change-Id: Ic276b9d772763dc16ac6b15a0896578d2d02e06e Reviewed-on: https://skia-review.googlesource.com/8666 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Change bitmap initialization in DrawFunctions fuzzerGravatar Kevin Lubick2017-02-17
| | | | | | | | | BUG=skia: Change-Id: Ibfd778315a0c3bf6c3abc23f8935c485fab89366 Reviewed-on: https://skia-review.googlesource.com/8615 Reviewed-by: twsmith@mozilla.com <twsmith@mozilla.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Fix TAP ASAN failure.Gravatar Florin Malita2017-02-17
| | | | | | | | | | | | | | | The current SkFixed3232 pinning logic in SkClampRange is not safe: SkFixed3232ToFloat(SkFixed3232Max) and SkFixed3232ToFloat(SkFixed3232Min) are not exactly representable in float, so they are not good SkTPin limits. Use the next representable float value towards zero. Constants computed with nextafterf(..., 0). Change-Id: I8e2eb35b22f65077e8ce6055d670d90d2a163bae Reviewed-on: https://skia-review.googlesource.com/8662 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Revert "Add SkTypeface::getVariationDesignPosition."Gravatar Ben Wagner2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 87e7f820f74a990a59fb8f1d5c182584ce586ecf. Reason for revert: Failed a test on Mac Original change's description: > Add SkTypeface::getVariationDesignPosition. > > Allow users to query a typeface's position in variation design space. > > Change-Id: I5d80c8ff658708a5d1aa386ec5b7396dcb621198 > Reviewed-on: https://skia-review.googlesource.com/7130 > Commit-Queue: Ben Wagner <bungeman@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=bungeman@google.com,reed@google.com,reviews@skia.org,drott@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia65792083642dbe9333a62eb75d162931b57cffd Reviewed-on: https://skia-review.googlesource.com/8670 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Add SkTypeface::getVariationDesignPosition.Gravatar Ben Wagner2017-02-17
| | | | | | | | | Allow users to query a typeface's position in variation design space. Change-Id: I5d80c8ff658708a5d1aa386ec5b7396dcb621198 Reviewed-on: https://skia-review.googlesource.com/7130 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Revert "Revert "Take missed opportunity: memset for A8.""Gravatar Mike Klein2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2028625f9b92b3423d841a926f785140a8955a84. Reason for revert: not the reason for broken roll. Original change's description: > Revert "Take missed opportunity: memset for A8." > > This reverts commit 9cee33e631679fc8195e7892b5aa5fdffb0b568e. > > Reason for revert: Chrome roll? > > Original change's description: > > Take missed opportunity: memset for A8. > > > > Just recently noticed we weren't doing this. > > It seems to be triggering all the time. > > > > Draws the same of course. > > > > Change-Id: Ie3d869a05194a5d52d635643eba1c96c8a21ce67 > > Reviewed-on: https://skia-review.googlesource.com/8471 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Mike Klein <mtklein@chromium.org> > > > > TBR=mtklein@chromium.org,msarett@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I26a3f2b1a9ae9093180e9c5cc61094b239377c17 > Reviewed-on: https://skia-review.googlesource.com/8606 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,msarett@google.com,reed@google.com NOPRESUBMIT=true Change-Id: Ib14360c6669abf9dd0c5bd152773b314d094fe72 Reviewed-on: https://skia-review.googlesource.com/8617 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "CQ config: add gerrit CQAbility verifier."Gravatar Ravi Mistry2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 04628221324eb2e5b329a8fd9c69196ea9acb43c. Reason for revert: Lets revert until the proto is rolled into Skia. Original change's description: > CQ config: add gerrit CQAbility verifier. > > Goal is to ensure that unreviewed and untrusted code isn't sent through > CQ to try bots, by accident or through malicious intent. > > R=​rmistry@google.com > BUG=chromium:692613 > NOTRY=True > > Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0 > Reviewed-on: https://skia-review.googlesource.com/8620 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> > TBR=rmistry@google.com,reviews@skia.org,tandrii@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:692613 Change-Id: I6d4b821b2a02ef3e097cf68cd8ebfb2b51d4d165 Reviewed-on: https://skia-review.googlesource.com/8663 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add Flutter compile botGravatar Ravi Mistry2017-02-17
| | | | | | | | | BUG=skia:6227 Change-Id: I997663e49c407e3ec64c8e67a2ca27700d5081b4 Reviewed-on: https://skia-review.googlesource.com/8448 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Switch from size_t to uint32_t to represent constraints better.Gravatar Herb Derby2017-02-17
| | | | | | | | | | TBR=mtklein@google.com Change-Id: Ib7400f2a3e2af0d8976998e5857c4d2c9cb6dbd0 Reviewed-on: https://skia-review.googlesource.com/7614 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
* Make all of the NUC tests use the newer intel driverGravatar Kevin Lubick2017-02-17
| | | | | | | | | | | Also update LD_LIBRARY_PATH to include the LIBGL_DRIVERS_PATH. BUG=skia: Change-Id: I0b4d3237f8042ac739f184b107f1c85368b71ee2 Reviewed-on: https://skia-review.googlesource.com/8603 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* hide deprecated underline and strikethruGravatar Mike Reed2017-02-17
| | | | | | | | | BUG=skia:6250 Change-Id: I85395e4960b16ab91237a74ff35e5b7588965512 Reviewed-on: https://skia-review.googlesource.com/8600 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* CQ config: add gerrit CQAbility verifier.Gravatar Andrii Shyshkalov2017-02-17
| | | | | | | | | | | | | | Goal is to ensure that unreviewed and untrusted code isn't sent through CQ to try bots, by accident or through malicious intent. R=rmistry@google.com BUG=chromium:692613 NOTRY=True Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0 Reviewed-on: https://skia-review.googlesource.com/8620 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* SkJumper: start on asmGravatar Mike Klein2017-02-17
| | | | | | | | | | | | | Will follow up with Linux, then Android aarch64 and armv7, then iOS, then Windows. I took some opportunities to refactor. CQ_INCLUDE_trybots=skia.primary:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug,Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug Change-Id: Ifcf1edabdfe5df0a91bd089f09523aba95cdf5ef Reviewed-on: https://skia-review.googlesource.com/8611 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Add a workaround for platforms with broken geo shader invocationsGravatar csmartdalton2017-02-17
| | | | | | | | | | BUG=skia: Change-Id: I9105b65b522d9ffac5a90ca7126bfd4ae88f8069 Reviewed-on: https://skia-review.googlesource.com/8422 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "Replace SkSpecialImage::makeTightSubset with asImage"Gravatar Robert Phillips2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5df6db15dc04ea7f8c8fa7a7b58ecb881d7a70fe. Reason for revert: Possibly blocking Chrome DEPS roll Original change's description: > Replace SkSpecialImage::makeTightSubset with asImage > > This should allow the relanding of: > > https://skia-review.googlesource.com/c/8450/ (Remove asTextureRef from SkSpecialImage & update effects accordingly (take 2)) > > Change-Id: I517af11036e3f44a280bbe6b9275f6c38f4a86a4 > Reviewed-on: https://skia-review.googlesource.com/8498 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ib5bebda78b2323e65a73504a61af918872ad231f Reviewed-on: https://skia-review.googlesource.com/8607 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Take missed opportunity: memset for A8."Gravatar Mike Klein2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9cee33e631679fc8195e7892b5aa5fdffb0b568e. Reason for revert: Chrome roll? Original change's description: > Take missed opportunity: memset for A8. > > Just recently noticed we weren't doing this. > It seems to be triggering all the time. > > Draws the same of course. > > Change-Id: Ie3d869a05194a5d52d635643eba1c96c8a21ce67 > Reviewed-on: https://skia-review.googlesource.com/8471 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,msarett@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I26a3f2b1a9ae9093180e9c5cc61094b239377c17 Reviewed-on: https://skia-review.googlesource.com/8606 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix drawVertices() texture mapping in the presence of a local matrixGravatar Florin Malita2017-02-17
| | | | | | | | Change-Id: I6379f2e7c030d7d1e0fcb2bd6ecc7d81c8a4eec5 Reviewed-on: https://skia-review.googlesource.com/8502 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Check for GL_EXT_geometry_shader on ESGravatar csmartdalton2017-02-17
| | | | | | | | | BUG=skia: Change-Id: If4f13af35679c048253c6c513a74e79be808dd74 Reviewed-on: https://skia-review.googlesource.com/8466 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* GrTessellator (AA): Performance tweaks and cleanup.Gravatar Stephen White2017-02-17
| | | | | | | | | | | | | | | | | | | | The SkArenaAlloc destructor was showing up as hot in profiling, especially on Linux. The reason is that it was being used incorrectly: the size estimate was being used as the chunk size. It turns out that the best performance seems to be achieved with no initial allocations and a fixed chunk size of 16K, as the CPU path renderer does. Also remove some unused code. (This is a partial re-land of https://skia-review.googlesource.com/c/8560/) TBR=bsalomon@google.com Change-Id: I277eb1a6e5718a221974cd694c8a7e481e432ca6 Reviewed-on: https://skia-review.googlesource.com/8561 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Revert "GrTessellator (AA): Performance tweaks and cleanup."Gravatar Ben Wagner2017-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e595bbfba6e7dcdda0d7d700343e9d814a406771. Reason for revert: Breaking roll into Chromium. virtual/gpu/fast/canvas/canvas-arc-circumference-fill.html virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill.html https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/5170 https://storage.googleapis.com/chromium-layout-test-archives/linux_trusty_blink_rel/5170/layout-test-results/results.html Original change's description: > GrTessellator (AA): Performance tweaks and cleanup. > > The SkArenaAlloc destructor was showing up as hot in profiling, > especially on Linux. The reason is that it was being used > incorrectly: the size estimate was being used as the chunk size. It > turns out that the best performance seems to be achieved with no > initial allocations and a fixed chunk size of 16K, as the CPU path > renderer does. > > Also, allocate the bisectors used for edge inversions on the > stack, not the heap. And remove some unused code. > > BUG=skia: > > Change-Id: I754531c753c9e602713bf2c8bb5a0eaf174bb962 > Reviewed-on: https://skia-review.googlesource.com/8560 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Stephen White <senorblanco@chromium.org> > TBR=bsalomon@google.com,senorblanco@chromium.org,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: I3cf6495c7345b6e6a79c2cb3a21dc6df0eed122f Reviewed-on: https://skia-review.googlesource.com/8605 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Replace SkSpecialImage::makeTightSubset with asImageGravatar Robert Phillips2017-02-16
| | | | | | | | | | | This should allow the relanding of: https://skia-review.googlesource.com/c/8450/ (Remove asTextureRef from SkSpecialImage & update effects accordingly (take 2)) Change-Id: I517af11036e3f44a280bbe6b9275f6c38f4a86a4 Reviewed-on: https://skia-review.googlesource.com/8498 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Let DFPathRenderer accept smaller paths.Gravatar Jim Van Verth2017-02-16
| | | | | | | | | BUG=chromium:682918 Change-Id: Ib5f935a92f967354be696fb24ba874f3602ebdb4 Reviewed-on: https://skia-review.googlesource.com/8601 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Replace use of SkBitmap::eraseRGB with eraseColor.Gravatar Ben Wagner2017-02-16
| | | | | | | | | | | | SkBitmap::eraseRGB is marked as deprecated. After this CL the code should have the exact same behavior as previously, but without calling the deprecated function. The presence of this deprecated call is causing extra warnings in the iOS build. Change-Id: I0770ca0a7e9884e7122f431a9ed2d3fdb2bbd6f8 Reviewed-on: https://skia-review.googlesource.com/8581 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fixed a couple of spots where sksl didn't have proper array support.Gravatar Ethan Nicholas2017-02-16
| | | | | | | | | | | | vec2 x[3] worked, but vec2[3] x didn't. Interface blocks also did not work with array sizes. BUG=skia: Change-Id: I45b424891db46804f1e3c1f4793470b7b501a6de Reviewed-on: https://skia-review.googlesource.com/8523 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Remove third_party/ktx from Skia.Gravatar Herb Derby2017-02-16
| | | | | | | | Change-Id: I3a1f68b0528f8789af5ccc0704b0a68fe14f52d3 Reviewed-on: https://skia-review.googlesource.com/8319 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* add device-clipping to gpudeviceGravatar Mike Reed2017-02-16
| | | | | | | | | BUG=skia: Change-Id: Id8c8994d4bddf591e1205ed9d591f4fce7d3af99 Reviewed-on: https://skia-review.googlesource.com/8531 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrTessellator (AA): Performance tweaks and cleanup.Gravatar Stephen White2017-02-16
| | | | | | | | | | | | | | | | | | | The SkArenaAlloc destructor was showing up as hot in profiling, especially on Linux. The reason is that it was being used incorrectly: the size estimate was being used as the chunk size. It turns out that the best performance seems to be achieved with no initial allocations and a fixed chunk size of 16K, as the CPU path renderer does. Also, allocate the bisectors used for edge inversions on the stack, not the heap. And remove some unused code. BUG=skia: Change-Id: I754531c753c9e602713bf2c8bb5a0eaf174bb962 Reviewed-on: https://skia-review.googlesource.com/8560 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* remove code for TextDecorationsGravatar Mike Reed2017-02-16
| | | | | | | | | BUG=skia:6250 Change-Id: I8c67c69017e0514b09f4583f5f2f9d16dec4f830 Reviewed-on: https://skia-review.googlesource.com/8497 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkPDF/font subsetting: Use new version of SfntlyWrapper::SubsetFontGravatar Hal Canary2017-02-16
| | | | | | | Change-Id: Ib4bddcedb09b50556e8e1f02926c443870f46a09 Reviewed-on: https://skia-review.googlesource.com/8544 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* SkJumper: everyone gets a start_pipeline().Gravatar Mike Klein2017-02-16
| | | | | | | | | | | | | | Windows needs this as a shim to switch to the System V ABI and back. Other platforms need it too, if only to make UBSAN happy about calling functions through the correct function pointers. One day maybe we can move the looping logic inside start_pipeline? Change-Id: I47d9ef48752becc6c43fc052b12a540c157bcaaa Reviewed-on: https://skia-review.googlesource.com/8542 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Disable DFPathRenderTest for now.Gravatar Jim Van Verth2017-02-16
| | | | | | | | | It's unclear what this test should be -- or even if it's valid any more. Change-Id: I62b5d99ad19c9b2813ef5a3c34c9b11991c01c5f Reviewed-on: https://skia-review.googlesource.com/8494 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Take missed opportunity: memset for A8.Gravatar Mike Klein2017-02-16
| | | | | | | | | | | | Just recently noticed we weren't doing this. It seems to be triggering all the time. Draws the same of course. Change-Id: Ie3d869a05194a5d52d635643eba1c96c8a21ce67 Reviewed-on: https://skia-review.googlesource.com/8471 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkJumper: fma() -> mad()Gravatar Mike Klein2017-02-16
| | | | | | | | | | | | | mad (Multiply-anD-Add) conveys the desired behavior better than fma... we don't particularly care about the fusedness of the mad, only that we're doing the fastest multiply-add available. This also avoids conflicts with fma() that may be defined in <math.h>. Change-Id: I9298ce9ff6c6aa5b7798ac446eea248ab035625f Reviewed-on: https://skia-review.googlesource.com/8543 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix DistanceFieldPathRenderer assert.Gravatar Jim Van Verth2017-02-16
| | | | | | | | | | | | If there's a reflection in the matrix, the scales could be negative. BUG=chromium:682918 Change-Id: Ifde42c3bc8b1f2938009b47d3a8380cf871448e9 Reviewed-on: https://skia-review.googlesource.com/8541 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Fiddle: Remove extraneous newline from SkDebugf output.Gravatar Joe Gregorio2017-02-16
| | | | | | | | | BUG=skia:6247 Change-Id: I69b5fd3fd0f8ed3fe5b7e36d3e389cc4215542c6 Reviewed-on: https://skia-review.googlesource.com/8478 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* SkJumper: make some room for wider instructions.Gravatar Mike Klein2017-02-16
| | | | | | | | | No real change here. Change-Id: I56449c292585038901d78902e6aeb68203e36351 Reviewed-on: https://skia-review.googlesource.com/8476 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove unneeded android flagsGravatar Mike Reed2017-02-16
| | | | | | | | | BUG=skia: Change-Id: Ie8bbddb8fc4bcdb8e87883512f548cf63520366c Reviewed-on: https://skia-review.googlesource.com/8475 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Use non-linear color spaces for Android decode outputsGravatar Matt Sarett2017-02-16
| | | | | | | | | | BUG=skia: Change-Id: Ic4bce28f4bc45f73cbfcacc3630140d11fa9c41f Reviewed-on: https://skia-review.googlesource.com/8530 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Revert "Turn on SkJumper except on Windows."Gravatar Mike Klein2017-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 957cf4594964c8f30e623d8c1b28ff63bef4ab33. Reason for revert: crashes Original change's description: > Turn on SkJumper except on Windows. > > ...only for our local testing. No Skia users should be affected yet. > > Change-Id: If1c46efe418458f747aafd6be8e2ae799c74b1c4 > Reviewed-on: https://skia-review.googlesource.com/8470 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,herb@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Id27f51c3b9356471b3178bbd63b021bd67a1d6fb Reviewed-on: https://skia-review.googlesource.com/8477 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update libwebp to 0.6.0Gravatar scroggo2017-02-16
| | | | | | | | | | | | | | | | | | | | | | | | | Corresponds with Android change https://android-review.googlesource.com/#/c/326439/ "this version includes encoder and performance improvements" Update build file * Many files have been renamed from src/<subdir>/<name>.c to src/<subdir>/<name>_<subdir>.c * Build new files (*_msa.c, *_neon.c, predictor_enc.c) This should fix issue 5876, which was caused by a compiler bug. With the added NEON implementation, we will no longer trigger the bug. BUG=skia:5876 CQ_INCLUDE_TRYBOTS=skia.primary:Build-Mac-Clang-arm-Debug-iOS Review-Url: https://codereview.chromium.org/2689283007
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-30 05:27:20 +0000