aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* 1.5x -> 2x text size for y pad.Gravatar mtklein2014-08-21
| | | | | | | | | | | | | | This will expand the cheat to just big enough to pass an assertion coming from our GDI bot. Currently failing: -6.000000 -1.500000 6.000000 1.500000 vs. -1.000000 -2.000000 3.000000 1.000000 Will become (-8 -2 8 2) vs. (-1 -2 3 1). BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/496153002
* Add --bbh (default true) to nanobench.Gravatar mtklein2014-08-21
| | | | | | | | | | | | | | | | | | | | | | | | | Chrome's using a bounding box, so it's a good idea for our bots to do so too. When set, we'll create an SkTileGrid to match the parameters of --clip, and so should always hit its fast path. This will impose a small overhead (querying the BBH) on all SKPs, but make large SKPs render more quickly. E.g. on GPU desk_pokemonwiki should show about a 30% improvement, tabl_mozilla about 40%, and one very long page from my personal suite, askmefast.com, gets 5x faster. (The performance changes are not the point of the CL, but something we should be aware of.) BUG= R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/497493003
* Add some SkTextBlob builder tests.Gravatar fmalita2014-08-21
| | | | | | | | R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/493443004
* Ignore small text sizes in the text bounding assert.Gravatar mtklein2014-08-21
| | | | | | | | | | | Seems we sometimes give back unduely large metrics for 0 text size. BUG=skia:2862 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/498503003
* Fix surface leak in multidraw GMs.Gravatar bsalomon2014-08-21
| | | | | | | | TBR=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/496793003
* fix android framework build for nanobenchGravatar djsollen2014-08-21
| | | | | | | | R=mtklein@google.com, tomhudson@chromium.org, tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/495003004
* git-sync-deps handles recursive DEPSGravatar halcanary2014-08-21
| | | | | | | | | NOTRY=true R=mtklein@google.com, borenet@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/468113003
* SkMultiPictureDraw APIGravatar robertphillips2014-08-21
| | | | | | | | | | | | This CL adds a new API to optimize across multiple SkPicture draw calls. Note that multiple pictures rendered at once (i.e., picture piles) should be flattened into a single new picture that includes the required clipping on the different layers. R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/491313003
* Fix root level Android.mk to now point to the correct nanobench makefileGravatar djsollen2014-08-21
| | | | | | | | R=mtklein@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/494193003
* Split up monolithic EXPERIMENTAL_drawPicture methodGravatar robertphillips2014-08-21
| | | | | | | | | | | | This is prep for the new multi-picture API. This is split out of (Add new API to allow layer hoisting/atlasing across picture piles - https://codereview.chromium.org/474623002/) R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/489103002
* Install a hook to swap between SkPicture backends with a single define.Gravatar mtklein2014-08-21
| | | | | | | | | BUG=skia: R=robertphillips@google.com, reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/492023002
* Cleanup FDO options.Gravatar djsollen2014-08-21
| | | | | | | | R=tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/489373004
* Add GrResourceCache2.Gravatar bsalomon2014-08-21
| | | | | | | | | | | | Currently it just replaces GrGpu as the owner of the linked list of resources. Committed: https://skia.googlesource.com/skia/+/94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f R=mtklein@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/481443002
* update expectations for Nexus 10 DebugGravatar caryclark2014-08-21
| | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=bsalomon@google.com TBR=bsalomon BUG=skia:2860 Author: caryclark@google.com Review URL: https://codereview.chromium.org/492303003
* remember to init fOrigPos in legacy constructorGravatar reed2014-08-21
| | | | | | | | | NOTREECHECKS=True R=caryclark@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/496833002
* Does this fix things?Gravatar mtklein2014-08-21
| | | | | | | | | | | NOTREECHECKS=true CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/492343002
* use globals to register custom effectsGravatar reed2014-08-21
| | | | | | | | | | NOTREECHECKS=True NOTRY=True R=mtklein@google.com, caryclark@google.com, bungeman@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/498453003
* rename gradients private BitmapCache to GradientBitmapCacheGravatar reed2014-08-21
| | | | | | | | | R=caryclark@google.com NOTREECHECKS=True Author: reed@google.com Review URL: https://codereview.chromium.org/474983005
* expose generalized imagecache keyGravatar reed2014-08-21
| | | | | | | | | BUG=skia: R=mtklein@google.com, halcanary@google.com, qiankun.miao@intel.com Author: reed@google.com Review URL: https://codereview.chromium.org/483493003
* Our SkPicture::Analysis visitors should recurse into nested pictures.Gravatar mtklein2014-08-21
| | | | | | | | | BUG=skia: R=tomhudson@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/495793002
* temporary rebaseline on arm64Gravatar halcanary2014-08-21
| | | | | | | | | | | | Affects all blur tests. BUG=skia:2845 NOTRY=true R=caryclark@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/495093002
* SkTextBlobGravatar fmalita2014-08-21
| | | | | | | | | | Initial implementation. R=bungeman@google.com, jbroman@chromium.org, mtklein@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/473633002
* Simplify flattening to just write enough to call the ↵Gravatar reed2014-08-21
| | | | | | | | | | | | | | | | | | factory/public-constructor for the class. We want to *not* rely on private constructors, and not rely on calling through the inheritance hierarchy for either flattening or unflattening(CreateProc). Refactoring pattern: 1. guard the existing constructor(readbuffer) with the legacy build-flag 2. If you are a instancable subclass, implement CreateProc(readbuffer) to create a new instances from the buffer params (or return NULL). If you're a shader subclass 1. You must read/write the local matrix if your class accepts that in its factory/constructor, else ignore it. R=robertphillips@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org, sugoi@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/395603002
* update gm expectations for Nexus 10Gravatar caryclark2014-08-21
| | | | | | | | | | | | | | the Android version was updated, introducing a new GPU driver NOTREECHECKS=true NOTRY=true R=bsalomon@google.com TBR=bsalomon BUG=skia:2860 Author: caryclark@google.com Review URL: https://codereview.chromium.org/496733002
* Temporarily adjust Matrix.isSimilarity test tolerance on 64-bit ARM devicesGravatar djsollen2014-08-21
| | | | | | | | | BUG=skia:2405 R=halcanary@google.com, jvanverth@google.com, reed@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/494113002
* Update FDO options to match what is needed by the frameworkGravatar djsollen2014-08-21
| | | | | | | | R=tomhudson@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/497503003
* Remove unecessary check from android framework buildGravatar djsollen2014-08-21
| | | | | | | | R=bungeman@google.com, raph@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/495063002
* Use medium filtering when downscaling bitmap glyphs in FreeType hostGravatar djsollen2014-08-21
| | | | | | | | | | This enable Android to save space on emoji glyphs R=bungeman@google.com, raph@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/492253002
* Fix == operator in GrTextureDomain so we don't compair uninitilized valuesGravatar egdaniel2014-08-21
| | | | | | | | | | | | We were getting random behavior when comparing two GrTexureDomains since fDomain was not initialized when the mode was set to ignore. BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/469393007
* Make SkPMColorAssert a macro (all assert-like functions should be macros).Gravatar halcanary2014-08-21
| | | | | | | | R=reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/494863003
* Remove State struct from GrDrawStateGravatar egdaniel2014-08-21
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/464363002
* remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPEGravatar reed2014-08-21
| | | | | | | | | BUG=skia: R=djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/489103003
* Update SKP version to 79Gravatar borenet2014-08-20
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/485233003
* Revert back to SkPictureData pictures. Huge perf regression.Gravatar mtklein2014-08-20
| | | | | | | | | | | http://skiaperf.com/#108 BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/496603002
* Always read .skp files and other serialized pictures into SkRecord.Gravatar mtklein2014-08-20
| | | | | | | | | | | | | | | | This should switch all our internal tools that aren't clever about it over to SkRecord pictures. (The clever tools know what they're doing.) Also, deletes the old SkPicture::clone() path. return this or die. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7b705bb17e09508e3761b54f59833b1ceb4ce9a6 R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/481743003
* Turn off NEON SkBoxBlurGetPlatformProcs for ARM64 (for now)Gravatar halcanary2014-08-20
| | | | | | | | | BUG=skia:2845 R=djsollen@google.com, senorblanco@google.com, senorblanco@chromium.org Author: halcanary@google.com Review URL: https://codereview.chromium.org/491973002
* Always read .skp files and other serialized pictures into SkRecord.Gravatar mtklein2014-08-20
| | | | | | | | | | | | | This should switch all our internal tools that aren't clever about it over to SkRecord pictures. (The clever tools know what they're doing.) Also, deletes the old SkPicture::clone() path. return this or die. BUG=skia: R=robertphillips@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/481743003
* ignore flaky failure on androidGravatar caryclark2014-08-20
| | | | | | | | | | | | | this failed to commit the first time NOTREECHECKS=true NOTRY=true R=bsalomon@google.com TBR=bsalomon Author: caryclark@google.com Review URL: https://codereview.chromium.org/488273002
* make imagecache's Key more general purposeGravatar reed2014-08-20
| | | | | | | | | | | This should allow other clients with different sized keys to still use the cache. BUG=skia: R=fmalita@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/472343002
* rebaseline_server: force checksumValue to an integer to prevent spurious ↵Gravatar epoger2014-08-20
| | | | | | | | | | | | | | | | | | comparison failures Without this change, SKP tests *appeared* to fail because the actuals reported their checksumValues as integers, while the expectations recorded their checksumValues as strings. NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/489023003
* Directly compute glyphToUnicode array in DirectWrite.Gravatar bungeman2014-08-20
| | | | | | | | | | | | | | | This new code is still rather bad, but has fewer steps. The motivation for looking at this is that on Windows 8 the previous code was occasionally asserting in such a way as to imply that GetGlyphIndices might return different data the second time through the font. This avoids that particular issue by only going through the font once. R=mtklein@google.com, halcanary@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/472333003
* add headers to experimental SKP expectationsGravatar epoger2014-08-20
| | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/491023003
* Add --properties for things like gitHash that describe the current nanobench ↵Gravatar mtklein2014-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | run. --key describes the type of run (describes the line on the chart), --properties describes the run itself (describes the dot on the chart). We'll pass --properties gitHash <git hash> build_number <build number> --key ... to nanobench from the bots. And... delete a whole lot of dead code. Example: nanobench --properties gitHash foo build_number 1234 --key bar baz { "build_number" : "1234", "gitHash" : "foo", "key" : { "bar" : "baz" }, "results" : { .... Friends with https://codereview.chromium.org/491943002 BUG=skia: R=jcgregorio@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/488213002
* rebaseline_server: if creating brand new expectations files, include the headerGravatar epoger2014-08-20
| | | | | | | | | | | | | | Otherwise, the first time you compare against these expectations, you get failures. NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/491063002
* update experimental SKP expectations using the new toolGravatar epoger2014-08-20
| | | | | | | | | | | | BUG=skia:1918 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana Author: epoger@google.com Review URL: https://codereview.chromium.org/488203002
* rebaseline_server: add download link for SKP diff patchfileGravatar epoger2014-08-20
| | | | | | | | | | | | | BUG=skia:1918 NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/489183002
* Dump out more information if this assert fails.Gravatar mtklein2014-08-20
| | | | | | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/ec924b9696277df4c684e73315194482e1d43e50 R=caryclark@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/491903002
* Dump out more information if this assert fails.Gravatar mtklein2014-08-20
| | | | | | | | | BUG=skia: R=caryclark@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/491903002
* add 2 missing SKP expectations files within experimental dirGravatar epoger2014-08-20
| | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/470193006
* copy points in array that may stretchGravatar caryclark2014-08-20
| | | | | | | | | | | | | | | | | | Description: Potential SkOpSegment::addT() use-after-free The 'pt' arg can be a reference to a point stored in the local fTs TDArray => appending may cause a realloc and leave the reference pointing to deallocated mem. Copy the points from the stretchy array before adding them. R=fmalita@google.com, fmalita@chromium.org, fmalita BUG=405417 Author: caryclark@google.com Review URL: https://codereview.chromium.org/489853002