aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar epoger <epoger@google.com>2014-08-20 12:21:48 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-08-20 12:21:48 -0700
commit260d2375667f875b4d5ff8c7d6f268a1fc0b8b53 (patch)
tree5907e49be02bf84846474c88039e6383aab8a4ad
parentdf2ec358be78820550f334bc7224ae18e3d25390 (diff)
rebaseline_server: force checksumValue to an integer to prevent spurious comparison failures
Without this change, SKP tests *appeared* to fail because the actuals reported their checksumValues as integers, while the expectations recorded their checksumValues as strings. NOTREECHECKS=true NOTRY=true R=stephana@google.com TBR=stephana (SkipBuildbotRuns) Author: epoger@google.com Review URL: https://codereview.chromium.org/489023003
-rwxr-xr-xgm/rebaseline_server/compare_rendered_pictures.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/gm/rebaseline_server/compare_rendered_pictures.py b/gm/rebaseline_server/compare_rendered_pictures.py
index cf0fa228b7..399117d611 100755
--- a/gm/rebaseline_server/compare_rendered_pictures.py
+++ b/gm/rebaseline_server/compare_rendered_pictures.py
@@ -399,7 +399,7 @@ class RenderedPicturesComparisons(results.BaseComparisons):
def _checksum_and_relative_url(dic):
if dic:
return ((dic[gm_json.JSONKEY_IMAGE_CHECKSUMALGORITHM],
- dic[gm_json.JSONKEY_IMAGE_CHECKSUMVALUE]),
+ int(dic[gm_json.JSONKEY_IMAGE_CHECKSUMVALUE])),
dic[gm_json.JSONKEY_IMAGE_FILEPATH])
else:
return None, None