aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Collapse consecutive SkTableColorFiltersGravatar cwallez2015-01-26
| | | | | | | | | | | BUG=skia:1366 For the added bench, the collapsing makes the bench take: - 70% of the time for CPU rendering of 3 consecutive matrix filters - almost no change in the GPU rendering of the matrix filters - 50% of the time for CPU and GPU rendering of 3 consecutive table filters Review URL: https://codereview.chromium.org/776673002
* prettify site/dev/design/pdftheoryGravatar halcanary2015-01-26
| | | | | | | NOTRY=true TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/868473006
* Add docs on how to get a preview of markdown pages.Gravatar jcgregorio2015-01-26
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/878593002
* https://fiddle.skia.org/Gravatar halcanary2015-01-26
| | | | | | NOTRY=true Review URL: https://codereview.chromium.org/868473005
* Don't do a pointless << 0.Gravatar mtklein2015-01-26
| | | | | | | | | | It's very common (universal?) that alpha is the top byte. You'd hope the compiler would remove the left shift then, but I've seen Clang just do a dumb left shift of zero. :( BUG=skia: Review URL: https://codereview.chromium.org/872243003
* Revert of Alter gpu veto (patchset #1 id:1 of ↵Gravatar robertphillips2015-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/875913002/) Reason for revert: Failing tests Original issue's description: > Alter gpu veto > > This CL unifies the treatment of the dashed and concave paths. > > Before: > TP 28 FP 15 TN 8 FN 3 IND 3 > > After: > TP 28 FP 18 TN 7 FN 2 IND 2 > > One of the TrueNegatives that became a FalsePositive was the motivation use case (the Chromium busy spinner). > > Committed: https://skia.googlesource.com/skia/+/87a6a8e18c7d5bbc94f478b44c53dc0e0549f927 TBR=egdaniel@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/879483003
* Fix Chrome buildGravatar robertphillips2015-01-26
| | | | | | | | | | Switch SkShader's toString method to not be pure virtual due to derived classes in Chromium TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/875043002
* Alter gpu vetoGravatar robertphillips2015-01-26
| | | | | | | | | | | | | | This CL unifies the treatment of the dashed and concave paths. Before: TP 28 FP 15 TN 8 FN 3 IND 3 After: TP 28 FP 18 TN 7 FN 2 IND 2 One of the TrueNegatives that became a FalsePositive was the motivation use case (the Chromium busy spinner). Review URL: https://codereview.chromium.org/875913002
* Update references to skiaperf.com.Gravatar tfarina2015-01-26
| | | | | | | | | The new server is being run in perf.skia.org. BUG=None R=jcgregorio@google.com Review URL: https://codereview.chromium.org/866943003
* Add patheffects to debugger printoutGravatar robertphillips2015-01-26
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/872043002
* Fix Windows buildGravatar robertphillips2015-01-26
| | | | | | | | TBR=jvanverth@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/876643002
* Fold alpha to the inner savelayer in savelayer-savelayer-restore patternsGravatar kkinnunen2015-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | Fold alpha to the inner savelayer in savelayer-savelayer-restore patterns such as this: SaveLayer (non-opaque) Save ClipRect SaveLayer Restore Restore Restore Current blink generates these for example for SVG content such as this: <path style="opacity:0.5 filter:url(#blur_filter)"/> The outer save layer is due to the opacity and the inner one is due to blur filter being implemented with picture image filter. Reduces layers in desk_carsvg.skp testcase from 115 to 78. BUG=skia:3119 Review URL: https://codereview.chromium.org/835973005
* Update SKP versionGravatar skia.buildbots2015-01-25
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/873163002
* initial preroll apiGravatar reed2015-01-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/855473002
* Update SKP versionGravatar skia.buildbots2015-01-24
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/870353002
* experimental/skp_to_pdf_md5 optionally also outputs pdf filesGravatar halcanary2015-01-24
| | | | | | TBR=mtklein@google.com Review URL: https://codereview.chromium.org/868333002
* Don't leak image in Surface test.Gravatar mtklein2015-01-24
| | | | | | | | | | | | | | | | | | | | | | ==7023== 5,056 (896 direct, 4,160 indirect) bytes in 8 blocks are definitely lost in loss record 947 of 2,656 ==7023== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7023== by 0x82CB99: SkNewImageFromBitmapTexture(SkBitmap const&, int, SkSurface::Budgeted) (SkImage_Gpu.cpp:64) ==7023== by 0x81A1CF: SkSurface_Gpu::onNewImageSnapshot(SkSurface::Budgeted) (SkSurface_Gpu.cpp:50) ==7023== by 0x694F9D: SkSurface::newImageSnapshot(SkSurface::Budgeted) (SkSurface_Base.h:92) ==7023== by 0x55EA7C: test_Surface(skiatest::Reporter*, GrContextFactory*) (SurfaceTest.cpp:485) ==7023== by 0x407CB2: run_test(skiatest::Test*) (DM.cpp:399) ==7023== by 0x408382: run_enclave_and_gpu_tests(SkTArray<Task, false>*) (DM.cpp:411) ==7023== by 0x68B71E: SkTaskGroup::wait() (SkTaskGroup.cpp:67) ==7023== by 0x40934E: dm_main() (DM.cpp:455) ==7023== by 0x409483: main (DM.cpp:477) http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/276/steps/dm/logs/stdio TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/872183002
* Update SKP versionGravatar skia.buildbots2015-01-23
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/871143002
* a typo in SkResourceCacheTestGravatar yunchao.he2015-01-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/868613002
* Revert of Fix Morphology effects sourcing outside of the crop rect. ↵Gravatar mtklein2015-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #6 id:100001 of https://codereview.chromium.org/781153002/) Reason for revert: Looks like this is causing memory leaks: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN/builds/1155/steps/dm/logs/stdio And causing crashes on Mac 10.6: http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/builds/1417/steps/dm/logs/stdio Original issue's description: > Fix Morphology effects sourcing outside of the crop rect. > > BUG=skia:1766 > > Committed: https://skia.googlesource.com/skia/+/f6be925b5615f07039ce95c3433039694a8d1679 TBR=junov@google.com,junov@chromium.org,bsalomon@google.com,reed@google.com,cwallez@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1766 Review URL: https://codereview.chromium.org/868973005
* Cleanup: Delete buildbot_globals.py script.Gravatar tfarina2015-01-23
| | | | | | | | | | | | rebaseline_server was the only user of this code but it was removed in https://chromium.googlesource.com/skia/+/3886046f008f0542de36cbeb35e220404e7c88a9 So there aren't more users of this script and we can remove it now. BUG=skia:3200 R=borenet@google.com Review URL: https://codereview.chromium.org/873593005
* Fix Morphology effects sourcing outside of the crop rect.Gravatar cwallez2015-01-23
| | | | | | BUG=skia:1766 Review URL: https://codereview.chromium.org/781153002
* Zap the scratch key on non-RT textures when scratch textures are disabled.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/870103002
* Fix the speeling of "purgeable" in Gr codeGravatar bsalomon2015-01-23
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/874693002
* Cleanup SkPDFObject::emit*Gravatar halcanary2015-01-23
| | | | Review URL: https://codereview.chromium.org/869783003
* remove unused GM flagsGravatar mtklein2015-01-23
| | | | | | | | | | Depends on https://codereview.chromium.org/873753002/ Thumbs up to CLion for refactoring this for me. BUG=skia: Review URL: https://codereview.chromium.org/867963004
* Remove deprecated SkSurface::NewRenderTarget factoriesGravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/837723008
* run clean branch baseline only onceGravatar mtklein2015-01-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/874643002
* Spin off GM::runAsBench() from flags.Gravatar mtklein2015-01-23
| | | | | | | | This will let us kill flags. BUG=skia: Review URL: https://codereview.chromium.org/873753002
* Fix SampleApp picture-mode transform.Gravatar fmalita2015-01-23
| | | | | | | | The multi-picture-draw path should not ignore the inherited transform. R=reed@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/867303002
* Take budgeted param when snapping new image.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/872543002
* Fix 'Revert' instructions.Gravatar tfarina2015-01-23
| | | | | | | | | | In the not so new pure Git world, 'svn fetch' and 'svn rebase' are not needed anymore. BUG=None R=borenet@google.com Review URL: https://codereview.chromium.org/872433004
* Collect everything Skia into one document.Gravatar halcanary2015-01-23
| | | | | | http://skiadocs.com:8000/dev/contrib/directory?cl=866133002 Review URL: https://codereview.chromium.org/866133002
* check for too-large rowBytesGravatar reed2015-01-23
| | | | | | BUG=446164 Review URL: https://codereview.chromium.org/871993003
* In Correctness Testing Doc, render --option correctlyGravatar halcanary2015-01-23
| | | | | | | TBR=mtklein@google.com NOTRY=true Review URL: https://codereview.chromium.org/871993004
* minor changes left out of http://crrev.com/873543002Gravatar halcanary2015-01-23
| | | | | | TBR=mtklein@google.com Review URL: https://codereview.chromium.org/872643005
* Allow unbudgeted resources to be recycled by the cache as scratch.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/870743002
* Fix self assigment in GrResourceKeyGravatar bsalomon2015-01-23
| | | | | | | | TBR=robertphillips@google.com BUG=skia:3340 Review URL: https://codereview.chromium.org/866263007
* Add a basic doc for correctness testing (DM).Gravatar mtklein2015-01-23
| | | | | | | | https://skia.org/dev/contrib/testing?cl=868983002 BUG=skia: Review URL: https://codereview.chromium.org/868983002
* Update compiler warning flagsGravatar mtklein2015-01-23
| | | | | | | | | | | | - add -Wsign-compare, which has been catching useful issues for Kimmo; - add -Winit-self and -Wpointer-arith to Mac builds so everyone's using the same flags; - try try removing -Wno-uninitialized. This was only for the old 10.6 compiler that we have warnings set as non-errors now. BUG=skia: Review URL: https://codereview.chromium.org/872793002
* Remove GrBinHashKeyGravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/861323002
* Compile fix after Add specialized content key class for resourcesGravatar kkinnunen2015-01-23
| | | | | | | gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4 error: comparison between signed and unsigned integer expressions Review URL: https://codereview.chromium.org/871013002
* More changes to SkPDFShader to eliminate multiple inheritance!Gravatar halcanary2015-01-23
| | | | Review URL: https://codereview.chromium.org/873543002
* add newImage APIGravatar reed2015-01-23
| | | | | | | BUG=skia:3277 related bug: skbug.com/3276 Review URL: https://codereview.chromium.org/821083002
* Write dm.json periodically instead of only once at the end.Gravatar mtklein2015-01-23
| | | | | | | | | This way if a bot crashes, we might get some partial results in gold rather than none. We do the same sort of thing in nanobench for perf. BUG=skia:3255 Review URL: https://codereview.chromium.org/872443003
* minor readability / refactorsGravatar mtklein2015-01-23
| | | | | | | | | | | | I have been hacking at this test trying to understand why the N5 is still sometimes crashy (it seems, less but not zero now). No luck so far. But, while I've been reading and hacking at it, I think I've made a few small improvements, mostly to readability. BUG=skia: Review URL: https://codereview.chromium.org/870803002
* more reinforcement that images never have zero width or heightGravatar reed2015-01-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/869743002
* Add specialized content key class for resources.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/858123002
* Update SKP versionGravatar skia.buildbots2015-01-23
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/866383002
* Simplify SkPDFShader class. Now invalid objects are never created.Gravatar halcanary2015-01-23
| | | | | | | | "Constructors should not do real work" I have verified that all test PDFs render identically. Review URL: https://codereview.chromium.org/862113004