diff options
| author |  mtklein <mtklein@chromium.org> | 2015-01-23 07:01:26 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-01-23 07:01:26 -0800 |
| commit | a07b297585f58c4cb4144e5625a31ce5d98c5e04 (patch) | |
| tree | a2991ea40770017931efff133dea6538626bae26 | |
| parent | 1ea1ebce1033ab14b1dc47cea9559073e38757fb (diff) | |
Update compiler warning flags
- add -Wsign-compare, which has been catching useful issues for Kimmo;
- add -Winit-self and -Wpointer-arith to Mac builds so everyone's using
the same flags;
- try try removing -Wno-uninitialized. This was only for the old 10.6
compiler that we have warnings set as non-errors now.
BUG=skia:
Review URL: https://codereview.chromium.org/872793002
| -rw-r--r-- | gyp/common_conditions.gypi | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi index 0fbeb09c78..394cc6ccf2 100644 --- a/gyp/common_conditions.gypi +++ b/gyp/common_conditions.gypi @@ -214,6 +214,7 @@ '-Wextra', '-Winit-self', '-Wpointer-arith', + '-Wsign-compare', '-Wno-c++11-extensions', '-Wno-unused-parameter', @@ -376,6 +377,7 @@ '-Wextra', '-Winit-self', '-Wpointer-arith', + '-Wsign-compare', ], 'cflags_cc!': [ '-fno-rtti', @@ -528,8 +530,11 @@ 'WARNING_CFLAGS': [ '-Wall', '-Wextra', + '-Winit-self', + '-Wpointer-arith', + '-Wsign-compare', + '-Wno-unused-parameter', - '-Wno-uninitialized', # Disabled because we think GCC 4.2 is bad at this. ], }, }, |