aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* GrTessellator: fix for ping-pong split fuzzer hang.Gravatar Stephen White2018-05-29
| | | | | | | | | | | | | | | | | | | | Change 3b5a3fa8b1c11d4bd4499b040311f4c3553ebf8c introduced support for splitting on out-of-range intersections. However, this is only necessary for correctness when the edge is nearly-flat (the top and bottom points only differ by 1/2 machine epsilon in the primary sort criterion). In other cases, it can cause repeated splitting and re-merging of edges, as the intersection code (being approximate and not exact) may produce a ping-pong set of intersections. The fix is to support out-of-range intersections only if they differ by 1/2 machine epsilon. This also generalizes the out_of_range_and_collinear() check, so it was removed. Bug: 838978 Change-Id: I134f7eff3f15707e0d68de11c55f7fadce4ff8e7 Reviewed-on: https://skia-review.googlesource.com/130448 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Revert "Make GrTextureOp disable coverage AA when rect falls on integers."Gravatar Brian Salomon2018-05-29
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ca439a0a0afca8ad20c724cc837ce7dbc67e1277. Reason for revert: layout tests :( Original change's description: > Make GrTextureOp disable coverage AA when rect falls on integers. > > Change-Id: Iaf5e8d154cc9108adcd8294812cecae7b4f01a5d > Reviewed-on: https://skia-review.googlesource.com/130148 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Iac6bdc19ed16ebbee27a7601086c305490d44a50 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/130521 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* wouldn't it be nice?Gravatar Mike Klein2018-05-29
| | | | | | | | | | Here's our drawing pipeline if we always blend as encoded. I think it's very intuitive. Change-Id: I0e531c5da1f6279d0da1f19b84d6317d99942da3 Reviewed-on: https://skia-review.googlesource.com/130131 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Added drawAtlas support to SkDebugCanvasGravatar Brian Osman2018-05-29
| | | | | | | | | | | | No serialization yet (like drawVertices, etc...), but should support capture and playback. Change-Id: I7b54cc95fb828471a8faa6abd4eaca0ad0d2cb70 Reviewed-on: https://skia-review.googlesource.com/130503 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll third_party/externals/angle2 bcf467f..1e91374 (1 commits)Gravatar angle-skia-autoroll2018-05-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/bcf467f..1e91374 git log bcf467f..1e91374 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 lucferron@chromium.org Vulkan: Enable every dEQP tests that are passing Created with: gclient setdep -r third_party/externals/angle2@1e91374 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: I561ea32f71e75958517deeb7b9a2093bd63f4c3c Reviewed-on: https://skia-review.googlesource.com/130441 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Clean up modules/skottie/BUILD.gnGravatar Florin Malita2018-05-29
| | | | | | | | | | Per comments in https://skia-review.googlesource.com/c/skia/+/130480 Change-Id: I978b04e4b06bf01c008b44540c640b77f5900f12 Reviewed-on: https://skia-review.googlesource.com/130501 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll third_party/externals/swiftshader 9d93107..4b74373 (3 commits)Gravatar swiftshader-skia-autoroll2018-05-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader/+log/9d93107..4b74373 git log 9d93107..4b74373 --date=short --no-merges --format='%ad %ae %s' 2018-05-28 capn@google.com Implement dynamic indexing of temporaries. 2018-05-28 capn@google.com Implement gather/scatter operations for shader register files. 2018-05-28 capn@google.com Detect loop index modifications in loop body. Created with: gclient setdep -r third_party/externals/swiftshader@4b74373 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=rmistry@google.com Change-Id: I610e52d2081d2f2615e8b74148d292d68a070907 Reviewed-on: https://skia-review.googlesource.com/130443 Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Make GrTextureOp disable coverage AA when rect falls on integers.Gravatar Brian Salomon2018-05-29
| | | | | | | Change-Id: Iaf5e8d154cc9108adcd8294812cecae7b4f01a5d Reviewed-on: https://skia-review.googlesource.com/130148 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Fix fuzz+Skottie integrationGravatar Kevin Lubick2018-05-29
| | | | | | | | Bug: skia: Change-Id: Ic926f6a838ac1e6d358d51913dc5c58d3083274a Reviewed-on: https://skia-review.googlesource.com/130480 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Upgrade node to 8.11.2Gravatar Joe Gregorio2018-05-29
| | | | | | | | | | This should contain npm version 6 which supports "npm ci". Bug: skia: Change-Id: I631dba2b6aca7794ec6ef960a256f275e4dfd04f Reviewed-on: https://skia-review.googlesource.com/130240 Commit-Queue: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Drop unneeded .get() in GrCoverageCountingPathRenderer.cppGravatar tzik2018-05-29
| | | | | | | | | | | MSVC's std::unique_ptr<>::get() is marked as NODISCARD, and the .get() call here causes a warning. Bug: chromium:752720 Change-Id: Iadc217247533b6148285f7a81c982527d98c86f9 Reviewed-on: https://skia-review.googlesource.com/130360 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2/ 29523298f..bcf467f24 (1 commit)Gravatar angle-skia-autoroll2018-05-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/29523298fd1d..bcf467f24f70 $ git log 29523298f..bcf467f24 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 jmadill Vulkan: Encapsulate RenderTargetVk. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: I22d102c66d2dbf4ec16517977961d71d3d282a43 Reviewed-on: https://skia-review.googlesource.com/130403 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update markdown filesGravatar skia-bookmaker2018-05-29
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: Id37e2f376e37fc79ff75b2f0e7e9333c65cf825d Reviewed-on: https://skia-review.googlesource.com/130404 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Roll third_party/externals/angle2/ 1478afaf1..29523298f (1 commit)Gravatar angle-skia-autoroll2018-05-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/1478afaf119e..29523298fd1d $ git log 1478afaf1..29523298f --date=short --no-merges --format='%ad %ae %s' 2018-05-28 geofflang Update dEQP EGL expectations for Mac. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: I745db548a0102d68a286618c6896d3b7efd6bfe9 Reviewed-on: https://skia-review.googlesource.com/130401 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix Dockerfile so args.gn actually applies, also drop debug symbols.Gravatar Joe Gregorio2018-05-28
| | | | | | | | | | | The part of the Dockerfile that extracted the skiaserve executable will be done in the skiabot repo. Bug: skia: Change-Id: Ieb913908d92626a7b9e68649b5c56b8f92646fd2 Reviewed-on: https://skia-review.googlesource.com/130323 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Update SKP versionGravatar skia-recreate-skps2018-05-27
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I74127276c2cdb62c3ef5bed78549cad1f1c81165 Reviewed-on: https://skia-review.googlesource.com/130350 Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* [skottie] Relocate to modules/skottieGravatar Florin Malita2018-05-27
| | | | | | | | TBR= Change-Id: I218d251ca56578a3a7fd4fb86cba9abdc10fb3bd Reviewed-on: https://skia-review.googlesource.com/130322 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Reland "Turn off domain in GrTextureOp when src rect contains entire proxy"Gravatar Brian Salomon2018-05-26
| | | | | | | | | | | | | | | | | | This is a reland of 869433fa113d1573d5d91fcafdca413b247ce1b0 Original change's description: > Turn off domain in GrTextureOp when src rect contains entire proxy > > Move check for turning off domain when nearest/no-aa to GrRenderTargetContext. > > Change-Id: I3c071b5f73fb3134218453204f30c3020c9dad9a > Reviewed-on: https://skia-review.googlesource.com/130143 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Change-Id: I29a21e26de8a246a74bd40fd0cda044f8f18327e Reviewed-on: https://skia-review.googlesource.com/130307 Reviewed-by: Stephen White <senorblanco@chromium.org>
* Reland "Workaround constexpr bug in MSVC 2015 in GrTextureOp"Gravatar Brian Salomon2018-05-26
| | | | | | | | | | | | | | | | This is a reland of 9eff78e2623d600282ca63c2e9988e0ffbba2949 Original change's description: > Workaround constexpr bug in MSVC 2015 in GrTextureOp > > Change-Id: I441858aab5fcd63e5467625a23681c5bcd35f25b > Reviewed-on: https://skia-review.googlesource.com/130122 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Change-Id: I90e5d807f658baadfab80333d84872d8105bf02b Reviewed-on: https://skia-review.googlesource.com/130306 Reviewed-by: Stephen White <senorblanco@chromium.org>
* Reland "Add support for SkCanvas::kStrict_SrcRectConstraint to GrTextureOp."Gravatar Brian Salomon2018-05-26
| | | | | | | | | | | | | | | | This is a reland of a0047bcff704a9121a6d82a6f97d6124463a2e54 Original change's description: > Add support for SkCanvas::kStrict_SrcRectConstraint to GrTextureOp. > > Change-Id: I8faa2838b3110b8080ac48bbe223240e3fb22998 > Reviewed-on: https://skia-review.googlesource.com/129762 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Change-Id: Icbad064ae2779f4e140a55e520c0034cd1d17477 Reviewed-on: https://skia-review.googlesource.com/130305 Reviewed-by: Stephen White <senorblanco@chromium.org>
* Revert "Add support for SkCanvas::kStrict_SrcRectConstraint to GrTextureOp."Gravatar Stephen White2018-05-26
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit a0047bcff704a9121a6d82a6f97d6124463a2e54. Reason for revert: Possibly blocking the Chromium roll (layout tests) Original change's description: > Add support for SkCanvas::kStrict_SrcRectConstraint to GrTextureOp. > > Change-Id: I8faa2838b3110b8080ac48bbe223240e3fb22998 > Reviewed-on: https://skia-review.googlesource.com/129762 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If7ddf13d8a63bc1ab6a51a1395896282f3a31702 Reviewed-on: https://skia-review.googlesource.com/130304 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Revert "Workaround constexpr bug in MSVC 2015 in GrTextureOp"Gravatar Stephen White2018-05-26
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9eff78e2623d600282ca63c2e9988e0ffbba2949. Reason for revert: Possibly blocking Chromium roll (layout tests) Original change's description: > Workaround constexpr bug in MSVC 2015 in GrTextureOp > > Change-Id: I441858aab5fcd63e5467625a23681c5bcd35f25b > Reviewed-on: https://skia-review.googlesource.com/130122 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4cf8f2b86cc601cf649e23e3889150419a834cb1 Reviewed-on: https://skia-review.googlesource.com/130303 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Update markdown filesGravatar skia-bookmaker2018-05-26
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: Id8bb3ebfde3caeca1639fc023f1e6e732bae434f Reviewed-on: https://skia-review.googlesource.com/130342 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* Revert "Turn off domain in GrTextureOp when src rect contains entire proxy"Gravatar Stephen White2018-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 869433fa113d1573d5d91fcafdca413b247ce1b0. Reason for revert: possibly preventing Chromium roll (layout tests) Original change's description: > Turn off domain in GrTextureOp when src rect contains entire proxy > > Move check for turning off domain when nearest/no-aa to GrRenderTargetContext. > > Change-Id: I3c071b5f73fb3134218453204f30c3020c9dad9a > Reviewed-on: https://skia-review.googlesource.com/130143 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8afc3c05b504ccde7d44e973d707f4cba1dc51b1 Reviewed-on: https://skia-review.googlesource.com/130302 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Add some missing includes to sources.Gravatar Ben Wagner2018-05-26
| | | | | | | | | The list of includes available to fiddle is now derived from sources. The Housekeeper bot now complains of a few missing includes which this adds. Change-Id: I1b667d285eb756c5201f04e07fe4b6c467793719 Reviewed-on: https://skia-review.googlesource.com/130321 Reviewed-by: Ben Wagner <bungeman@google.com>
* Roll third_party/externals/angle2/ 04796cdad..1478afaf1 (4 commits)Gravatar angle-skia-autoroll2018-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/04796cdada00..1478afaf119e $ git log 04796cdad..1478afaf1 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 lfy GLES1: Lighting and materials (renderer) 2018-05-17 lfy Reland "GLES1: Entry points for lighting and materials" 2018-05-07 jiawei.shao ES3.1: Set unordered access view related resource limits on D3D11 2018-05-18 jiawei.shao ES31: Implement FramebufferTextureEXT entry point Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=allanmac@google.com Change-Id: I8e88c7bef6d0e5eb41fd211c0e98511ed659b9e5 Reviewed-on: https://skia-review.googlesource.com/130208 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Revert "find_headers.py to better find headers.""Gravatar Ben Wagner2018-05-25
| | | | | | | | | | | | | This reverts commit 59da548b0c4d4239e0ec1855d3f7f77a2bff4b93. This now provides more information on failure and always sets the source root for cases where the output directory is not a subdirectory of the source directory. Change-Id: I8e317814d4686d9a0736b7097b404920fa55e769 Reviewed-on: https://skia-review.googlesource.com/130134 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* GrTessellator: remove collinear vertices.Gravatar Stephen White2018-05-25
| | | | | | | | | | | During sanitize_contours(), remove any points which are collinear with their previous and next points. Bug: skia:8503 Change-Id: Iba1df73b15a92047302bc26f01cb79f4de118760 Reviewed-on: https://skia-review.googlesource.com/130206 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* remove EmbededResouces botGravatar Mike Klein2018-05-25
| | | | | | | | | | | | The skia_embed_resoucres flag in GN is gone. (Both misspellings sic, seriously.) Change-Id: Ic4424fcea264010ff1cce390b4fd260897c15677 Reviewed-on: https://skia-review.googlesource.com/130147 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-25
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/10f67fe223a7973a95bc5fff219d1a7a3d95a326 [recipe_modules] Create Tricium module (juliehockett@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3382e6cb4629cb1c6a8597b5351f3612ab7c2424 Reviewed-on: https://skia-review.googlesource.com/130145 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* [sksg] Fix WASM buildGravatar Florin Malita2018-05-25
| | | | | | | | Bug: skia: Change-Id: I62c18765d13e2b64ec06fc913e91a3b492fb022f Reviewed-on: https://skia-review.googlesource.com/130132 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Revert "Create API for GrVkMemoryAllocator and impliment use of AMD ↵Gravatar Greg Daniel2018-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | VulkanMemoryAllocator on this API." This reverts commit 26c0e4c1f54759249c2d61b50fb5430bd73793f2. Reason for revert: breaks roll into fuchsia Original change's description: > Create API for GrVkMemoryAllocator and impliment use of AMD VulkanMemoryAllocator on this API. > > Bug: skia: > Change-Id: I1e122e1b11ab308c2f83cb98c36c81511f4507d0 > Reviewed-on: https://skia-review.googlesource.com/129980 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Jim Van Verth <jvanverth@google.com> TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com,bungeman@google.com Change-Id: I6c74978f778987c422e6162e7dd85ea9c6baa0e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/130182 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* "Modularize" SkSGGravatar Florin Malita2018-05-25
| | | | | | | | | | | * relocate all SkSG-related files under modules/sksg/ * fix various tidbits to make non-sksg builds possible * drop obsolete SampleSGInval.cpp Change-Id: I54e6c5bb1a09f45030fa8d607b3eb3f7cba78957 Reviewed-on: https://skia-review.googlesource.com/130025 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
* Revert "find_headers.py to better find headers."Gravatar Mike Klein2018-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6c8ad116d460fe892fff77b8f80e284e3487d59d. Reason for revert: https://chromium-swarm.appspot.com/task?id=3db0ac33aa369910&refresh=10 [981/1474] ACTION //:skia.h(//gn/toolchain:gcc_like) FAILED: gen/skia.h python ../../../gn/find_headers.py /mnt/pd0/s/w/ir/cache/work/skia/bin/gn /mnt/pd0/s/w/ir/cache/work/skia/ gen/skia.h /mnt/pd0/s/w/ir/cache/work/skia/include/android /mnt/pd0/s/w/ir/cache/work/skia/include/c /mnt/pd0/s/w/ir/cache/work/skia/include/codec /mnt/pd0/s/w/ir/cache/work/skia/include/config /mnt/pd0/s/w/ir/cache/work/skia/include/core /mnt/pd0/s/w/ir/cache/work/skia/include/effects /mnt/pd0/s/w/ir/cache/work/skia/include/encode /mnt/pd0/s/w/ir/cache/work/skia/include/gpu /mnt/pd0/s/w/ir/cache/work/skia/include/atlastext /mnt/pd0/s/w/ir/cache/work/skia/include/pathops /mnt/pd0/s/w/ir/cache/work/skia/include/ports /mnt/pd0/s/w/ir/cache/work/skia/include/svg /mnt/pd0/s/w/ir/cache/work/skia/include/utils /mnt/pd0/s/w/ir/cache/work/skia/include/utils/mac /mnt/pd0/s/w/ir/cache/work/skia/include/atlastext Traceback (most recent call last): File "../../../gn/find_headers.py", line 32, in <module> sources_json = json.loads(subprocess.check_output(gn_sources_cmd)) File "/usr/lib/python2.7/json/__init__.py", line 339, in loads return _default_decoder.decode(s) File "/usr/lib/python2.7/json/decoder.py", line 364, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode raise ValueError("No JSON object could be decoded") ValueError: No JSON object could be decoded Original change's description: > find_headers.py to better find headers. > > The find_headers.py script claims to "recursively search each include > directory for headers" but the recursive part has been left out. > > This changes find_headers to instead find all the sources which are in > public include directories and list them with the shortest possible > path. This removes the need for a blacklist and also handles includes in > subdirectories of public include directories. > > Change-Id: Ib59256a2059d37d4459686c421923207ac7acf38 > Reviewed-on: https://skia-review.googlesource.com/129660 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Ben Wagner <bungeman@google.com> TBR=egdaniel@google.com,mtklein@google.com,bungeman@google.com Change-Id: I5cca85754f1b9fde7771ab0ed1bd8117ee96a970 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/130181 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Create API for GrVkMemoryAllocator and impliment use of AMD ↵Gravatar Greg Daniel2018-05-25
| | | | | | | | | | | VulkanMemoryAllocator on this API. Bug: skia: Change-Id: I1e122e1b11ab308c2f83cb98c36c81511f4507d0 Reviewed-on: https://skia-review.googlesource.com/129980 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Retry ADB commands on all devices.Gravatar Ben Wagner2018-05-25
| | | | | | | | Change-Id: Ieb289043bd871ec45c70339787ae45f09d3ac1dc Reviewed-on: https://skia-review.googlesource.com/130128 Commit-Queue: Kevin Lubick <kjlubick@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* find_headers.py to better find headers.Gravatar Ben Wagner2018-05-25
| | | | | | | | | | | | | | | The find_headers.py script claims to "recursively search each include directory for headers" but the recursive part has been left out. This changes find_headers to instead find all the sources which are in public include directories and list them with the shortest possible path. This removes the need for a blacklist and also handles includes in subdirectories of public include directories. Change-Id: Ib59256a2059d37d4459686c421923207ac7acf38 Reviewed-on: https://skia-review.googlesource.com/129660 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Turn off domain in GrTextureOp when src rect contains entire proxyGravatar Brian Salomon2018-05-25
| | | | | | | | | Move check for turning off domain when nearest/no-aa to GrRenderTargetContext. Change-Id: I3c071b5f73fb3134218453204f30c3020c9dad9a Reviewed-on: https://skia-review.googlesource.com/130143 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll third_party/externals/angle2/ 14eb89c66..04796cdad (10 commits)Gravatar angle-skia-autoroll2018-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/14eb89c66f93..04796cdada00 $ git log 14eb89c66..04796cdad --date=short --no-merges --format='%ad %ae %s' 2018-05-24 jmadill Remove gl::PrimitiveType. 2018-05-24 jmadill Add PrimitiveMode packed GLenum. 2018-05-24 jmadill dEQP: Add attrib init helper function. 2018-05-24 jmadill Fix style inconsistency in packed enum json. 2018-05-24 jmadill D3D9: Fix incorrect parameter to setBlendDepthRasterStates. 2018-05-24 brandon1.jones Use os.path.join instead of slashes 2018-05-24 jmadill Order packed enums according to JSON. 2018-05-24 jmadill Move packed enum code to common/ 2018-05-16 tobine Roll to latest LVL as of 5/16/18 2018-05-24 jmadill Fix run_code_generation for huge diffs. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=allanmac@google.com Change-Id: I322caeda8b7f7f2b09dd192db0f087d3324474f6 Reviewed-on: https://skia-review.googlesource.com/130115 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-25
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/af2ffd933d0e6d8b5bd8c48be7a2b2d568a5eea2 Remove cq_client from depot_tools (agable@chromium.org) recipe_engine: https://crrev.com/c51413ab9d4c5ed5c3db8117b80afe64e54016b4 [recipe_api] Add content type for source manifests (mknyszek@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id1ee59cc3adc8bd30a70fc579af9437c38c766e8 Reviewed-on: https://skia-review.googlesource.com/130142 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2/ 2a12b3d58..14eb89c66 (11 commits)Gravatar angle-skia-autoroll2018-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/2a12b3d585a8..14eb89c66f93 $ git log 2a12b3d58..14eb89c66 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 jmadill dEQP: Add EGL 1.5 getPlatformDisplay. 2018-05-24 brandon1.jones Fix entry point generation on non-Windows 2018-05-21 tobine Enable sysroot install on x86 & x64 based-systems 2018-05-17 jmadill dEQP: Abort gtest run on exception. 2018-05-24 brandon1.jones Remove unused files from libGLESv2.gpyi 2018-05-24 lfy Revert "GLES1: Entry points for lighting and materials" 2018-05-17 lfy GLES1: Entry points for lighting and materials 2018-05-02 brandon1.jones Implement EGL_ANGLE_explicit_context 2018-05-18 courtneygo Add support for EGL_PLATFORM_ANGLE_EGL_HANDLE_ANGLE 2018-05-23 geofflang Don't double-terminate a display. 2018-05-23 geofflang Make sure to destroy all resources in DisplayWGL if initialization fails. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=allanmac@google.com Change-Id: I76568209f691917810b0c829b2f83e018783e399 Reviewed-on: https://skia-review.googlesource.com/130111 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Temporarily remove iOS bot from CQ."Gravatar Ben Wagner2018-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3a2cb1accd51e85e19fd672a793296239e9913e3. Reason for revert: skia:8013 has been resolved Original change's description: > Temporarily remove iOS bot from CQ. > > Bug: skia:8013 > No-Try: true > Change-Id: I2a377a6249366ed947bba50fe89ac218e5e3c87c > Reviewed-on: https://skia-review.googlesource.com/130060 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,herb@google.com Change-Id: I8e734415b05c2951508b5c9a763c098696365a91 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:8013 Reviewed-on: https://skia-review.googlesource.com/130180 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Update Skia milestone to 69Gravatar Heather Miller2018-05-24
| | | | | | | | | | TBR=reed@google.com Bug: skia: Change-Id: Ifabe4c89c9d0018da5d4f270d4e3fb5790e29bfc Reviewed-on: https://skia-review.googlesource.com/130120 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/48fe70296f2fe41e64bf2573ae9ff7a938eda7d2 Remove old git-cherry-pick-upload documentation (agable@chromium.org) https://crrev.com/0115c356f67563d749974293d81b3adeb00b1086 Roll mac_toolchain to 478dc9dbb (justincohen@google.com) https://crrev.com/4b23a2c6d7e2036160f17307ea8d95693a4e4168 Remove more Rietveld support from presubmit (agable@chromium.org) https://crrev.com/b09e03ecb190822b030a63f8be5dc40fa3c13c0d Remove Rietveld-only apply_issue (agable@chromium.org) recipe_engine: https://crrev.com/611cfbdc328b50144e2790ed1e4b9db24adb9eea [raw_io] Make it succeed even with read only files. (maruel@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I02f0473b60d76c00a4b2ecd73009429d5ade0505 Reviewed-on: https://skia-review.googlesource.com/130123 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Workaround constexpr bug in MSVC 2015 in GrTextureOpGravatar Brian Salomon2018-05-24
| | | | | | | Change-Id: I441858aab5fcd63e5467625a23681c5bcd35f25b Reviewed-on: https://skia-review.googlesource.com/130122 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Rename GrAtlasTextContext -> GrTextContextGravatar Herb Derby2018-05-24
| | | | | | | | Change-Id: I309b39425afc9b45095241eeb299096bc426afed Reviewed-on: https://skia-review.googlesource.com/130029 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Herb Derby <herb@google.com>
* skip unpremul...premul with only linear ops betweenGravatar Mike Klein2018-05-24
| | | | | | | | Change-Id: I26ed83bb613a83a0fd73f2f8b868b775be1ce968 Reviewed-on: https://skia-review.googlesource.com/130121 Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* skip transfer functions when not neededGravatar Mike Klein2018-05-24
| | | | | | | | Change-Id: I72e1084e6a14b3c1fa3f0a5c2100f13c6bcb24c7 Reviewed-on: https://skia-review.googlesource.com/130062 Commit-Queue: Mike Klein <mtklein@chromium.org> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* added interface block, vector comparison intrinsics, and mvk integration for ↵Gravatar Timothy Liang2018-05-24
| | | | | | | | | | metal sksl backend Bug: skia: Change-Id: Ia6984ba73482ec377f0890eb79f6ff92ff736749 Reviewed-on: https://skia-review.googlesource.com/129654 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Roll skia/third_party/skcms b01dbd2..a8a5c9e (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/b01dbd2..a8a5c9e 2018-05-24 brianosman@google.com Fix NULL dereference when using skcms to just do format conversion The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@google.com Change-Id: I9c2f469dcaf70f89c85696c2aa0c7a5690235301 Reviewed-on: https://skia-review.googlesource.com/130006 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>