aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert of SkRTConf: reduce functionality to what we use, increase simplicity ↵Gravatar mtklein2016-08-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #8 id:150001 of https://codereview.chromium.org/2212473002/ ) Reason for revert: missed GrVkPipelineStateCache Original issue's description: > SkRTConf: reduce functionality to what we use, increase simplicity > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002 > DOCS_PREVIEW= https://skia.org/?cl=2212473002 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > [mtklein] > TBR=reed@google.com > Only removing unused public API. > > Committed: https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47 TBR=halcanary@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2215433003
* Update to new skimage VERSIONGravatar msarett2016-08-03
| | | | | | | | TBR=borenet@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211633002 Review-Url: https://codereview.chromium.org/2211633002
* Fix compiler complaints about uninit varsGravatar msarett2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206143003 Review-Url: https://codereview.chromium.org/2206143003
* SkRTConf: reduce functionality to what we use, increase simplicityGravatar halcanary2016-08-03
| | | | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002 DOCS_PREVIEW= https://skia.org/?cl=2212473002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot [mtklein] TBR=reed@google.com Only removing unused public API. Review-Url: https://codereview.chromium.org/2212473002
* GN: build sfntly, icu, harfbuzzGravatar halcanary2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010 Review-Url: https://codereview.chromium.org/2200833010
* Move GrContext::makeDrawContext to new GrContextPriv objectGravatar robertphillips2016-08-03
| | | | | | | | | | | | | | We don't want external clients to be able to call the wrapping makeDrawContext. The "creating" makeDrawContext needs to be public for external image filters. The 3 specialized drawContext creators on GrContextPriv (to wrap backend objects) are also to be kept from public use and will be used to remove SkSurface::MakeRenderTargetDirect. Split out of: https://codereview.chromium.org/2176333002/ (Remove SkSurface::MakeRenderTargetDirect) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211473002 Review-Url: https://codereview.chromium.org/2211473002
* Require gn format in presubmitGravatar mtklein2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203283003 Review-Url: https://codereview.chromium.org/2203283003
* SkPDF: fewer GYP_DEFINESGravatar halcanary2016-08-03
| | | | | | | | | also: hack a unit test BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003 Review-Url: https://codereview.chromium.org/2208743003
* Convert SkAutoTUnref<SkData> to sk_sp<SkData>.Gravatar bungeman2016-08-03
| | | | | | | | | With the move from SkData::NewXXX to SkData::MakeXXX most SkAutoTUnref<SkData> were changed to sk_sp<SkData>. However, there are still a few SkAutoTUnref<SkData> around, so clean them up. Review-Url: https://codereview.chromium.org/2212493002
* Perform color correction on png decodesGravatar msarett2016-08-03
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184543003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2184543003
* added initial GLSL support to skslcGravatar ethannicholas2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185393003 Review-Url: https://codereview.chromium.org/2185393003
* Add new benchmark for testing special hard stop gradient casesGravatar fmenozzi2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206713002 Review-Url: https://codereview.chromium.org/2206713002
* SkPDF: PDFShader code modernized.Gravatar halcanary2016-08-03
| | | | | | | | | | | | | | | | | | | | | | Motivation: reduce code complexity. SkCanon stores SkPDFShader::State next to SkDFObject, not inside. many places use sk_sp<T> rather than T* to represent ownership. SkPDFShader::State no longer holds bitmap. SkPDFShader::State gets move constructor, no longer heap-allocated. Classes removed: SkPDFFunctionShader SkPDFAlphaFunctionShader SkPDFImageShader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193973002 Review-Url: https://codereview.chromium.org/2193973002
* Make SK_BUILD_FOR_WIN32 auto-detection work.Gravatar mtklein2016-08-03
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205173003 No public API changes TBR=reed@google.com Review-Url: https://codereview.chromium.org/2205173003
* Finish delete of SkNinePatchGravatar msarett2016-08-03
| | | | | | | | TBR=djsollen@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206333002 Review-Url: https://codereview.chromium.org/2206333002
* SkShaper: optionally disable harfbuzzGravatar halcanary2016-08-03
| | | | | | | | | | | also, re-enable warnings. motivation: used by me for PDF testing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002 Review-Url: https://codereview.chromium.org/2201153002
* [Recipes] Move test and perf steps into test and perf recipesGravatar borenet2016-08-03
| | | | | | | | | This looks like another big change, but I really just moved blocks of code around. Again, no expectations diffs because no behavior is changed. BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002 Review-Url: https://codereview.chromium.org/2198973002
* [SVGDom] Initial SVGLength supportGravatar fmalita2016-08-03
| | | | | | | | | | Mostly plumb new length types, but also introduce a stateful parser, rect shape and named color support. R=reed@google.com,robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053002 Review-Url: https://codereview.chromium.org/2202053002
* Fix fake_specs.py, update recipe expectationGravatar borenet2016-08-03
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002 Review-Url: https://codereview.chromium.org/2200763002
* Fix dtor bug in SkLightsGravatar robertphillips2016-08-03
| | | | | | | | | | The overriding problem was that the SkTDArray wasn't calling the SkLight destructors. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206823003 Review-Url: https://codereview.chromium.org/2206823003
* GN: gpu support in toolsGravatar mtklein2016-08-03
| | | | | | | | | | | | | | | | | | If you want to try this out, the DOCS_PREVIEW link is a quickstart. Are the GrGLCreateNativeInteface_* meant to be part of Skia-the-library or just used by testing tools? I've got it written here as tool-only, but we could easily move it to libskia if it's a thing we want to ship. I'm honestly not sure I understand how this linked before without a definition of GrGLCreateNativeInterface(). Or are there two, one real and one no-op default with some sort of weak linking setup? dlopen()? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201233003 DOCS_PREVIEW= https://skia.org/user/quick/gn?cl=2201233003 Review-Url: https://codereview.chromium.org/2201233003
* SK_GAMMA_SRGB is the default.Gravatar mtklein2016-08-03
| | | | | | | | | Looks like that other CL stuck just fine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207013002 Review-Url: https://codereview.chromium.org/2207013002
* Re-organize Skia recipesGravatar borenet2016-08-03
| | | | | | | | | | | | | | | | | | | | | | | | Break Skia recipe module into: - skia_vars: defines and stores variables (eg. paths) - skia_step: utilities for running Skia steps - skia_flavor: flavor-specific stuff - skia: top-level setup, checkout, test/perf steps, etc etc This establishes a saner dependency structure for the recipes; skia_vars is at the bottom level, skia_step depends on it, skia_flavor depends on both of them, skia depends on all of the above, and the recipes themselves may depend on any or all of them. Next steps: - Merge buildbot_spec into skia_vars - Move test_steps and perf_steps from skia recipe_module into swarm_test and swarm_perf recipes - Cleaner checkout_steps process BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002 Review-Url: https://codereview.chromium.org/2198173002
* Update hardstop_gradients GM to include more special casesGravatar fmenozzi2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2204873005 Review-Url: https://codereview.chromium.org/2204873005
* Don't leave fResScale uninitialized when constructing an SkStroke.Gravatar deanm2016-08-03
| | | | | | | | | | | Set a default value of 1. Users can set it with setResScale, but it's better that the constructor doesn't just leave the field uninitialized otherwise. R=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207753003 Review-Url: https://codereview.chromium.org/2207753003
* Fix copy-paste bugs in SkCanvas Nine and LatticeGravatar msarett2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203983002 Review-Url: https://codereview.chromium.org/2203983002
* GN: add tests to DMGravatar mtklein2016-08-02
| | | | | | | | | | | depends on https://codereview.chromium.org/2202203003 and https://codereview.chromium.org/2208433002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203143002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug-GN-Trybot,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN-Trybot Review-Url: https://codereview.chromium.org/2203143002
* Fixed ambient lighting calculations on SkLightingShaderGravatar dvonbeck2016-08-02
| | | | | | | BUG=skia:5520 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 Review-Url: https://codereview.chromium.org/2202233003
* Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.Gravatar bungeman2016-08-02
| | | | | | | This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004 Review-Url: https://codereview.chromium.org/2206633004
* GN: get echo-headers sources via exec_scriptGravatar mtklein2016-08-02
| | | | | | | | | | | | | | | | | exec_script runs every time gn does, which is explicitly on every one of our bot runs. That should be enough to obviate the .git/logs/HEAD hack. Easiest way to do this was to swap around find.py's argument order to allow multiple search directories. This is the root of all the .gyp changes. This moves the blacklist into BUILD.gn, which I think is nice. It expands it a little as we're now searching recursively, into include/gpu/vk which we can't include safely without the Vulkan SDK. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205903004 Review-Url: https://codereview.chromium.org/2205903004
* Delete SkNinePatchGravatar msarett2016-08-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206663002 Review-Url: https://codereview.chromium.org/2206663002
* GN: re-run echo_headers if git state changes.Gravatar mtklein2016-08-02
| | | | | | | | | This should mean it re-runs if a header is added or removed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206683002 Review-Url: https://codereview.chromium.org/2206683002
* Delete SkARGBImageEncoder.Gravatar mtklein2016-08-02
| | | | | | | | | | | | It appears to be unused now except by its unit test, also deleted. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208433002 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2208433002
* not much point to SK_SUPPORT_PDFGravatar mtklein2016-08-02
| | | | | | | | | | It only controls a few minor things in testing tools, which can always assume PDF support is present. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202203003 Review-Url: https://codereview.chromium.org/2202203003
* Refactor of SkColorSpaceXformOptsGravatar msarett2016-08-02
| | | | | | | | | | | | | | | | | (1) Performance is better or stays the same. (2) Code is split into functions (RasterPipeline-ish design). IMO, it's not really more or less readable. But I think it's now much easier add capabilities, apply optimizations, or do more refactors. Or to actually use RasterPipeline. I help back from trying any of these to try to keep this CL sane. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2194303002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2194303002
* Remove now unused source files.Gravatar bungeman2016-08-02
| | | | | | | | | These files have been renamed and exist only as stubs for transition reasons. Remove these now unused stubs. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/2197423003
* gn: fix fiddleGravatar mtklein2016-08-02
| | | | | | | | | | | | | - __SK_FORCE_IMAGE_DECODER_LINKING makes sure the PNG encoder is linked - updated path to make working with sample draw.cpp easier. No public API changes. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202353002 Review-Url: https://codereview.chromium.org/2202353002
* Remove 'Ulta' width.Gravatar bungeman2016-08-02
| | | | | | | | | All users of this old name appear to be updated. TBR=reed Removing unused and mis-spelled API. Review-Url: https://codereview.chromium.org/2206453003
* Add Overstroke gmGravatar hstern2016-08-02
| | | | | | | | | | Already exists as a sampleapp, but sampleapps don't get tested automatically BUG=skia:5405,5406,chrome:589769 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161633002 Review-Url: https://codereview.chromium.org/2161633002
* Add code to lua paths to get the fill path and get lists of verbs andGravatar hstern2016-08-02
| | | | | | | | | points BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199823002 Review-Url: https://codereview.chromium.org/2199823002
* Fix build_command_buffer for WindowsGravatar borenet2016-08-02
| | | | | | | BUG=skia:5597 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207563002 Review-Url: https://codereview.chromium.org/2207563002
* Add drawImageLattice() and drawBitmapLattice() APIsGravatar msarett2016-08-02
| | | | | | | | | | | | The specified image/bitmap is divided into rects, which can be draw stretched, shrunk, or at a fixed size. Will be used by Android to draw 9patch (which are acutally N-patch) images. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1992283002 Review-Url: https://codereview.chromium.org/1992283002
* Rename FontConfigInterface font manager files.Gravatar bungeman2016-08-02
| | | | | | | | | | | | These files are now so badly misnamed that it is causing problems. The original files are kept as shells until Chromium and PDFium can be updated. After Chromium and PDFium builds are updated, the old files will be removed and the cmake and bzl builds will be updated. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199973002 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/2199973002
* Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GNGravatar borenet2016-08-02
| | | | | | | BUG=skia:5597 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002 Review-Url: https://codereview.chromium.org/2199273002
* More fixes for SwarmBucketGravatar borenet2016-08-02
| | | | | | | | BUG=skia:5581 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005 NOTRY=true Review-Url: https://codereview.chromium.org/2202053005
* Always return ImageShader, even from SkShader::MakeBitmapShaderGravatar reed2016-08-02
| | | | | | | | | | | | | | | Lessons learned 1. ImageShader (correctly) always compresses (typically via PNG) during serialization. This has the surprise results of - if the image was marked opaque, but has some non-opaque pixels (i.e. bug in blitter or caller), then compressing may "fix" those pixels, making the deserialized version draw differently. bug filed. - 565 compressess/decompresses to 8888 (at least on Mac), which draws differently (esp. under some filters). bug filed. 2. BitmapShader did not enforce a copy for mutable bitmaps, but ImageShader does (since it creates an Image). Thus the former would see subsequent changes to the pixels after shader creation, while the latter does not, hence the change to the BlitRow test to avoid this modify-after-create pattern. I sure hope this prev. behavior was a bug/undefined-behavior, since this CL changes that. BUG=skia:5595 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2195893002 Review-Url: https://codereview.chromium.org/2195893002
* Roll recipe DEPSGravatar borenet2016-08-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002 Review-Url: https://codereview.chromium.org/2205863002
* GN: add some missing SkCodec definesGravatar mtklein2016-08-01
| | | | | | | | | | TURBO_HAS_... WEBP_SWAP_16BIT_CSP BUG=skia:5591 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2196413003 Review-Url: https://codereview.chromium.org/2196413003
* Fix SkJpegCodec::onSkipScanlines when TURBO_HAS_SKIP is not definedGravatar msarett2016-08-01
| | | | | | | | | | I think I just broke this in: https://codereview.chromium.org/2174493002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202763002 Review-Url: https://codereview.chromium.org/2202763002
* Hide (mostly) unused SkColorSpace writeToICC() functionGravatar msarett2016-08-01
| | | | | | | | | | | | | This originally was intended to be used for serialization, but we've chosen another approach. Includes a revert of: https://codereview.chromium.org/2012133003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193223002 Review-Url: https://codereview.chromium.org/2193223002