aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/09b389732d01bbeb2bfb17f5de06e15a952f0cbb buildbot: log path where pruning is happening (nodir@google.com) https://crrev.com/e13406ec6a3459b6dccd3eca4be5bdcd5325682e Remove Win10 experimental bots (hinoka@google.com) https://crrev.com/745e8d9fbc8344d522a84131ffa9b43472dbb06d Revert "Reland: zip_build.py: Exclude secondary toolchain obj and gen, as well as .ninja" (agrieve@chromium.org) depot_tools: https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac bot_update: fix regression with swallowed exception (phajdan.jr@chromium.org) recipe_engine: https://crrev.com/2f2d5c663eddcd8b6924a8775aaf88f3600d2ac8 [step_runner] expand try/catch to cover all step preparation functionality (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0dfbef52e05e67b967846b91813ca1c6ee3abf15 Reviewed-on: https://skia-review.googlesource.com/17366 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Remove GrSurfaceDesc member from GrSurface."Gravatar Greg Daniel2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 84911546b9535a2fff6c5e07f588f175d5a04f45. Reason for revert: Breaking bots possibly? Original change's description: > Remove GrSurfaceDesc member from GrSurface. > > Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771 > Reviewed-on: https://skia-review.googlesource.com/17273 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I404e509fcd3e3d5527b3bc6e286b7d436c12e879 Reviewed-on: https://skia-review.googlesource.com/17364 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Hide SkPerlinNoiseShader impl detailsGravatar Florin Malita2017-05-18
| | | | | | | | | | Move the shader impl to a private class, leave SkPerlinNoiseShader as a factory class only (similar to e.g. SkLightingShader). Change-Id: Ic1180db8f5dfd3d8f6fba133c6bf6bbdfa4f97a4 Reviewed-on: https://skia-review.googlesource.com/17318 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Use persistent checkout for UpdateMetaConfig botGravatar Ravi Mistry2017-05-18
| | | | | | | | | | | Bot is failing without this. BUG=skia:6591 Change-Id: I29cf5e18a7fa240d3e45bdadf83c1f91060f45f5 Reviewed-on: https://skia-review.googlesource.com/17319 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove GrSurfaceDesc member from GrSurface.Gravatar Brian Salomon2017-05-18
| | | | | | | Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771 Reviewed-on: https://skia-review.googlesource.com/17273 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Switch over GrDiscardOp to IORef-ing the GrRenderTargetProxyGravatar Robert Phillips2017-05-18
| | | | | | | | | | | This cannot land until after https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3)) sticks. This is because, prior to that CL, the SurfaceProxies have a ref on the last OpList that wrote to them. Since this CL adds a IORef from a discardOp in an opList to the SurfaceProxy this can result in a loop. After the required CL sticks, opLists have a IORef on the SurfaceProxy to which they wrote and the SurfaceProxy just has a raw back pointer so there will be no loop. Change-Id: I198035f5dd5a8fad549052dea6aaa61477a89844 Reviewed-on: https://skia-review.googlesource.com/16663 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* CQ_INCLUDE_CHROMIUM_TRYBOTS: add optional trybotsGravatar Hal Canary2017-05-18
| | | | | | | Change-Id: Id1bc86592a3006b00dfd313bf48488e038f3a041 Reviewed-on: https://skia-review.googlesource.com/17317 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add drawArraysBaseVertexIsBroken flagGravatar Chris Dalton2017-05-18
| | | | | | | | | | | A non-zero base vertex in glDrawArrays appears to not always work on Adreno. Bug: skia:6650 Change-Id: I301eaba8c7790ed814a2ab8d8c53dd2b9e0d77d1 Reviewed-on: https://skia-review.googlesource.com/17083 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add check for incorrect opList splitsGravatar Robert Phillips2017-05-18
| | | | | | | | | | | | | This CL relies on: https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3)) We can't/don't want to close the opList in the GrSurfaceContext dtor because we, semi-often, wrap a proxy in a utility SurfaceContext in order to upload data to it (e.g., when creating a proxy w/ data or in the texture strip atlas). In the current set up, the "temporary fixes" in newRTOpList and newTextureOpList should prevent any out of order execution. Change-Id: I8189db6ed59096d7b8c1704028df395f84e4a681 Reviewed-on: https://skia-review.googlesource.com/14187 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Remove GrSurface::desc() method.""Gravatar Brian Salomon2017-05-18
| | | | | | | | | | This reverts commit c96da1e51e1ca72d54dda49f32891bd41530ad31. Bug: skia: Change-Id: I8242400a137413c01c7ef614b4fa733be7dcf939 Reviewed-on: https://skia-review.googlesource.com/17311 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Expand small tables in SkColorSpaceXform_A2BGravatar Matt Sarett2017-05-18
| | | | | | | | Bug: 722855 Change-Id: Id3661be1e9747ac0de1e35b60d334ee8187a5be5 Reviewed-on: https://skia-review.googlesource.com/17312 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Pre-cache SkPath's genID in PreCachedPath tooGravatar Mike Klein2017-05-18
| | | | | | | | SkPath::getGenerationID() calls SkPathRef's, which is where the race is. Change-Id: I71296b32148c8cda2d2b2fe249ef6b9ef84fcfe0 Reviewed-on: https://skia-review.googlesource.com/17316 Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/1929522b5629bc18495781feaf794bef80db81f4 Nitfix follow up for https://chromium-review.googlesource.com/c/507128 (tandrii@chromium.org) https://crrev.com/feefbde597dd2c76463f51ad35e555922ce2c93f Bootstrap "authorize_adb_devices". (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I24c8fc5e7c1e5a141ace50e9a8a17b079e397afe Reviewed-on: https://skia-review.googlesource.com/17314 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Fix SkImage::onMakeColorSpace() for subset lazy imagesGravatar Matt Sarett2017-05-18
| | | | | | | | Bug: 723149 Change-Id: Ib56a77958fc1b7e026ee5ca98a46e8f014fe75d4 Reviewed-on: https://skia-review.googlesource.com/17309 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/df8a4659dcb826adfeb1f1534f124db33cda13e8 Revert "Remove debug output during recipe training." (tandrii@chromium.org) https://crrev.com/589e5267097f76224e0ac2e2ea554aff635d979f Revert "Turtles all the way down = aka debugging chromium_tests 2." (tandrii@chromium.org) https://crrev.com/af07a8d4dd8b3525570758f551c386dd680e0bf2 Revert "Turtles all the way down = aka debugging chromium_tests." (tandrii@chromium.org) https://crrev.com/81ae4cac09270557f27b650e4a19239d16ae9fde Revert "Add debug marker for ease text search for debugging info." (tandrii@chromium.org) https://crrev.com/208399a7f37deab314244d1c990570c0fd630a6a Revert "Log masked exception in test utils" (tandrii@chromium.org) https://crrev.com/8e9cb844bc627074c4aa50e1255cb468241dc2f6 V8: Add concurrent marking tsan bots (machenbach@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5823023f3b6910011055136ff603d3579482a690 Reviewed-on: https://skia-review.googlesource.com/17310 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Remove unused SkZeroShaderContextGravatar Florin Malita2017-05-18
| | | | | | | Change-Id: I3e9d9cb9c2f948b0bb363871e038ade1cf2f3d67 Reviewed-on: https://skia-review.googlesource.com/17308 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Bot to update buildbucket.config dailyGravatar Ravi Mistry2017-05-18
| | | | | | | | Bug: skia:6591 Change-Id: Ic2ec5b033965ca073a00e272693b1c5e1d0ad69f Reviewed-on: https://skia-review.googlesource.com/16541 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Move MIP color mode from GrSurfaceProxy to GrTextureProxyGravatar Brian Salomon2017-05-18
| | | | | | | Change-Id: I76bc7f551ea4052fc611cf01e0ce81102c9c3395 Reviewed-on: https://skia-review.googlesource.com/17263 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Remove GrSurface::desc() method."Gravatar Greg Daniel2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9ac995354428a916df81253e0c0c3f582db18976. Reason for revert: Lots of broken gold images Original change's description: > Remove GrSurface::desc() method. > > Change-Id: If158dee90b3b0f80aa9c674180fbe6abd5b27d3f > Reviewed-on: https://skia-review.googlesource.com/17268 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I5608c0e287e301aeac81dd3249a5c34d4603fcc6 Reviewed-on: https://skia-review.googlesource.com/17306 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/5e7db1588c5a375b1e77c074896ec1d28e5c2717 Bootstrap 'gsutil_cp_dir.py'. (dnj@chromium.org) https://crrev.com/d12c5d4da0acff399a59b9fab33c26f4f83201b3 Bootstrap "find_xcode.py". (dnj@chromium.org) https://crrev.com/5903d958fa5b792df25a290bc8e3f2437da75f28 chromite: Explicitly fetch depot_tools and put in path. (dgarrett@google.com) https://crrev.com/548cbb2161cccbba8e0c8f6e5e91a959ecbede3b Bootstrap 'upload_perf_dashboard_results' (dnj@chromium.org) https://crrev.com/72e5b727a9aaa51e36c1a43a048933a2d477e2fb Bootstrap "taskkill" and "runhooks_wrapper". (dnj@chromium.org) https://crrev.com/5d416e2d7d87bb5b3348fddfedda09619b9070d9 Bootstrap 'chromium_codesearch' Python calls. (dnj@chromium.org) https://crrev.com/5f35f05f0059fe1a742f26e4e3419e17e24d61d4 buildbot: prune files asynchronously (nodir@google.com) https://crrev.com/59b2a19535187b885ced88a997587ae54cb8a379 Bootstrap "archive_webkit_test_results". (dnj@chromium.org) https://crrev.com/13eedbe79cab4bdfb588eae57453d1bac57465ef Bootstrap chromium recipe module through runit.py (dnj@chromium.org) https://crrev.com/48e7709a6985dca0691e7d8be35f54c54d0dac92 chromite: Use cros_git_cache cache entry, not fixed path. (dgarrett@google.com) https://crrev.com/e8ac15dd482fba8f81b9c25bb5e0885db7bb5bc1 Bootstrap "gsutil_download". (dnj@chromium.org) https://crrev.com/dd7c881ce81e4530ad0158988c1f952dbe746aef chromite: Revise git-cache cache name to be standard. (dgarrett@google.com) https://crrev.com/a820eec0c2f3b2cb88b4d660613e9c92212af46a Bootstrap "nacl_sdk_buildbot_run". (dnj@chromium.org) https://crrev.com/d4e3bd5598f8a51a843723d5da136ad452d7db8b Bootstrap "archive_build.py". (dnj@chromium.org) https://crrev.com/469eb2aa0ebc7882ca7ad20d26add15a3d4c632c chromite: Set LANG to a known value. (dgarrett@google.com) https://crrev.com/9ec76523bb3629ab4874cd834c44dfa992929fc7 Bootstrap "transfer_files.py". (dnj@chromium.org) https://crrev.com/a3b6bc4351f05643d535938e6e7f1bfaf1bfdfc7 Turn off swarming for the linux layout tests temporarily. (dpranke@chromium.org) https://crrev.com/53a6b44b40dade4da9546b3f976313f1cd3f0cbe Bisect - Push gerrit changes to prod. (simonhatch@chromium.org) https://crrev.com/8f8aee589409a3a4b09cd2df307268baa517be98 Bootstrap "daemonizer.py". (dnj@chromium.org) https://crrev.com/5eb5de9c8c3da08fa9a1d546955e237ac719f912 [codesearch] Refactor chromium_codesearch.py by adding recipe modules (shenghuazhang@google.com) https://crrev.com/74b36c2301966a939024a8f240a7896c5d9b0b87 Revert "Turtles all the way down = aka debugging chromium_tests 3." (tandrii@chromium.org) https://crrev.com/ad3ec490aaa7742ff98c5c84ed79f0e59fa3bf2d Remove "Chromium Linux Precise Goma LinkTest" from recipes. (yyanagisawa@chromium.org) recipe_engine: https://crrev.com/cae7fab7b53f5c739176e95a116401592ff2b9e2 [step_runner] fix error text (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0a17c3580ddb1e80d8df38200e923b008281e805 Reviewed-on: https://skia-review.googlesource.com/17301 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Disable resource cache in shadow_utils GM for now"Gravatar Jim Van Verth2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c34a946d5a975ba8b8cd51f79b55174a5ec0f99f. Reason for revert: This is probably fixed with https://skia-review.googlesource.com/c/17279/. Original change's description: > Disable resource cache in shadow_utils GM for now > > This should make the GMs more stable in tiled mode. > > Change-Id: I72996b1305fc99e60626af35267952d0a5c38624 > Reviewed-on: https://skia-review.googlesource.com/17275 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> > TBR=jvanverth@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I0d21652a301b3f81e7ec04638bedbaabc723e583 Reviewed-on: https://skia-review.googlesource.com/17304 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* SkPath -> PreCachedPathGravatar Mike Klein2017-05-18
| | | | | | | | | | | SkPath is not threadsafe. Gotta use PreCachedPath. TSAN is showing a race in SkPathRef::genID() to write the fGenerationID. Change-Id: I42d6ecadaa754a3c6796ca465981de430a0abb84 Reviewed-on: https://skia-review.googlesource.com/17279 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/2c49b178c275e8e65b5d9b76e8ff3cefdb549f4e Remove Android Release (Pixel C) from GPU.FYI (ynovikov@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I51c75b6755abdb9104da65730b368b0830da85be Reviewed-on: https://skia-review.googlesource.com/17278 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Disable resource cache in shadow_utils GM for nowGravatar Jim Van Verth2017-05-17
| | | | | | | | | This should make the GMs more stable in tiled mode. Change-Id: I72996b1305fc99e60626af35267952d0a5c38624 Reviewed-on: https://skia-review.googlesource.com/17275 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/87753a94fd84ebdb8f94eb5e81be88cfde258f3c Bisect - Use patch_storage. (simonhatch@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I645a58ed5ca96192a620eb3f35bfcaa16de130ff Reviewed-on: https://skia-review.googlesource.com/17274 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* SkColorSpace_ICC: classify two entry tables as linearGravatar Matt Sarett2017-05-17
| | | | | | | | | | | | | | | | | | | | The bug linked in this CL was caused by the switch to SkJumper - where we decided to stop interpolating table-lookups. In this case, the image has tables with two entries: 0, 1. This fixes the bug by optimizing away the table lookup for these trivial no-op tables. I think this is a good change on its own. We see these tables fairly regularly. A more robust fix would expand "small" tables into larger ones through interpolation. Should we also do this? Bug: 722855 Change-Id: I3881734c6f28b5519cbe593dd05cc7b6b1b8a9d0 Reviewed-on: https://skia-review.googlesource.com/17272 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Remove GrSurface::desc() method.Gravatar Brian Salomon2017-05-17
| | | | | | | Change-Id: If158dee90b3b0f80aa9c674180fbe6abd5b27d3f Reviewed-on: https://skia-review.googlesource.com/17268 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add GM to verify that drawX == (path.addX, drawPath)Gravatar Brian Osman2017-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This demonstrates a new kind of hybrid unit test/GM. It creates a grid of cells. In each cell, we do two renders that are expected to produce the same result. For each cell, we render the two results overlaid, and highlight any differing pixels in red. Assuming there is a diff, the area around the largest diff is drawn zoomed in from both images. Matching cells are outlined in green, failing cells are outlined in red. Triaging this GM just involves answering the question: "Are there any red boxes?" "Good" example: https://screenshot.googleplex.com/909P3tvS55f.png "Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png To get more tests to pass, (and fix an assert in Ganesh), I've gone ahead and enforced that user supplied rects (in drawRect and drawOval) are always sorted once they hit the canvas virtuals. Currently, drawArc rejects empty ovals, but I added the same assert to onDrawArc, if we decide to change the strategy there. Re-land of: https://skia-review.googlesource.com/c/16983/ Bug: skia: Change-Id: I48f85de5f2bcb7fdc9558c2fd80cb1f20800b244 Reviewed-on: https://skia-review.googlesource.com/17270 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/eb7bab7bbcce65bf06842413025d611c62acb454 Update emulator bot master and builder. (jbudorick@chromium.org) recipe_engine: https://crrev.com/a819ab06fa3974b0fdee796aa4dd883274f4df2f [step_runner] do not immediately bail when START_DIR is gone. (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idf274aca3f6b41dbd19b07fdb8e08d0e1cd344e8 Reviewed-on: https://skia-review.googlesource.com/17267 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Add GM to verify that drawX == (path.addX, drawPath)"Gravatar Greg Daniel2017-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 78d1b428a8e8a0b76e88e9266d2893136acd5906. Reason for revert: break preabandongpu bot Original change's description: > Add GM to verify that drawX == (path.addX, drawPath) > > This demonstrates a new kind of hybrid unit test/GM. > It creates a grid of cells. In each cell, we do two > renders that are expected to produce the same result. > For each cell, we render the two results overlaid, > and highlight any differing pixels in red. Assuming > there is a diff, the area around the largest diff > is drawn zoomed in from both images. > > Matching cells are outlined in green, failing cells > are outlined in red. Triaging this GM just involves > answering the question: "Are there any red boxes?" > > "Good" example: https://screenshot.googleplex.com/909P3tvS55f.png > "Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png > > To get more tests to pass, (and fix an assert > in Ganesh), I've gone ahead and enforced that user > supplied rects (in drawRect and drawOval) are > always sorted once they hit the canvas virtuals. > Currently, drawArc rejects empty ovals, but I added > the same assert to onDrawArc, if we decide to change > the strategy there. > > Bug: skia: > Change-Id: I021a18c85e234298e1d29f333662683d996dd42c > Reviewed-on: https://skia-review.googlesource.com/16983 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Reviewed-by: Mike Reed <reed@google.com> > TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: skia: Change-Id: Id1ead4e22115c49cad5d0adb6151ede81734b4d3 Reviewed-on: https://skia-review.googlesource.com/17269 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Replace most uses of GrSurface::desc() with conifg(), width(), etc.Gravatar Brian Salomon2017-05-17
| | | | | | | Change-Id: Ic283c0ddf9efa0a467e97e10f5413ba9dfcb414f Reviewed-on: https://skia-review.googlesource.com/17211 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/31287b7fc427b15bca8f05b987e4045742b2b157 Bootstrap "archive_layout_test_retry_summary". (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I995f9838878418f84d4a3f30796724306726f901 Reviewed-on: https://skia-review.googlesource.com/17264 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/f855de86ca9fc39081e10e7941b2a007e3f501a4 Use is_official_build=true for cronet builds. (mef@chromium.org) depot_tools: https://crrev.com/7adb584516fd5dbde62d7e1d7156806977331acb [bot_update] Remove retry logic. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I85fc58c0d8a6212dc0f71b8ce399d77dbca0003d Reviewed-on: https://skia-review.googlesource.com/17262 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Remove GrSurfaceDesc member from GrSurfaceProxy.Gravatar Brian Salomon2017-05-17
| | | | | | | | | Stores the config, origin, and dimensions in GrSurfaceProxy, sample count in GrRenderTargetProxy, and "was constructed with mip maps" in GrTextureProxy. Change-Id: Iee058674dce49107a991cca9d083cd33e3572809 Reviewed-on: https://skia-review.googlesource.com/17209 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Add tool to create test images with interesting color profilesGravatar Matt Sarett2017-05-17
| | | | | | | | Bug: skia: Change-Id: Ia4f892368fceda4a99490f5bd29851837a7a6927 Reviewed-on: https://skia-review.googlesource.com/17212 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Add GM to verify that drawX == (path.addX, drawPath)Gravatar Brian Osman2017-05-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This demonstrates a new kind of hybrid unit test/GM. It creates a grid of cells. In each cell, we do two renders that are expected to produce the same result. For each cell, we render the two results overlaid, and highlight any differing pixels in red. Assuming there is a diff, the area around the largest diff is drawn zoomed in from both images. Matching cells are outlined in green, failing cells are outlined in red. Triaging this GM just involves answering the question: "Are there any red boxes?" "Good" example: https://screenshot.googleplex.com/909P3tvS55f.png "Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png To get more tests to pass, (and fix an assert in Ganesh), I've gone ahead and enforced that user supplied rects (in drawRect and drawOval) are always sorted once they hit the canvas virtuals. Currently, drawArc rejects empty ovals, but I added the same assert to onDrawArc, if we decide to change the strategy there. Bug: skia: Change-Id: I021a18c85e234298e1d29f333662683d996dd42c Reviewed-on: https://skia-review.googlesource.com/16983 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* skslc SPIR-V mod supportGravatar Ethan Nicholas2017-05-17
| | | | | | | Change-Id: I2df761ff0d25712dc48d367585d4b639e46d5d97 Reviewed-on: https://skia-review.googlesource.com/17243 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/6685fe37889919448bfa3bbf3d93e15026680e0a Bisect - Check for gerrit patch properties. (simonhatch@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb2b1d0029950de9dbd30d8a7064c89cc951c6b6 Reviewed-on: https://skia-review.googlesource.com/17240 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Adjust start and end points of arcs based on CTMGravatar Brian Osman2017-05-17
| | | | | | | | | | | GPU was effectively ignoring rotation and scale when drawing arcs. Found this with a new GM I'll be adding. Hoping to land that separately. Bug: skia: Change-Id: I14d36ceaa478193c1a75fb2d06704e7d51f46d02 Reviewed-on: https://skia-review.googlesource.com/17218 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Fix for amd copy as draws on vulkanGravatar Greg Daniel2017-05-17
| | | | | | | | | | | | Our copies as draws have the same bug on amd as normal bugs where we need to start a new command buffer before binding a pipeline to it. Bug: skia: Change-Id: If9cade2e069bf09758c5328bf606c9bd5b5aab9c Reviewed-on: https://skia-review.googlesource.com/17213 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/b8526d5091832eff8dadd54a21967ba7fa3c51ba Turn the 'archive_profile_database' errors into warnings. (sebmarchand@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8db0bb0ade49b80b14e29a86acaba9e541fc6c98 Reviewed-on: https://skia-review.googlesource.com/17217 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* skslc comma operator and optimizer fixesGravatar Ethan Nicholas2017-05-17
| | | | | | | | Bug: skia: Change-Id: I732d4fba843c06af570d4a56cadfaa1cc565808c Reviewed-on: https://skia-review.googlesource.com/17125 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/fa05f0c918ae03a5b0595b44e7bf0b378404d0b0 Turtles all the way down = aka debugging chromium_tests 3. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib4142bf510444462a73e97f21475df503859ad41 Reviewed-on: https://skia-review.googlesource.com/17216 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* scalarize SkGradientShader stop setupGravatar Mike Klein2017-05-17
| | | | | | | | | | | | One of Clankium's GCC 4.9 builds is crashing when compiling the existing Sk4f version, so let's try ordinary scalar math. BUG=chromium:721682 Change-Id: Ie37bf530ada537363119acd31814ae46cd3adf73 Reviewed-on: https://skia-review.googlesource.com/17210 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Delete legacy image generator API flagGravatar Matt Sarett2017-05-17
| | | | | | | | Bug: skia:6620 Change-Id: I7ecdb5b162d8d468d91d4c8dbe276fabe349dc15 Reviewed-on: https://skia-review.googlesource.com/17215 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/6693edfe68b50da94228077969ef3fe1af3becf4 Turtles all the way down = aka debugging chromium_tests. (tandrii@chromium.org) https://crrev.com/c69c5e6e2a2d11156e8adf2dab4a9052d63ccf1b Turtles all the way down = aka debugging chromium_tests 2. (tandrii@chromium.org) https://crrev.com/d9baad869a80389fbe6796415ae5596ccf0bbdd3 Remove debug output during recipe training. (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7513d133502918f52aa38acbc1dd38e59e2362ea Reviewed-on: https://skia-review.googlesource.com/17214 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Remove RenderTarget pointer from GrRenderTargetOpList::RecordedOpGravatar Robert Phillips2017-05-17
| | | | | | | | | Change-Id: I08afe531cd9c65af4b3f6b6006bc3eaf7071cfec Change-Id: I08afe531cd9c65af4b3f6b6006bc3eaf7071cfec Reviewed-on: https://skia-review.googlesource.com/17117 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Remove static initializer of GrProcessorSet::gEmptyGravatar Brian Salomon2017-05-17
| | | | | | | Change-Id: I9d4cb34c54458ad42a413f251d1018217de26b90 Reviewed-on: https://skia-review.googlesource.com/17206 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-17
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/591dc20cf87064d636e8921448ba8a5d00e97039 WebRTC: Add gerrit tryjob expectation to the recipes. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3033b157238261cef31c7423f6d22bf9aed5aadb Reviewed-on: https://skia-review.googlesource.com/17208 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* remove some stray semicolonsGravatar Mike Klein2017-05-17
| | | | | | | Change-Id: I00db78597f6c19b309569e771a5ff843365f7850 Reviewed-on: https://skia-review.googlesource.com/17207 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 22:52:35 +0000