aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* NEON has a ternary instruction.Gravatar mtklein2015-07-27
| | | | | | | | Nothing seems to run any faster or slower, but it is terser. BUG=skia: Review URL: https://codereview.chromium.org/1255913004
* Make allocation count in TextBatch implicitGravatar bsalomon2015-07-27
| | | | Review URL: https://codereview.chromium.org/1254903002
* Remove skia_arch_width, fold into skia_arch_type.Gravatar Brian Salomon2015-07-27
| | | | | | | | | DOCS_PREVIEW= https://skia.org/?cl=1228553010 BUG=skia:4042 R=borenet@google.com, mtklein@google.com Review URL: https://codereview.chromium.org/1228553010
* Added GrGLBlend.h|cpp with helper function AppendPorterDuffBlend() in ↵Gravatar wangyix2015-07-24
| | | | | | | | preparation for SkComposeShader gpu backend BUG=skia: Review URL: https://codereview.chromium.org/1254833003
* mixed text blobs really draws LCDGravatar joshualitt2015-07-24
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1261483002
* Update Android Apps to use gradleGravatar djsollen2015-07-24
| | | | | | | | | | | This CL replaces ant with gradle for the task of building APKs. The primary driver of this change is that it now allow us to develop and test our apps using Android Studio. DOCS_PREVIEW= https://skia.org/?cl=1215023017 Committed: https://skia.googlesource.com/skia/+/425535f1626932e4e22f61a2571f9c3c2b1c5977 Review URL: https://codereview.chromium.org/1215023017
* rename portable_typeface_always to portable_typefaceGravatar caryclark2015-07-24
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1257773002
* fix for GrAtlasTextContext occasionally crashes on mixed runsGravatar joshualitt2015-07-24
| | | | | | | TBR=bsalomon@google.com BUG=510931 Review URL: https://codereview.chromium.org/1252423002
* make fontscalar gammatext lcdtext typeface verttext2 gm portableGravatar caryclark2015-07-24
| | | | | | | | | Pass generic font names to tool util function to generate platform specific fonts and gm test output by unique name. R=bungeman@google.com Review URL: https://codereview.chromium.org/1256903002
* Minimize retrieving SkGlyph in GrTextContextGravatar joshualitt2015-07-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1257603005
* Fix Ganesh drawAtlas bug with quad colorsGravatar robertphillips2015-07-24
| | | | | | | | Ganesh was not expanding the quad colors to vertex colors before calling drawVertices. The new GM would've caught this bug and reveals Ganesh's limitations re the various xfer modes used with drawAtlas (i.e., w/o AA Ganesh only supports kModulate, w/ AA Ganesh only supports the coefficient-based xfer modes). Review URL: https://codereview.chromium.org/1254943002
* Set preallocated TextBatch geometries to 4 rather than 32Gravatar bsalomon2015-07-24
| | | | Review URL: https://codereview.chromium.org/1256843003
* skia: wrong calling convention on eglGetPlatformDisplayEXTGravatar hendrikw2015-07-24
| | | | | | | | | | | | When attempting to run the release compile of nanobench on windows, I would immediately crash due to c++'s buffer security check. This was caused by calling the function with the wrong calling convention. I'm not sure how this ever worked for anyone. Anyway, fix is to use eglext.h's version of the function definition. Review URL: https://codereview.chromium.org/1250383002
* make dftext gm not overlap itselfGravatar caryclark2015-07-23
| | | | | | TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/1253643004
* make fontcache textblob gm portableGravatar caryclark2015-07-23
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1245123006
* fix path ops fuzz busterGravatar caryclark2015-07-23
| | | | | | | | | | | | Mark collapsed segments as done and remove collapsed segment references from the coincidence array. Also add test names to global debugging. R=fmalita@chromium.org BUG=512592 Review URL: https://codereview.chromium.org/1250293002
* make dftext the same on Linux and AndroidGravatar caryclark2015-07-23
| | | | | | | | | Use the same font sizes on both platforms so that the gm images are easier to compare one to the other. TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/1253573006
* Remove test of illegal behavior that modifies a texture backing an SkImage.Gravatar bsalomon2015-07-23
| | | | Review URL: https://codereview.chromium.org/1244143004
* Fix Android x86 compile on macGravatar msarett2015-07-23
| | | | | | | | It appears I failed to fully disable it on the first attempt. BUG=skia: Review URL: https://codereview.chromium.org/1249083004
* Skia: ANGLE RollGravatar hendrikw2015-07-23
| | | | | | | | Includes fix for vertex index. BUG=510585 Review URL: https://codereview.chromium.org/1246143005
* fix typeface leakGravatar caryclark2015-07-23
| | | | | | TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1239303003
* Fix ImageNewSurface test on S4.Gravatar bsalomon2015-07-23
| | | | | | This still leaves the SkImage_NewFromTexture broken. Review URL: https://codereview.chromium.org/1253513004
* Fix variable shadowing in SkMorphologyImageFilterGravatar robertphillips2015-07-23
| | | | Review URL: https://codereview.chromium.org/1245883005
* Update fallback rsqrt implementation to use optimal constants.Gravatar jvanverth2015-07-23
| | | | | | | | | Improves max relative error from 0.00175126 to 0.000650197. Also add unit tests to check error bounds. BUG=chromium:511458 Review URL: https://codereview.chromium.org/1251423002
* fix comment on GrBatchTextStrikeGravatar joshualitt2015-07-23
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1252783002
* fix typoGravatar caryclark2015-07-23
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1245993003
* Have Windows use _mm_rsqrt_ss too.Gravatar mtklein2015-07-23
| | | | | | | | | | | | | | | | | | | | | | | Tidy up a little while I'm in here: 1) SIMD headers are now included by SkTypes.h as appropriate. 2) _mm_cvtss_f32() is pithier and generates the same code. Looks like this is the only code checking for SSE wrong. After this CL: ~/skia (sse) $ git grep __SSE include/core/SkPreConfig.h: #if defined(__SSE4_2__) include/core/SkPreConfig.h: #elif defined(__SSE4_1__) include/core/SkPreConfig.h: #elif defined(__SSE3__) include/core/SkPreConfig.h: #elif defined(__SSE2__) every other check is in SkPreConfig.h where it belongs. This is going to affect some GMs subtly on Windows. BUG=chromium:511458 No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1248503004
* Small tweak to TextBlobCacheTestGravatar joshualitt2015-07-23
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1251383003
* fix memory leak in TextBlobCacheTestGravatar joshualitt2015-07-23
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1252593002
* Attempt to somewhat simplify GrContext::readSurfacePixels interaction with ↵Gravatar bsalomon2015-07-23
| | | | | | GrGpu. Review URL: https://codereview.chromium.org/1255483005
* Fix formatting in the CQ keywords markdownGravatar rmistry2015-07-23
| | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1247323002 TBR=jcgregorio Review URL: https://codereview.chromium.org/1247323002
* Name of primitive processor will now be printed in generated shader codeGravatar wangyix2015-07-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1253513003
* Revert "Update Android Apps to use gradle"Gravatar joshualitt2015-07-23
| | | | | | | | | | | | This reverts commit 425535f1626932e4e22f61a2571f9c3c2b1c5977. NOTRY=true NOTREECHECKS=true TBR=djsollen@google.com BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1250233002 Review URL: https://codereview.chromium.org/1250233002
* Added GrGLFragmentProcessor::EmitArgs struct for use with emitCode()Gravatar wangyix2015-07-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1251173002
* Add skia_use_android_framework_defines GYP_DEFINEGravatar borenet2015-07-22
| | | | | | BUG=skia:4082 Review URL: https://codereview.chromium.org/1243383002
* Misc cleanupGravatar robertphillips2015-07-22
| | | | | | | | | | This is split off of https://codereview.chromium.org/1225923010/ (Start tightening correspondence betweeen GrDrawContext and GrRenderTarget). It: fixes some style nits replaces some passing of GrContext with GrTextureProvider & GrDrawContext does a bit of the finer grained creation of GrDrawContexts Review URL: https://codereview.chromium.org/1245183002
* Update Android Apps to use gradleGravatar djsollen2015-07-22
| | | | | | | | | This CL replaces ant with gradle for the task of building APKs. The primary driver of this change is that it now allow us to develop and test our apps using Android Studio. DOCS_PREVIEW= https://skia.org/?cl=1215023017 Review URL: https://codereview.chromium.org/1215023017
* Fix up textblobcachetestGravatar joshualitt2015-07-22
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1250003003
* 565 support for SIMD xfermodesGravatar mtklein2015-07-22
| | | | | | | | | | | | | | | | | | | | | | This uses the most basic approach possible: - to load an Sk4px from 565, convert to SkPMColors on the stack serially then load those SkPMColors. - to store an Sk4px to 565, store to SkPMColors on the stack then convert to 565 serially. Clearly, we can optimize these loads and stores. That's a TODO. The code using SkPMFloat is the same idea but a little more long-term viable, as we're only operating on one pixel at a time anyway. We could probably write 565 <-> SkPMFloat methods, but I'd rather not until it's really compelling. The speedups are varied but similar across SSE and NEON: a few uninteresting, many 50% faster, some 2x faster, and SoftLight ~4x faster. This will cause minor GM diffs, but I don't think any layout test changes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/942930dcaa51f66d82cdaf46ae62efebd16c8cd0 Committed: https://skia.googlesource.com/skia/+/860dcaa2ddfdadc050af4f943a84a9d499315066 Review URL: https://codereview.chromium.org/1245673002
* Add drawImage{Rect,} support to SkDebugCanvasGravatar fmalita2015-07-22
| | | | | | R=robertphillips@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/1253473002
* Moved GrGLFragmentProcessor definition to its own fileGravatar wangyix2015-07-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1246193002
* Remove some redundant fields from BitmapTextBatch (and rename to TextBatch).Gravatar bsalomon2015-07-22
| | | | Review URL: https://codereview.chromium.org/1244093004
* skia: GrGLAssembleGLInterface update load chromium extension functionsGravatar hendrikw2015-07-22
| | | | | | | | Command buffer will expose GL_CHROMIUM_framebuffer_multisample and GL_CHROMIUM_map_sub, added support for these to enable interface validation to succeed. Review URL: https://codereview.chromium.org/1248853003
* Fix Android framework buildGravatar msarett2015-07-22
| | | | | | | | | | | | The Android framework was failing on conditions in libjpeg-turbo.gyp, even though libjpeg-turbo is listed in dependencies! for the framework (maybe because I forgot to add export_dependent_settings!). This is fixed by rearranging the gyp file. BUG=skia: Review URL: https://codereview.chromium.org/1249003002
* Fix tile drop-out on S4 for texture decal mode.Gravatar jvanverth2015-07-22
| | | | | | | | | Switch to use highp on interpolants. Also removes some unnecessary formatting. BUG=skia:3381 Review URL: https://codereview.chromium.org/1245703004
* Coverage: add a trace for not_covered_lines per fileGravatar borenet2015-07-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example output: { "build_number": "2", "gitHash": "71f5db892ee7ed9fbb573da28ccb906e18ba24a4", "key": { "arch": "x86_64", "compiler": "Clang", "configuration": "Coverage", "cpu_or_gpu": "CPU", "cpu_or_gpu_value": "AVX2", "model": "GCE", "os": "Ubuntu" }, "results": { "dm_DMGpuSupport_h": { "coverage": { "lines_not_covered": 6, "options": { "dir": "dm", "fullname": "dm/DMGpuSupport.h", "source_type": "coverage" }, "percent": 33.33333333333333 } }, "dm_DMJsonWriter_cpp": { ...... BUG=skia:2430 Review URL: https://codereview.chromium.org/1246043002
* Add the ability to decode a subset to SkCodecGravatar scroggo2015-07-22
| | | | | | | | | | | | | | | | | | | | | | | | This allows codecs that support subsets natively (i.e. WEBP) to do so. Add a field on SkCodec::Options representing the subset. Add a method on SkCodec to find a valid subset which approximately matches a desired subset. Implement subset decodes in SkWebpCodec. Add a test in DM for decoding subsets. Notice that we only start on even boundaries. This is due to the way libwebp's API works. SkWEBPImageDecoder does not take this into account, which results in visual artifacts. FIXME: Subsets with scaling are not pixel identical, but close. (This may be fine, though - they are not perceptually different. We'll just need to mark another set of images in gold as valid, once https://skbug.com/4038 is fixed, so we can tests scaled webp without generating new images on each run.) Review URL: https://codereview.chromium.org/1240143002
* Fix SkCanvas::wouldOverwriteEntireSurface() contains testGravatar fmalita2015-07-22
| | | | | | R=reed@google.com,robertphillips@google.com,bsalomon@google.com Review URL: https://codereview.chromium.org/1244093005
* Fix CQ keyword and add more detailGravatar rmistry2015-07-22
| | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1246393002 TBR=jcgregorio Review URL: https://codereview.chromium.org/1246393002
* Revert of 565 support for SIMD xfermodes (patchset #4 id:60001 of ↵Gravatar mtklein2015-07-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1245673002/) Reason for revert: NEON 565 gold images have gone ugly. This is what I get for writing and testing SSE and just writing NEON. E.g. colortype_xfermodes, dstreadshuffle, bigbitmaprect, pictures, textbloblooper, aaxfermodes (only Plus) Original issue's description: > 565 support for SIMD xfermodes > > This uses the most basic approach possible: > - to load an Sk4px from 565, convert to SkPMColors on the stack serially then load those SkPMColors. > - to store an Sk4px to 565, store to SkPMColors on the stack then convert to 565 serially. > > Clearly, we can optimize these loads and stores. That's a TODO. > > The code using SkPMFloat is the same idea but a little more long-term viable, as we're only operating on one pixel at a time anyway. We could probably write 565 <-> SkPMFloat methods, but I'd rather not until it's really compelling. > > The speedups are varied but similar across SSE and NEON: a few uninteresting, many 50% faster, some 2x faster, and SoftLight ~4x faster. > > This will cause minor GM diffs, but I don't think any layout test changes. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/942930dcaa51f66d82cdaf46ae62efebd16c8cd0 > > Committed: https://skia.googlesource.com/skia/+/860dcaa2ddfdadc050af4f943a84a9d499315066 TBR=msarett@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1248893004