aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* SkPDF: do not use SkRegion in populateGraphicStateEntryFromPaint()Gravatar Hal Canary2017-02-22
| | | | | | | Change-Id: I3eb192426f5b648fe7ad7db3c8dac42771be0197 Reviewed-on: https://skia-review.googlesource.com/8893 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Don't include GrContextFactory.h from SkCommonFlagsPathRenderer.hGravatar csmartdalton2017-02-22
| | | | | | | | | | BUG=skia: Change-Id: Ied4d23120cd21542314c45369597f375ca8affcf Reviewed-on: https://skia-review.googlesource.com/8788 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Use uintptr_t for masking ptrs.Gravatar Herb Derby2017-02-22
| | | | | | | | | | TBR=mtklein@google.com Change-Id: I9f63087345f65547689dd77449cf6640aa886354 Reviewed-on: https://skia-review.googlesource.com/8890 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
* Revert[2] "hide deprecated underline and strikethru"Gravatar Mike Reed2017-02-22
| | | | | | | | | | | | | android now updated. This reverts commit e005edd3a5deb602beec59f59cdc8b14d3764d58. BUG=skia:6250 Change-Id: If08d344cdd863fde1d9955dc3fab671a83be0f73 Reviewed-on: https://skia-review.googlesource.com/8815 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Actually test our ref-counting in release buildsGravatar Brian Osman2017-02-22
| | | | | | | | | BUG=skia: Change-Id: I8df5c84bf961a3be68a642ba338fdc641e09df59 Reviewed-on: https://skia-review.googlesource.com/8889 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Viewer: balance save/restores and draw offscreen to window in src modeGravatar Brian Salomon2017-02-22
| | | | | | | Change-Id: I9a9bff1c950aaeda095ee49b4860c6fee04ea731 Reviewed-on: https://skia-review.googlesource.com/8887 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkPDF: use RasterClip and Region less.Gravatar Hal Canary2017-02-22
| | | | | | | | | | | | * GraphicStackState::updateClip() uses device bounds, not region bounds * SkPDFDevice::handleInversePath() uses clipstack, not rasterclip Rendered PDF Changes: unnoticable. Change-Id: Ibf9c169a5ada828c8fefedf2bcb37f6de34f3528 Reviewed-on: https://skia-review.googlesource.com/8885 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Check for bounds intersection when batching MSAAPathOpsGravatar Jim Van Verth2017-02-22
| | | | | | | Change-Id: Ic4f1e13728b1137ffdc94dab077ec065619a0221 Reviewed-on: https://skia-review.googlesource.com/8883 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Add the ability to enable/disable GPU path renderersGravatar csmartdalton2017-02-22
| | | | | | | | | | | | | | Adds a bitfield to GrContextOptions that masks out path renderers. Adds commandline flags support to set this bitfield in tools apps. Removes GrGLInterfaceRemoveNVPR since we can now accomplish the same thing in the context options. BUG=skia: Change-Id: Icf2a4df36374b3ba2f69ebf0db56e8aedd6cf65f Reviewed-on: https://skia-review.googlesource.com/8786 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix SkSemaphore comments.Gravatar Mike Klein2017-02-22
| | | | | | | Change-Id: I14fc03fcb73bad61daed7c4cd3ed12bfae6b1217 Reviewed-on: https://skia-review.googlesource.com/8880 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkJumper: add mode to help prioritize portingGravatar Mike Klein2017-02-22
| | | | | | | Change-Id: I57c9fa4ce3ef70ddd8a98b0a5843d1f5108fe6e8 Reviewed-on: https://skia-review.googlesource.com/8857 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkJumper: set_rgb and swap_rbGravatar Mike Klein2017-02-22
| | | | | | | | | | swap_rb is a big limiting factor on Windows and Linux. set_rgb just happened to be nearby and easy. Change-Id: Ic529c7578eeb278476821090127fa8fb1f70c04f Reviewed-on: https://skia-review.googlesource.com/8859 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update endRecordingAsPicture to finishRecordingAsPictureGravatar Yuqian Li2017-02-22
| | | | | | | | | | | BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=8854 Change-Id: Ia3ad32d088d44fbe47ec37de016931c4bd21231c Reviewed-on: https://skia-review.googlesource.com/8854 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Make GrPipelineAnalysis a nested class of GrProcessorSet.Gravatar Brian Salomon2017-02-22
| | | | | | | | | | | | | | | | It is renamed to FragmentProcessorAnalysis since it represents the outputs of the final FPs. It now stores the analysis results that are subsequently needed rather than exposing GrProcOptInfo. GrProcOptInfo is now only used on color FPs (not coverage). Miscellaneous related renamings. Change-Id: I95c518a7a76df6dc294a9fa67c611f8f653247bc Reviewed-on: https://skia-review.googlesource.com/8534 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* hide trivial helpers on canvasGravatar Mike Reed2017-02-22
| | | | | | | | | BUG=skia: Change-Id: I42d4ca92897bde5bd8e0575a0104b12b83134cef Reviewed-on: https://skia-review.googlesource.com/8852 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkJumper: implement lerp_u8Gravatar Mike Klein2017-02-22
| | | | | | | | | | Going to start filling these in in biggest-bang-for-the-buck order. lerp_u8 (i.e. text drawing) is number 1 right now. Change-Id: If58eaf8ddbb93a6b954c3700fa1a476dca94a809 Reviewed-on: https://skia-review.googlesource.com/8856 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Attempt to stabilize shadow_utils GM for replay configsGravatar Brian Salomon2017-02-22
| | | | | | | Change-Id: I0ed15ab102fa1e0a364d5f3a953bedd8afbda3c3 Reviewed-on: https://skia-review.googlesource.com/8853 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Enable legacy premuls in SkColorSpaceXformGravatar Matt Sarett2017-02-22
| | | | | | | | | | | | | | | | | | | | | ***Will allow for simplified Android framework code, they typically want a color correct transform followed by a gamma encoded premul. ***Chrome does the same, so this will make it easier to replace their codecs. ***Will decrease code size. Both types of premuls are moved off the fast path here - one is essentially unused in production and the other is not "encouraged". ***Will actually make the common case faster: sRGB->sRGB means no color xform, just premul in SkSwizzler. BUG=skia: CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: Ia4ec1d273b6f137151f951d37c0ebf975f6b9a3e Reviewed-on: https://skia-review.googlesource.com/8848 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Matt Sarett <msarett@google.com>
* Switch SkTaskGroup to std::atomic.Gravatar Mike Klein2017-02-22
| | | | | | | | | No interesting change, just getting on std APIs. Change-Id: I0f42cbb6854b49a6ae8266e5b92f977d27f4e032 Reviewed-on: https://skia-review.googlesource.com/8860 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* fix typo in SkTaskGroup.hGravatar Mike Klein2017-02-22
| | | | | | | | | This was meant to stay -1 (num_cores() threads) not to become 1 (1 thread). Change-Id: Ib9b8e1963c0cd16d4c0aba02ccf7a65890a5ef78 Reviewed-on: https://skia-review.googlesource.com/8851 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add new GMs to stress rendering of many circles and rrectsGravatar Jim Van Verth2017-02-22
| | | | | | | Change-Id: I060419bc39484b379329a1691e199d9d3db9c808 Reviewed-on: https://skia-review.googlesource.com/8807 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* remove device field from SkDrawGravatar Mike Reed2017-02-22
| | | | | | | | | BUG=skia:6214 Change-Id: I5d57feb3e92f2c1691231c982e74020560febeca Reviewed-on: https://skia-review.googlesource.com/8837 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkClipStack: add bounds() and isEmpty() methodsGravatar Hal Canary2017-02-22
| | | | | | | | | Also: update some of SkPDF to use these rather than the RasterClip. Change-Id: I5a2564d2269c145135df6a8eda65ab05e4aeaf14 Reviewed-on: https://skia-review.googlesource.com/8159 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkExecutorGravatar Mike Klein2017-02-22
| | | | | | | | | | | | | | | | | | Refactoring to refamiliarize myself with SkTaskGroup and SkThreadPool. This adds an SkExecutor interface to describe how we use SkThreadPool, with a global setter and getter for a default instance. Then I rewrote SkTaskGroup to work with any executor, the global default by default. I also think I've made the SkTaskGroup::wait() borrow logic clearer with the addition of SkSemaphore::try_wait(). This lets me keep the semaphore count and actual count of work in perfect sync. Change-Id: I6bbdfaeb0e2c3a43daff6192d34bc4a3f7210178 Reviewed-on: https://skia-review.googlesource.com/8836 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fold MSAN awareness into SkJumper.cpp.Gravatar Mike Klein2017-02-22
| | | | | | | | | | | This is preparation for removing skia_enable_jumper, making it true. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN Change-Id: I21763ea5ebafaaddda7056176796307f1a81d722 Reviewed-on: https://skia-review.googlesource.com/8830 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Reland "CQ config: add gerrit CQAbility verifier."Gravatar Andrii Shyshkalov2017-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 02241e976b34c8bc4b2d4add2f0c881d8a8d2bc1. Reason for revert: cq proto has been rolled to depot_tools. Original change's description: > Revert "CQ config: add gerrit CQAbility verifier." > > This reverts commit 04628221324eb2e5b329a8fd9c69196ea9acb43c. > > Reason for revert: Lets revert until the proto is rolled into Skia. > > Original change's description: > > CQ config: add gerrit CQAbility verifier. > > > > Goal is to ensure that unreviewed and untrusted code isn't sent through > > CQ to try bots, by accident or through malicious intent. > > > > R=​rmistry@google.com > > BUG=chromium:692613 > > NOTRY=True > > > > Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0 > > Reviewed-on: https://skia-review.googlesource.com/8620 > > Reviewed-by: Ravi Mistry <rmistry@google.com> > > Commit-Queue: Ravi Mistry <rmistry@google.com> > > > > TBR=rmistry@google.com,reviews@skia.org,tandrii@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:692613 > > Change-Id: I6d4b821b2a02ef3e097cf68cd8ebfb2b51d4d165 > Reviewed-on: https://skia-review.googlesource.com/8663 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> > R=rmistry@google.com,reviews@skia.org,tandrii@google.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=chromium:692613 Change-Id: Icefcd69b4608e5294f358de66a9ce014c9950ede Reviewed-on: https://skia-review.googlesource.com/8740 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove GrPipelineBuilder.cppGravatar Brian Salomon2017-02-22
| | | | | | | Change-Id: I14c26f2967e4722fa4d6ce4664a5857add0cf854 Reviewed-on: https://skia-review.googlesource.com/8822 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* GrTessellator: misc. cleanups and minor tweaks.Gravatar Stephen White2017-02-22
| | | | | | | | | | | | | | | | | | | | | Invert some math to remove a negation. Don't keep a persistent count in EdgeList; we'll test for degenerate boundaries in boundary_to_aa_mesh(). Make connect() use the top/bottom ordering that new_edge has already done for us. Don't add the an edge to the same poly twice when it's easily detectable. Remove some superfluous variables and intialization. BUG=skia: Change-Id: I0efd9ec385d6dfec8950b7acfc6dd25572f667b5 Reviewed-on: https://skia-review.googlesource.com/8784 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Remove special build for Valgrind.Gravatar Ben Wagner2017-02-22
| | | | | | | | | | | Valgrind uses the unmodified binary. See skia:6267. BUG=skia:6267 Change-Id: I3fcecf9ffce67ebec88d4005e464c66d25c6aa21 Reviewed-on: https://skia-review.googlesource.com/8833 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix tasks.json after crossed CLs.Gravatar Ben Wagner2017-02-22
| | | | | | | | | | | | | These two CLs caused failure on Housekeeper-PerCommit-InfraTests: https://skia-review.googlesource.com/8839 https://skia-review.googlesource.com/8805 NOTRY=true Change-Id: Ie27c2fd73186cdd4d9ae5528635bc9690df03210 Reviewed-on: https://skia-review.googlesource.com/8845 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* SkJumper: remove TODO.Gravatar Mike Klein2017-02-22
| | | | | | | | | | Starting with uninitialized vectors is only minorly faster (<0.5%). I'd rather keep the zeroes and feel warm and fuzzy. Change-Id: Ib28aef9c9a75f53e2ab645bfb094582e30b7df07 Reviewed-on: https://skia-review.googlesource.com/8825 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add eGPU jobs.Gravatar Ben Wagner2017-02-22
| | | | | | | Change-Id: Ia160d3b17abebf0075f8ce2b608653e496f46d58 Reviewed-on: https://skia-review.googlesource.com/8805 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix Mesa compileGravatar Brian Osman2017-02-22
| | | | | | | | | | BUG=skia: Change-Id: Id532233537d18e6185a83681188aa73527b212a1 Reviewed-on: https://skia-review.googlesource.com/8842 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* SkRegion: change serialization unit tests, better validation codeGravatar Hal Canary2017-02-22
| | | | | | | | | Also: Don't alloc before validation. Change-Id: Ic2e007ecf4e06fb099366295b963f66df3f7903a Reviewed-on: https://skia-review.googlesource.com/8728 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Do not retry test or perf tasksGravatar Eric Boren2017-02-22
| | | | | | | | | BUG=skia: Change-Id: I153978a92420eb2c39024213ebcdf95d1b8bde30 Reviewed-on: https://skia-review.googlesource.com/8839 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Whitespace change to test new submit strategy IIGravatar Ravi Mistry2017-02-22
| | | | | | | | | | BUG=skia: NOTRY=true Change-Id: I1dd15dcc85967689a55b9661807dd9eab135f014 Reviewed-on: https://skia-review.googlesource.com/8843 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Whitespace change to test new submit strategy IGravatar Ravi Mistry2017-02-22
| | | | | | | | | BUG=skia: NOTRY=true Change-Id: I9a20af0c57d98f86794d6ce6f37ee8200fe8e088 Reviewed-on: https://skia-review.googlesource.com/8840 Reviewed-by: Ravi Mistry <rmistry@google.com>
* Whitespace change to test new submit strategy IIGravatar Ravi Mistry2017-02-22
| | | | | | | | | | BUG=skia: NOTRY=true Change-Id: I21778ed732f53f2216cfc007c43016c83926176a Reviewed-on: https://skia-review.googlesource.com/8841 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Support shared GL contexts in GrContextFactoryGravatar Brian Osman2017-02-22
| | | | | | | | | | | | | | | | Mostly plumbing, plus some minimal testing to make sure that the platform APIs don't explode. I plan to add testing of SkCrossContextImageData using this, which should verify that textures are actually shared. Also found a factory and some related code in the CommandBuffer test context that was totally unused. BUG=skia: Change-Id: I05bbc22c4d1ef946b702a5cc7f67788785219c62 Reviewed-on: https://skia-review.googlesource.com/8808 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* remove guard for SkImageGenerator apiGravatar Mike Reed2017-02-22
| | | | | | | | | BUG=skia: Change-Id: I0c01fbf935be5d933aa2ef67a0fb2edba4941fa7 Reviewed-on: https://skia-review.googlesource.com/8835 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* expore flags for text decoration into android-specific reserved bitsGravatar Mike Reed2017-02-22
| | | | | | | | | | | BUG=skia:6250 precursor to https://skia-review.googlesource.com/c/8815/ Change-Id: I0ff13ff99299edcb7809a2088e0ace61bc8cc60d Reviewed-on: https://skia-review.googlesource.com/8816 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkConvertPixels: Add Alpha8 fast pathGravatar Matt Sarett2017-02-22
| | | | | | | | | BUG:692936 Change-Id: I8394554764b1f46bd8eaabb0194d52f361d477c1 Reviewed-on: https://skia-review.googlesource.com/8826 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Split Valgrind jobs -- one DM/NB run per task.Gravatar Ben Wagner2017-02-22
| | | | | | | | | | | | Reland of https://skia-review.googlesource.com/c/8723/1 BUG=skia:2789 NOTRY=true Change-Id: I1fbd314457a9d411543c8d7af4df166608d1acc7 Reviewed-on: https://skia-review.googlesource.com/8832 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Split Valgrind jobs -- one DM/NB run per task."Gravatar Ben Wagner2017-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bc9cd524d8ce8fd61ff6e49fa2a6e2a26a069874. Reason for revert: Unable to find Valgrind binary. Original change's description: > Split Valgrind jobs -- one DM/NB run per task. > > Remove special build for Valgrind -- Valgrind uses the unmodified binary. See skia:6267. > > BUG=skia:2789,skia:6267 > > Change-Id: Id56c460abf36eb2be633ac3a309e0dbc7a278f41 > Reviewed-on: https://skia-review.googlesource.com/8723 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Eric Boren <borenet@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,borenet@google.com,mtklein@google.com,benjaminwagner@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2789,skia:6267 Change-Id: I16876a8528c441805931ed21e9aa8688ab2e0b4c Reviewed-on: https://skia-review.googlesource.com/8831 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Omit encode-platform on N5 for all configs.Gravatar Ben Wagner2017-02-21
| | | | | | | | | BUG=skia:5876 Change-Id: Icfd000638290418870df857722317c62cb6942d9 Reviewed-on: https://skia-review.googlesource.com/8827 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Whoops, forgot to re-run build_stages.Gravatar Mike Klein2017-02-21
| | | | | | | Change-Id: I723ae1ecaebf43e84bf47163e44e7899faf31c8a Reviewed-on: https://skia-review.googlesource.com/8824 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Split Valgrind jobs -- one DM/NB run per task.Gravatar Ben Wagner2017-02-21
| | | | | | | | | | | | Remove special build for Valgrind -- Valgrind uses the unmodified binary. See skia:6267. BUG=skia:2789,skia:6267 Change-Id: Id56c460abf36eb2be633ac3a309e0dbc7a278f41 Reviewed-on: https://skia-review.googlesource.com/8723 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* fixed SPIR-V vector equality testsGravatar Ethan Nicholas2017-02-21
| | | | | | | | | BUG=skia: Change-Id: I6ae597d16c0bd17ce4c0316e7ef65cd52643f4b7 Reviewed-on: https://skia-review.googlesource.com/8804 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Move looping logic into start_pipeline().Gravatar Mike Klein2017-02-21
| | | | | | | | | | | | | | | | This should be a big win on Windows, but I haven't timed there yet. On my Mac, it's a solid 2% speedup. PS1 was insufficiently ambitious, but was this for posterity: No need to vzeroupper twice on Windows. On Windows start_pipeline() will vzeroupper, so no need to do it in just_return(). Change-Id: I099320b95da85900a60ce96fdb7a216a36db1858 Reviewed-on: https://skia-review.googlesource.com/8821 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Print GL shader source with line numbers when there is a compile errorGravatar csmartdalton2017-02-21
| | | | | | | | | BUG=skia: Change-Id: I06bad4aacf5992d8207881f59f20615479536481 Reviewed-on: https://skia-review.googlesource.com/8562 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>