aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Adding djsollen to list of ownersGravatar rmistry2014-07-18
| | | | | | | | | | | (SkipBuildbotRuns) BUG=skia: R=djsollen@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/397813007
* update pathops core and testsGravatar caryclark2014-07-18
| | | | | | | | | | split out skpclip (the test of 1M pictures) into its own project TBR=reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/400033002
* Fix mac NDK buildsGravatar djsollen2014-07-17
| | | | | | | | R=jvanverth@google.com, scroggo@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/401613005
* Fix GLubyte to GrGLubyte.Gravatar jcgregorio2014-07-17
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/405433008
* Change JSON output of nanobench.Gravatar jcgregorio2014-07-17
| | | | | | | | | | | | | | | | We're moving away from BigQuery for storing results so the output doens't have to conform to BQ requirements, which allows simplifying the format. Also stop parsing the filename for information and pass in buildbot parameters explicitly. Adds the following flags to nanobench: --key --gitHash BUG=skia: R=mtklein@google.com, bsalomon@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/392393002
* combine base_unittest.py modules from gm and toolsGravatar epoger2014-07-17
| | | | | | | | | | general cleanup, which will also help with http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"') R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/397103003
* Remove SkRefPtr.Gravatar bungeman2014-07-17
| | | | | | | | R=mtklein@google.com, reed@google.com, bsalomon@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/393913002
* Revert of nanobench: --veryVerbose for more Win7 debugging ↵Gravatar mtklein2014-07-17
| | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/401663002/) Reason for revert: Shouldn't be needed anymore. Original issue's description: > nanobench: --veryVerbose for more Win7 debugging > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e57452d R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/404543004
* Fix alpha textures in NV ES3 contexts on Windows.Gravatar bsalomon2014-07-17
| | | | | | | | | | | | Make unit tests iterate over all the rendering GL context types rather than using kNative. Fix the extension printing when gStartupSpew is set. R=jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/398183002
* nanobench: --veryVerbose for more Win7 debuggingGravatar Mike Klein2014-07-17
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/401663002
* erase bitmap inside unit test to make valgrind happierGravatar halcanary2014-07-17
| | | | | | | | | R=mtklein@google.com TBR=sunshine Author: halcanary@google.com Review URL: https://codereview.chromium.org/397273006
* Revert of Revert of Revert of Force DM rebuild. ↵Gravatar mtklein2014-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/402663003/) Reason for revert: we have to go deeper Original issue's description: > Revert of Revert of Force DM rebuild. (https://codereview.chromium.org/399123002/) > > Reason for revert: > jkl; > > Original issue's description: > > Revert of Force DM rebuild. (https://codereview.chromium.org/400723002/) > > > > Reason for revert: > > asdf > > > > Original issue's description: > > > Force DM rebuild. > > > > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/8a10de1 > > > > TBR=mtklein@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/f42e08c12533f2a165bc08451f5ab5dd1363618b > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/41f30cd87ece55971b17e4a59873cf31100ee1a0 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/397293004
* Revert of Revert of Force DM rebuild. ↵Gravatar mtklein2014-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/399123002/) Reason for revert: jkl; Original issue's description: > Revert of Force DM rebuild. (https://codereview.chromium.org/400723002/) > > Reason for revert: > asdf > > Original issue's description: > > Force DM rebuild. > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/8a10de1 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/f42e08c12533f2a165bc08451f5ab5dd1363618b R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/402663003
* Add IsPath to GrGLInterfaceGravatar cdalton2014-07-17
| | | | | | | | | | | This will be used by path ranges. BUG=skia: R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/403563002
* Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL ↵Gravatar bsalomon2014-07-17
| | | | | | | | | | | | when textures and RTs are deleted. Also, rename GrCacheable::getGenerationID() to getInstanceID() since it doesn't behave like other "generation" IDs. R=jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/376703009
* Revert of Force DM rebuild. (https://codereview.chromium.org/400723002/)Gravatar mtklein2014-07-17
| | | | | | | | | | | | | | | | | | | | | | Reason for revert: asdf Original issue's description: > Force DM rebuild. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8a10de1 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/399123002
* Force DM rebuild.Gravatar Mike Klein2014-07-17
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/400723002
* nanobench: Protect more against infinite loops.Gravatar mtklein2014-07-17
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/404543002
* Make GrLayerCache use multiple plots in its atlasGravatar robertphillips2014-07-17
| | | | | | | | | | | | Until we have a recycling Rectanizer the atlas purging must occur at the GrPlot level. This CL breaks the atlas into four plots to give some room for purging (without trashing the entire atlas). This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/) R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/397873004
* create copy_config.py and rename_config.py for skbug 2752Gravatar epoger2014-07-17
| | | | | | | | | | | | BUG=skia:2752 NOTRY=True (SkipBuildbotRuns) R=bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/397293002
* Fix warning about missing shared library symbols in android_gdbserverGravatar qiankun.miao2014-07-17
| | | | | | | | | | | | Grab related shared libraryies. Remove libcorkscrew.so due libcorkscrew is removed from AOSP. BUG=skia: R=djsollen@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/399843002
* Makes GrGLProgramDesc's key store the lengths as well as offsets of the ↵Gravatar bsalomon2014-07-17
| | | | | | | | | | | | | | | | effect keys. Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF. Cleans up docs around GrBackendEffectFactory. Committed: https://skia.googlesource.com/skia/+/c0ea398aff8254e31152cbb94c9ab6150428e252 R=robertphillips@google.com, jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/379113004
* factor out flattening/unflattening of common fields from SkImageFilterGravatar reed2014-07-17
| | | | | | | | | | This is a precursor to changing SkImageFilters (and all effects) to unflatten via a factory instead of a constructor. In that world, each subclass of ImageFilter will need to control/initiate the unflattening of the common fields, so they can be extract and passed to their Factory. R=senorblanco@google.com, robertphillips@google.com, mtklein@google.com, senorblanco@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/395273002
* Generate makefile for bench_pictures.Gravatar scroggo2014-07-17
| | | | | | | | | | | | When generating Android framework makefiles, create one for bench_pictures. BUG=skia:2744 R=djsollen@google.com, halcanary@google.com, mtklein@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/391423002
* Set maximum output size for scaled-image-cache imagesGravatar halcanary2014-07-17
| | | | | | | | | | | | | | Accessable via: SkScaledImageCache::{G,S}etMaximumOutputSizeForHighQualityFilter Also, a unit test. BUG=389439 R=humper@google.com, tomhudson@google.com, reveman@chromium.org, vangelis@chromium.org, reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/394003003
* (temporarily?) disable no-oped benchesGravatar Mike Klein2014-07-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/391343007
* Use __rdtsc on Windows.Gravatar Mike Klein2014-07-16
| | | | | | | | | | | | | | | This seems to be ~100x higher resolution than QueryPerformanceCounter. AFAIK, all our Windows perf bots have constant_tsc, so we can be a bit more direct about using rdtsc directly: it'll always tick at the max CPU frequency. Now, the question remains, what is the max CPU frequency to divide through by? It looks like QueryPerformanceFrequency actually gives the CPU frequency in kHz, suspiciously exactly what we need to divide through to get elapsed milliseconds. That was a freebie. I did some before/after comparison on slow benchmarks. Timings look the same. Going to land this without review tonight to see what happens on the bots; happy to review carefully tomorrow. R=mtklein@google.com TBR=bungeman BUG=skia: Review URL: https://codereview.chromium.org/394363003
* Add new ASTC pixel configGravatar krajcevski2014-07-16
| | | | | | | | R=bsalomon@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/399623004
* roll common DEPS, now using recursedepsGravatar epoger2014-07-16
| | | | | | | | | BUG=skia:2618 R=borenet@google.com, cmp@chromium.org Author: epoger@google.com Review URL: https://codereview.chromium.org/392353003
* Remove benches from DM.Gravatar mtklein2014-07-16
| | | | | | | | | | | This idea turned out to be more redundant than useful. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/399463003
* Disable assertion of fBoundsIsDirty.Gravatar Mike Klein2014-07-16
| | | | | | | | | We allow this to be raced on, and it may have already become not-dirty by the time we get to this function if computed by another thread. BUG=skia: Review URL: https://codereview.chromium.org/398913002
* Remove ambiguous operator= on AutoCFRelease.Gravatar bungeman2014-07-16
| | | | | | | | | | | | The operator= is ambiguous as to the state of the reference count. Until we have rvalue assignment operators, just use 'reset' as the name of the reference stealing assignment to AutoCFRelease. R=reed@google.com, mtklein@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/400453002
* 32 bpp floating point texturesGravatar joshualitt2014-07-16
| | | | | | | | | | | This is VERY preliminary, but it was sufficient for me to get 32 bit floating point textures in a sample app BUG=skia: R=bsalomon@chromium.org, bsalomon@google.com Author: joshualitt@chromium.org Review URL: https://codereview.chromium.org/359803003
* Buffer four scanlines prior to blitting. We will eventually use thisGravatar krajcevski2014-07-16
| | | | | | | | | | | | to blit four scanlines in a row in order to aggressively compress alpha masks as the information comes in. This CL is only to introduce the API and to make sure that nothing breaks in the general case. R=reed@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/387953005
* Generalize mask helper a bit for compressionGravatar krajcevski2014-07-16
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/398603004
* Add unique ID to GrPlotGravatar robertphillips2014-07-16
| | | | | | | | | | This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/) where it is used for plot lifetime management (i.e., tracking which plots are locked). R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/391153002
* Chromium no longer needs the SkPicture default constructorGravatar robertphillips2014-07-16
| | | | | | | | | | With the landing of the Chromium CL (Remove use of default SkPicture constructor - https://codereview.chromium.org/387343003/) Chromium should no longer require the SK_SUPPORT_LEGACY_DEFAULT_PICTURE_CTOR flag. R=halcanary@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/398463002
* Make gdb work for 64-bit SkiaGravatar qiankun.miao2014-07-16
| | | | | | | | | BUG=skia: R=djsollen@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/398733002
* rebaseline most dw changesGravatar Mike Klein2014-07-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/402443002
* Fix broken android framework builds where 32-bit MIPS compilers lack 64-bit ↵Gravatar Derek Sollenberger2014-07-16
| | | | | | | | __sync operators. R=mtklein@google.com, reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/398153002
* Remove yet-unused 64-bit atomic hooks.Gravatar Mike Klein2014-07-16
| | | | | | | | | | | | For now, I think we'll just be using sk_atomic_inc on 64-bit values, so let's cut out the dead code for now. NOTREECHECKS=true BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/398003004
* Remove outdated compiler restrictions.Gravatar Derek Sollenberger2014-07-16
| | | | | | R=scroggo@google.com Review URL: https://codereview.chromium.org/394263002
* Skip tiling on bitmapscroll:Gravatar Mike Klein2014-07-16
| | | | | | | | | | - off by exactly one pixel when using DirectWrite - also at least one pixel off on ChromeOS BUG=skia: R=bungeman@google.com Review URL: https://codereview.chromium.org/394243002
* Reexport skia_gdi.Gravatar Mike Klein2014-07-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/398043004
* Put skia_directwrite back for now.Gravatar Mike Klein2014-07-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/397073002
* skia_directwrite -> skia_gdiGravatar Mike Klein2014-07-16
| | | | | | | | | This will require lots of rebaselines and a bot CL to swap our lone direct write bot to a lone GDI bot. BUG=skia: R=bungeman@google.com Review URL: https://codereview.chromium.org/394223003
* Revert of Reopened: Caching the result of readPixelsSupported ↵Gravatar bungeman2014-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/364193004/) Reason for revert: This appears to be causing failures on Android when running tests. Original issue's description: > Caching the result of readPixelsSupported > > The call was calling GR_GL_GetIntegerv 2 times for each readPixels > and thus was causing a loss of performance > > (resubmit of issue 344793008) > > Benchmark url: http://packages.gkny.fr/tst/index.html > > BUG=skia:2681 > > Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c > > Committed: https://skia.googlesource.com/skia/+/8339371f1ec3c57a0741932fd96bff32c53d4e54 R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, mtklein@google.com, bsalomon@google.com, piotaixr@chromium.org TBR=bsalomon@chromium.org, bsalomon@google.com, junov@chromium.org, mtklein@google.com, piotaixr@chromium.org, reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2681 Author: bungeman@google.com Review URL: https://codereview.chromium.org/395203002
* make gm self-tests launch python unittests automaticallyGravatar epoger2014-07-16
| | | | | | | | | | | | | | | | (not just within the rebaseline_server subdirectory) Generally useful, but needed asap for my work on http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"') BUG=skia:677 NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/398043002
* Revert of Makes GrGLProgramDesc's key store the lengths as well as offsets ↵Gravatar mtklein2014-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of the effect keys. (https://codereview.chromium.org/379113004/) Reason for revert: Most likely candidate for Valgrind failures: [21:10:08.755668] ==3036== Use of uninitialised value of size 8 [21:10:08.755753] ==3036== at 0x734AB2: GrGpuGL::ProgramCache::getProgram(GrGLProgramDesc const&, GrEffectStage const**, GrEffectStage const**) (GrGpuGL_program.cpp:107) [21:10:08.755788] ==3036== by 0x734ED2: GrGpuGL::flushGraphicsState(GrGpu::DrawType, GrDeviceCoordTexture const*) (GrGpuGL_program.cpp:253) [21:10:08.755811] ==3036== by 0x6E81C2: GrGpu::setupClipAndFlushState(GrGpu::DrawType, GrDeviceCoordTexture const*, GrDrawState::AutoRestoreEffects*, SkRect const*) (GrGpu.cpp:350) [21:10:08.755837] ==3036== by 0x6E9BE8: GrGpu::onDraw(GrDrawTarget::DrawInfo const&) (GrGpu.cpp:390) [21:10:08.755858] ==3036== by 0x6EEECE: GrInOrderDrawBuffer::flush() (GrDrawTarget.h:506) [21:10:08.755879] ==3036== by 0x6D0EB4: GrContext::flush(int) (GrContext.cpp:1327) [21:10:08.755900] ==3036== by 0x6D3F8F: GrContext::writeTexturePixels(GrTexture*, int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrContext.cpp:1349) [21:10:08.755922] ==3036== by 0x6D39D7: GrContext::writeRenderTargetPixels(GrRenderTarget*, int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrContext.cpp:1632) [21:10:08.755949] ==3036== by 0x6FFDF3: GrRenderTarget::writePixels(int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrRenderTarget.cpp:45) [21:10:08.755978] ==3036== by 0x735563: SkGpuDevice::onWritePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkGpuDevice.cpp:280) [21:10:08.756003] ==3036== by 0x57A048: SkBaseDevice::writePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkDevice.cpp:106) [21:10:08.756025] ==3036== by 0x56D0AE: SkCanvas::writePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkCanvas.cpp:700) [21:10:08.756050] ==3036== by 0x56D156: SkCanvas::writePixels(SkBitmap const&, int, int) (SkCanvas.cpp:652) [21:10:08.756077] ==3036== by 0x5109B6: test_WritePixels(skiatest::Reporter*, GrContextFactory*) (WritePixelsTest.cpp:464) [21:10:08.756099] ==3036== by 0x51114C: skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (WritePixelsTest.cpp:361) [21:10:08.756122] ==3036== by 0x406BE8: skiatest::Test::run() (Test.cpp:107) [21:10:08.756145] ==3036== by 0x4064C2: SkTestRunnable::run() (skia_test.cpp:109) [21:10:08.756167] ==3036== by 0x405D1A: tool_main(int, char**) (skia_test.cpp:221) [21:10:08.756189] ==3036== by 0x405F75: main (skia_test.cpp:239) [21:10:08.756211] ==3036== Uninitialised value was created by a stack allocation [21:10:08.756233] ==3036== at 0x734CC8: GrGpuGL::flushGraphicsState(GrGpu::DrawType, GrDeviceCoordTexture const*) (GrGpuGL_program.cpp:213) Original issue's description: > Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys. > > Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF. > > Cleans up docs around GrBackendEffectFactory. > > Committed: https://skia.googlesource.com/skia/+/c0ea398aff8254e31152cbb94c9ab6150428e252 R=robertphillips@google.com, jvanverth@google.com, bsalomon@google.com TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/394213002
* Leaking CGBitmapContext in SkFontHost_macGravatar ljagielski2014-07-15
| | | | | | | | | | | | | third_party/skia/src/ports/SkFontHost_mac.cpp: don't increase retain count of newly assigned CFTypeRef in AutoCFRelease::reset(). Each time CFTypeRef is assigned to AutoCFRelease, AutoCFRelease becomes its sole owner. BUG=skia: R=reed@google.com, bungeman@google.com, rmistry@google.com, sheyang@chromium.org Author: ljagielski@opera.com Review URL: https://codereview.chromium.org/393513003
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-29 14:11:36 +0000