| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
| |
N32Premul
patch from issue 781403002 at patchset 20001 (http://crrev.com/781403002#ps20001)
BUG=skia:
Review URL: https://codereview.chromium.org/790733003
|
|
|
|
|
|
| |
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/788903003
|
|
|
|
|
|
|
|
|
| |
degenerate.
BUG=skia:3203
TBR=caryclark
Review URL: https://codereview.chromium.org/785933003
|
|
|
|
|
|
|
|
| |
Nexus 6 appears to require a sized internal format for A8 textures, much
like other newer mobile devices. Changed to use sized format for A8
textures in general with ES 3.0.
Review URL: https://codereview.chromium.org/783523003
|
|
|
|
|
|
| |
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/791713002
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this cl the blending information is extracted for the xp and stored in the ODS
which is then used as it currently is. In the follow up cl, an XP backend will be added
and at that point all blending work will take place inside XP's.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4
Review URL: https://codereview.chromium.org/759713002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/787873002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/784103003
|
|
|
|
|
|
|
|
| |
Also add in explicit set for LCD text in invariantOutput.
BUG=skia:
Review URL: https://codereview.chromium.org/786293002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/787923002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is desirable that, when layer hoisting is disabled, the MPD and non-MPD timings be
roughly the same. Unfortunately, using a separate canvas for each tile (a requirement
for MPD) introduces its own discrepancy into the timing. Using a separate canvas for
each tile doesn't seem to make a difference for 8888 (see the non-MPD 8888 column below)
but slows down GPU rendering (see the non-MPD GPU column below). Since this is how
Chromium renders I propose switching to this regimen (even though it is "slowing down"
GPU rendering).
nanobench mean times (ms) with layer hoisting disabled (for desk_amazon.skp)
8888
MPD non-MPD
1 canvas (old-style) 0.628 1.71
separate (new-style) 0.795 1.63
GPU
MPD non-MPD
1 canvas (old-style) 2.34 1.69
separate (new-style) 2.32 2.66
Review URL: https://codereview.chromium.org/779643002
|
|
|
|
|
|
|
| |
BUG=skia:3187
BUG=skia:3196
Review URL: https://codereview.chromium.org/786353002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/788733003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/777443003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/778783002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/784643002/)
Reason for revert:
Failing serialization tasks in DM:
http://build.chromium.org/p/client.skia/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/352/steps/dm/logs/stdio
Original issue's description:
> Replace EncodeBitmap with an interface.
>
> Gives more flexibility to the caller to decide whether to use the
> encoded data returned by refEncodedData().
>
> Provides an implementation that supports the old version of
> SkPicture::serialize().
>
> TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
>
> BUG=skia:3190
>
> Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1
>
> Committed: https://skia.googlesource.com/skia/+/02b217f80b01a7dda8493422e5257c36a9ce8464
TBR=reed@google.com,rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:3190
Review URL: https://codereview.chromium.org/783393004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gives more flexibility to the caller to decide whether to use the
encoded data returned by refEncodedData().
Provides an implementation that supports the old version of
SkPicture::serialize().
TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
BUG=skia:3190
Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1
Review URL: https://codereview.chromium.org/784643002
|
|
|
|
|
|
|
|
|
|
| |
MatrixImageFilter computeFastBounds)
The msaa4 image diffs aren't actually due to the named CL
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/787093002
|
|
|
|
|
|
|
|
|
|
| |
The compiler may choose to use x30 for a local loop counter;
ensure it's saved. Patch from kevin.petit@arm.com,
verified by benm@google.com.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/786273003
|
|
|
|
|
|
| |
TBR=bsalomon
Review URL: https://codereview.chromium.org/757413003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/784643002/)
Reason for revert:
Compilation is failing on some bots
Original issue's description:
> Replace EncodeBitmap with an interface.
>
> Gives more flexibility to the caller to decide whether to use the
> encoded data returned by refEncodedData().
>
> Provides an implementation that supports the old version of
> SkPicture::serialize().
>
> TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
>
> BUG=skia:3190
>
> Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1
TBR=reed@google.com,scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:3190
Review URL: https://codereview.chromium.org/787833002
|
|
|
|
|
|
|
|
| |
This CL makes the bounding box returned from SkMatrixImageFilter::computeFastBounds actually contain the final result pixels. This, in turn, fixes the first two rows of the filterfastbounds GM and the SVG web page cited in the bug.
BUG=418417
Review URL: https://codereview.chromium.org/785893004
|
|
|
|
|
|
|
|
| |
Also fix YPOS.
R=robertphillips@google.com,jbroman@chromium.org
Review URL: https://codereview.chromium.org/786083002
|
|
|
|
|
|
|
|
| |
Post review cleanup for https://codereview.chromium.org/733203005/
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/784053002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gives more flexibility to the caller to decide whether to use the
encoded data returned by refEncodedData().
Provides an implementation that supports the old version of
SkPicture::serialize().
TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
BUG=skia:3190
Review URL: https://codereview.chromium.org/784643002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
factory. (patchset #7 id:140001 of https://codereview.chromium.org/759713002/)
Reason for revert:
break many gm's
Original issue's description:
> Make all blending up to GrOptDrawState be handled by the xp/xp factory.
>
> In this cl the blending information is extracted for the xp and stored in the ODS
> which is then used as it currently is. In the follow up cl, an XP backend will be added
> and at that point all blending work will take place inside XP's.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/766653008
|
|
|
|
|
|
|
|
| |
Current version incorrectly unpacked the resulting sk unpremulled color into rgba.
BUG=skia:3208
Review URL: https://codereview.chromium.org/787713002
|
|
|
|
|
|
| |
Causing compilation complaints on Windows
Review URL: https://codereview.chromium.org/783683004
|
|
|
|
|
|
|
|
|
|
| |
In this cl the blending information is extracted for the xp and stored in the ODS
which is then used as it currently is. In the follow up cl, an XP backend will be added
and at that point all blending work will take place inside XP's.
BUG=skia:
Review URL: https://codereview.chromium.org/759713002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the tile offset is added when drawing the picture. This might
have made a tiny bit of sense when the picture was always positioned at
origin, but with a picture cull rect offset things looks really strange.
For example, to specify a tile == the picture cull rect we have to pass
in [-cullrect.x, -cullrect.y, cullrect.width, cullrect.height]. Yikes.
(there's also a bug when not passing a tile, as we use a default tile
== cullrect but don't compensate for the above oddity)
This changes the semantics of the tile offset: it is now subtracted when
drawing the picture tile. As a consequence, one can pass in a tile equal
to the cull rect and get the expected behavior (same when not passing
a tile).
This will require a minor Blink change with the roll, as one client
works around the current behavior:
https://codereview.chromium.org/789503003
R=reed@google.com,robertphillips@google.com
BUG=440046
Review URL: https://codereview.chromium.org/733203005
|
|
|
|
|
|
| |
BUG=skia:3205
Review URL: https://codereview.chromium.org/790533002
|
|
|
|
|
|
|
|
| |
This new GM visualizes the fast bounds computed by various image-filter-based SkPaints. This is lead up to fixing some issues in fast bound computation.
BUG=418417
Review URL: https://codereview.chromium.org/788613003
|
|
|
|
|
|
| |
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/768113004
|
|
|
|
|
|
|
| |
BUG=skia:3195, skia:3188
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/778043003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/778373003
|
|
|
|
|
|
| |
BUG=skia:3193
Review URL: https://codereview.chromium.org/783173002
|
|
|
|
|
|
|
|
| |
BUG=skia:
Need https://codereview.chromium.org/785823002/ to land first
Review URL: https://codereview.chromium.org/788533002
|
|
|
|
|
|
|
|
|
|
| |
PathOps relies on isConvex() only returning true for trivially
convex paths. The old logic also returns true if the paths that
contain NaNs and Infinities. Return kUnknown_Convexity instead
in those cases and in cases where the convexity logic computes
intermediaries that overflow.
Review URL: https://codereview.chromium.org/784593002
|
|
|
|
|
|
|
|
|
|
| |
Needs these to land first:
https://codereview.chromium.org/733343005
https://codereview.chromium.org/777413004
BUG=skia:
Review URL: https://codereview.chromium.org/780393002
|
|
|
|
|
|
|
|
|
| |
This allows us to create distance field textures with better precision,
which may help text quality.
BUG=skia:3103
Review URL: https://codereview.chromium.org/762923003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/767873006
|
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/784603002
|
|
|
|
|
|
|
|
| |
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/771353005
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All of our font back-ends use the text size in some way other than
simple concatentation with the current matrix. The code here finds
the full device matrix and then decomposes it to extract the text
size.
FreeType, GDI, and DirectWrite use the text size as the pre-hint scale.
CoreText will not scale color emoji above the requested text size,
and certain features like 'trak' are performed on the text size.
Review URL: https://codereview.chromium.org/748883005
|
|
|
|
|
|
|
|
|
| |
This may cause a perf regression
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/749413003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/780263003
|
|
|
|
|
|
| |
BUG=429409
Review URL: https://codereview.chromium.org/708073002
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/779313002
|
|
|
|
|
|
| |
BUG=skia:3188
Review URL: https://codereview.chromium.org/772633003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/785493003
|