aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Clean up CollectLayers codeGravatar robertphillips2014-11-12
| | | | | | | | | | Now that CollectLayers directly uses FillBounds we can: skip the explicit intersection with the clipBounds after an adjustAndMap call skip the storage and use of the clipBounds in SaveLayerInfo Review URL: https://codereview.chromium.org/719793002
* Move SkRecordComputeLayers and CollectLayers into SkRecordDraw.cppGravatar robertphillips2014-11-12
| | | | | | Rather then exposing parts of FillBounds (as in Expose FillBounds to allow GrPictureUtils::CollectLayers to be layered on top of it - https://codereview.chromium.org/698643002/), this CL moves CollectLayers into SkRecordDraw.cpp to accomplish the layering. Review URL: https://codereview.chromium.org/716913003
* rebaseGravatar joshualitt2014-11-12
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/717033002
* Cleanup: Remove submit_try script.Gravatar tfarina2014-11-12
| | | | | | | | | | It is probably broken, and by now nobody should be using it really anyway. BUG=None R=borenet@google.com Review URL: https://codereview.chromium.org/720603002
* experimentalGravatar reed2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/716793004
* Clang incorrectly thinks this typedef is unused.Gravatar mtklein2014-11-11
| | | | | | BUG=skia:3059 Review URL: https://codereview.chromium.org/715093003
* Add isUnblended query to GrDrawState.Gravatar egdaniel2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/715873002
* Add GrGpuResource::CacheAccessGravatar bsalomon2014-11-11
| | | | | | | | Internal only helper class for manipulating and accessing cache keys. BUG=skia:2889 Review URL: https://codereview.chromium.org/703303003
* Revert of Move from libstlport to libc++ for Android framework builds ↵Gravatar scroggo2014-11-11
| | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/714113002/) Reason for revert: The code this depends on is not ready yet. We can submit once https://android-review.googlesource.com/#/c/113924/ is submitted. Original issue's description: > Move from libstlport to libc++ for Android framework builds > > Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72 TBR=tomhudson@google.com,djsollen@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/718793003
* Remove coverage from grpaintGravatar joshualitt2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/683133006
* notice null colorfilter in legacy unflatteningGravatar reed2014-11-11
| | | | | | BUG=skia:3117 Review URL: https://codereview.chromium.org/691383003
* modify nothingToDraw to notice filtersGravatar reed2014-11-11
| | | | | | | | This reverts commit c71ffd4e76d1abcd28ac74463349970f60a3350f. TBR= Review URL: https://codereview.chromium.org/683003003
* Fix "Add support for rebaselining from trybots."Gravatar bungeman2014-11-11
| | | | Commit d09ade4b44edc11 was missing a needed edit.
* Revert of modify nothingToDraw to notice filters (patchset #1 id:1 of ↵Gravatar mtklein2014-11-11
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/717753002/) Reason for revert: modecolorfilters, perhaps more changed Original issue's description: > modify nothingToDraw to notice filters > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c TBR=djsollen@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/717813002
* modify nothingToDraw to notice filtersGravatar reed2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/717753002
* Add benchmark to compare different BBH query patterns.Gravatar mtklein2014-11-11
| | | | | | | | | | | | | | | | | On my laptop: maxrss loops min median mean max stddev samples config bench 37M 1 14ms 14.2ms 14.6ms 18.2ms 9% ▁█▁▁▁▁▂▂▂▁ gpu tiled_playback_tilegrid_tiled 40M 1 17ms 17.2ms 17.2ms 17.6ms 1% ▆▃▁█▄▇▂▁▁▁ gpu tiled_playback_tilegrid_random 40M 1 14.6ms 14.9ms 15.8ms 19.1ms 11% ▂▁▁▁▁▁▁█▅█ gpu tiled_playback_rtree_tiled 43M 1 16.5ms 16.7ms 16.8ms 17.4ms 1% ▂▃▅█▃▂▁▃▃▂ gpu tiled_playback_rtree_random 43M 1 15.9ms 16.1ms 16.5ms 18.7ms 6% ▁▁█▇▁▁▁▂▁▁ gpu tiled_playback_none_tiled 44M 1 17.9ms 17.9ms 18ms 18.1ms 1% ▂▁▅▁▇▃▁▂█▇ gpu tiled_playback_none_random TileGrid and RTree perform pretty much the same, both beating no BBH. BUG=skia:3085 Review URL: https://codereview.chromium.org/699313006
* Fix Android framework build.Gravatar scroggo2014-11-11
| | | | | | | Need to include (transitively) SkUserConfig before checking SK_SUPPORT_GPU. Review URL: https://codereview.chromium.org/693613005
* Remove multipicturedraw GMs from ignored-tests.txtGravatar robertphillips2014-11-11
| | | | | | TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/718763002
* more gms to ignoreGravatar joshualitt2014-11-11
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/691143006
* remove separate color from coverageGravatar joshualitt2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/699023003
* Remove bogus assertGravatar bsalomon2014-11-11
| | | | | | | | | content key can be set after pending io scheduled (e.g. when scaling up a npot texture to pot). BUG=skia:2889 TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/693843004
* Rebaseline problem (Galaxy S4) multipicturedraw GMsGravatar robertphillips2014-11-11
| | | | | | | | | | | | This CL rebaselines the buggy multipicturedraw GMs related to: Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/) TBR=jcgregorio@google.com BUG=skia:3116 Review URL: https://codereview.chromium.org/715823002
* Add support for rebaselining from trybots.Gravatar bungeman2014-11-11
| | | | | | | This adds support to rebaseline_server to fetch actual results from tryjobs run on rietveld issues. Review URL: https://codereview.chromium.org/688353003
* Rebaseline multipicturedraw GMsGravatar robertphillips2014-11-11
| | | | | | | | | | This CL rebaselines the multipicturedraw GMs as a follow up to: Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/) TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/714153002
* update doxGravatar reed2014-11-11
| | | | | | | BUG=skia: TBR=djsollen@google.com Review URL: https://codereview.chromium.org/697363004
* rebase from early clipGravatar joshualitt2014-11-11
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/707413003
* Remove cached OptDrawState from GrDrawState.Gravatar egdaniel2014-11-11
| | | | | | | | | Since we now snap and create the ODS one time in the inorder draw buffer, there is no need for us to keep a cached version of it around. BUG=skia: Review URL: https://codereview.chromium.org/701123003
* guard call to CGColorSpaceCopyICCProfile in case we're building for iOSGravatar reed2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/712363003
* Remove all knowledge of resource keys from the legacy cache.Gravatar bsalomon2014-11-11
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/705413002
* Reenable deprecation warnings on Android framework.Gravatar scroggo2014-11-11
| | | | | | | | | | | | | Most recently introduced here: https://codereview.chromium.org/304333002 It appears these are not currently needed (I just disabled it and successfully built). Since we appear to be out of the transitional period, I propose we remove them so we can know if we deprecate something Android uses (and fix the call site). Review URL: https://codereview.chromium.org/696063006
* Move from libstlport to libc++ for Android framework buildsGravatar djsollen2014-11-11
| | | | Review URL: https://codereview.chromium.org/714113002
* Avoid warning in nanobench related to loop count with nvprmsaa4Gravatar kkinnunen2014-11-11
| | | | | | | | | | | | | | | | | | | | | | The tests path_hairline_{small,big}_AA_conic were calling the test function with NVPR. This caused a warning in nanobench. The here removed hunk comes from commit referring to skia:2042 ("Enable NVPR by default"). This is a workaround for a bug. The bug is fixed by the commit referring to skia:2078 ("Logan bot fails NVPR assertion in bench"). The proper fix is indeed make sure that path renderer chain ends up trying software path renderer, if the path contains conics and is a hairline. The removed hunk refers also to skia:2033 ("Figure out what is happening with conic path segments in NVPR"). The above solution is correct also in case NVPR would support conics, as NVPR would not still support hairlines. BUG=skia:2078 Review URL: https://codereview.chromium.org/685213005
* start again on Sk4x with portable version and unit testsGravatar mtklein2014-11-11
| | | | | | | | | work on tests CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot BUG=skia: Review URL: https://codereview.chromium.org/704923003
* initial checkin for experimentingGravatar reed2014-11-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/696063005
* Change where layer hoisting data is gatheredGravatar robertphillips2014-11-11
| | | | | | | | | | | | This CL: 1) removes the EXPERIMENTAL_optimize on SkCanvas & SkDevice 2) moves the saveLayer gathering step to endRecording 3) Replaces GPUOptimize with SkRecordComputeLayers 4) Update bench_pictures & render_pictures to provide the new flag #2 also necessitated moving the BBH computation (and record optimization) out of SkPicture's ctor (and into endRecording) Review URL: https://codereview.chromium.org/718443002
* Update SKP versionGravatar skia.buildbots2014-11-10
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/711253003
* Snap optdrawstate in inorder draw buffer and pass into gpuGravatar joshualitt2014-11-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/709133003
* tests/Time.cpp: more verbose errorsGravatar halcanary2014-11-10
| | | | Review URL: https://codereview.chromium.org/711143002
* Simplify canvas calls in SkDocument_PDFGravatar halcanary2014-11-10
| | | | | | | | As suggested by reed@ in http://crrev.com/711133002 TBR=reed@google.com Review URL: https://codereview.chromium.org/707533003
* Remove outdated comment in SkImageDecoder.hGravatar scroggo2014-11-10
| | | | | | | The comment was no longer relevant with https://codereview.chromium.org/483593002 Review URL: https://codereview.chromium.org/715673002
* SkDocument_PDF does somthing with the trimBox parameter.Gravatar halcanary2014-11-10
| | | | | | | | | Fixes change introduced in http://crrev.com/645563002 This will allow SkDocument to be a drop-in repalcement to SkPDFDocument/SkPDFDevice in Chromium. Review URL: https://codereview.chromium.org/711133002
* Remove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER.Gravatar bungeman2014-11-10
| | | | | | | | | This removes the old guarded code and enables the new api introduced with "Update fontMgr to take list of bcp47 language tags." c20386e3937d3d398ac9b35f9c7d997e972ade98 . Blink on Android is already using the new code. Review URL: https://codereview.chromium.org/705843004
* Add tests (and fix!) for known bad ICO files.Gravatar scroggo2014-11-10
| | | | | | | | | | | | We previously saw crashes decoding bad ICO files. Add tests for known bad files. While testing, I learned that one of them still crashes. Check for large offset and size separately to fix the crash. BUG=skia:2878 Review URL: https://codereview.chromium.org/712123002
* Re-enable no-longer-flaky GMsGravatar jvanverth2014-11-10
| | | | | | TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/684413004
* Move GrResourceKey static functions from .h to .cpp to fix shared lib buildsGravatar bsalomon2014-11-10
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/718493002
* Use GrResourceCache2 to service content key lookupsGravatar bsalomon2014-11-10
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/707493002
* Fix SkTime::GetDateTime Posix implementation, add unit test.Gravatar halcanary2014-11-10
| | | | | | The year was off by 1900 Review URL: https://codereview.chromium.org/714633002
* flag imageinfo as srgbGravatar reed2014-11-10
| | | | | | | | | | | | intended uses: - flag a SkSurface as sRGB (only supported by Ganesh for now) - flag images (e.g. png or jpeg) as sRGB if the codec tells us that wins: - faster gamma-correct text (esp. w/ distance-fields) when we can use sRGB for text - better color fidelity when the screen really is sRGB Review URL: https://codereview.chromium.org/676883003
* Small refactoring of layer discovery codeGravatar robertphillips2014-11-10
| | | | | | This CL removes CollectLayers' reliance on having the top most picture (by removing the unused fPictureID member). This then allows making CollectLayers' API closer to that of SkRecordFillBounds in order to facilitate using them interchangeably. Review URL: https://codereview.chromium.org/714533002
* Update some flaky GMs to see if they stick.Gravatar jvanverth2014-11-10
| | | | | | TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/713893002