aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* run clean branch baseline only onceGravatar mtklein2015-01-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/874643002
* Spin off GM::runAsBench() from flags.Gravatar mtklein2015-01-23
| | | | | | | | This will let us kill flags. BUG=skia: Review URL: https://codereview.chromium.org/873753002
* Fix SampleApp picture-mode transform.Gravatar fmalita2015-01-23
| | | | | | | | The multi-picture-draw path should not ignore the inherited transform. R=reed@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/867303002
* Take budgeted param when snapping new image.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/872543002
* Fix 'Revert' instructions.Gravatar tfarina2015-01-23
| | | | | | | | | | In the not so new pure Git world, 'svn fetch' and 'svn rebase' are not needed anymore. BUG=None R=borenet@google.com Review URL: https://codereview.chromium.org/872433004
* Collect everything Skia into one document.Gravatar halcanary2015-01-23
| | | | | | http://skiadocs.com:8000/dev/contrib/directory?cl=866133002 Review URL: https://codereview.chromium.org/866133002
* check for too-large rowBytesGravatar reed2015-01-23
| | | | | | BUG=446164 Review URL: https://codereview.chromium.org/871993003
* In Correctness Testing Doc, render --option correctlyGravatar halcanary2015-01-23
| | | | | | | TBR=mtklein@google.com NOTRY=true Review URL: https://codereview.chromium.org/871993004
* minor changes left out of http://crrev.com/873543002Gravatar halcanary2015-01-23
| | | | | | TBR=mtklein@google.com Review URL: https://codereview.chromium.org/872643005
* Allow unbudgeted resources to be recycled by the cache as scratch.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/870743002
* Fix self assigment in GrResourceKeyGravatar bsalomon2015-01-23
| | | | | | | | TBR=robertphillips@google.com BUG=skia:3340 Review URL: https://codereview.chromium.org/866263007
* Add a basic doc for correctness testing (DM).Gravatar mtklein2015-01-23
| | | | | | | | https://skia.org/dev/contrib/testing?cl=868983002 BUG=skia: Review URL: https://codereview.chromium.org/868983002
* Update compiler warning flagsGravatar mtklein2015-01-23
| | | | | | | | | | | | - add -Wsign-compare, which has been catching useful issues for Kimmo; - add -Winit-self and -Wpointer-arith to Mac builds so everyone's using the same flags; - try try removing -Wno-uninitialized. This was only for the old 10.6 compiler that we have warnings set as non-errors now. BUG=skia: Review URL: https://codereview.chromium.org/872793002
* Remove GrBinHashKeyGravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/861323002
* Compile fix after Add specialized content key class for resourcesGravatar kkinnunen2015-01-23
| | | | | | | gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4 error: comparison between signed and unsigned integer expressions Review URL: https://codereview.chromium.org/871013002
* More changes to SkPDFShader to eliminate multiple inheritance!Gravatar halcanary2015-01-23
| | | | Review URL: https://codereview.chromium.org/873543002
* add newImage APIGravatar reed2015-01-23
| | | | | | | BUG=skia:3277 related bug: skbug.com/3276 Review URL: https://codereview.chromium.org/821083002
* Write dm.json periodically instead of only once at the end.Gravatar mtklein2015-01-23
| | | | | | | | | This way if a bot crashes, we might get some partial results in gold rather than none. We do the same sort of thing in nanobench for perf. BUG=skia:3255 Review URL: https://codereview.chromium.org/872443003
* minor readability / refactorsGravatar mtklein2015-01-23
| | | | | | | | | | | | I have been hacking at this test trying to understand why the N5 is still sometimes crashy (it seems, less but not zero now). No luck so far. But, while I've been reading and hacking at it, I think I've made a few small improvements, mostly to readability. BUG=skia: Review URL: https://codereview.chromium.org/870803002
* more reinforcement that images never have zero width or heightGravatar reed2015-01-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/869743002
* Add specialized content key class for resources.Gravatar bsalomon2015-01-23
| | | | Review URL: https://codereview.chromium.org/858123002
* Update SKP versionGravatar skia.buildbots2015-01-23
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/866383002
* Simplify SkPDFShader class. Now invalid objects are never created.Gravatar halcanary2015-01-23
| | | | | | | | "Constructors should not do real work" I have verified that all test PDFs render identically. Review URL: https://codereview.chromium.org/862113004
* Move FP texture test buffers to heap.Gravatar mtklein2015-01-22
| | | | | | | | | | | | | | | | | | | | | | | This is a speculative fix for the crashing N5 bots. It looks like the bots are always failing in or around FloatingPointTextureTest. It looks like sometimes they're hitting a SIGBUS, which I suspect is stack overflow. FloatingPointTextureTest allocates ~320K on the stack, which may be too much. This CL moves those buffers to the heap. For consistency I did the same with the half-float tests, though they're only using ~1/8th the stack. It looks like sometimes the bots are failing to malloc. I don't understand that, and this CL doesn't address that directly. But it's possible this is still a stack overflow, just trashing RAM and causing arbitrary mayhem instead of a SIGBUS. I have no idea why this is a problem only on the N5. I have been unable to reproduce this locally, neither with a K N5 nor an L N5, but the bots are pretty reliable. NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/871623002
* remove unnecessary guard flags for android (for conics)Gravatar reed2015-01-22
| | | | | | | BUG=skia: NOTREECHECKS=True Review URL: https://codereview.chromium.org/868783002
* android_run_skia: dump logcat on failureGravatar mtklein2015-01-22
| | | | | | | | | logcat -c clears the log before we run. logcat -d dumps the log stdout and exits. BUG=skia: Review URL: https://codereview.chromium.org/870643002
* Initialize the pad memory in GrBufferAllocPool.Gravatar dongseong.hwang2015-01-22
| | | | | | | | Msan bot detects Use-of-uninitialized-value on the pad. BUG=445745 Review URL: https://codereview.chromium.org/865913002
* Put close_gif() in an anonymous namespace.Gravatar mtklein2015-01-22
| | | | | | | | | Not a big deal, but matches the intention of it being a file-scoped function better. This mirrors a recent google3 change for clients who don't use C++11. BUG=skia: Review URL: https://codereview.chromium.org/865243002
* Muck with the right cinfo.Gravatar scroggo2015-01-22
| | | | | | | | | | | In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and creating a new one in its place. Should fix build breakage. Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0 Review URL: https://codereview.chromium.org/858333002
* Rename GrOptDrawState to GrPipeline and GrDrawState to GrPipelineBuilderGravatar egdaniel2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/858343002
* remove more dead codeGravatar reed2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/865873003
* remove (unused) GatherPixelRefsGravatar reed2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/869463002
* fLuminance is unsed unless SK_GAMMA_APPLY_TO_A8 is definedGravatar mtklein2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/865103002
* Fix SkIStream nits.Gravatar bungeman2015-01-22
| | | | | | | | | Fix comment, constness of one field, and delete already checks for NULL. TBR=reed@google.com Trivial change to debatably public api. Review URL: https://codereview.chromium.org/868643003
* XPFactory lazily initializie in drawstate / GrPaintGravatar joshualitt2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/866573002
* Remove the need for asCoeff in SkXfermode.Gravatar egdaniel2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/864833002
* Remove staging SkStream::unref().Gravatar bungeman2015-01-22
| | | | | | | | | SkStream::unref() was added to ease transitioning off of SkStream deriving from SkRefCnt. It is no longer needed, remove it. TBR=reed@google.com Review URL: https://codereview.chromium.org/861413002
* Update SKP versionGravatar skia.buildbots2015-01-21
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/807263005
* Don't require -DSK_USE_POSIX_THREADS.Gravatar mtklein2015-01-21
| | | | | | | | | | | | | To compile SkCondVar, we already require either pthreads or Windows. This simplifies that code to not need SK_USE_POSIX_THREADS to be explicitly defined. We'll just look to see if we're targeting Windows, and if not, assume pthreads. Both before and after this CL, that code will fail to compile if we're not on Windows and don't have pthreads. BUG=skia: Review URL: https://codereview.chromium.org/869443003
* More natural way to serialize GPU tasks and tests.Gravatar mtklein2015-01-21
| | | | | | | | | | | | | This basically takes out the Windows-only hacks and promotes them to cross-platform behavior driven by --gpu_threading. - When --gpu_threading is false (the default), this puts GPU tasks and tests together in the same GPU enclave. They all run serially. - When --gpu_threading is true, both the tests and the tasks run totally independently, just like the thread-safe CPU-bound work. BUG=skia:3255 Review URL: https://codereview.chromium.org/847273005
* Revert of Muck with the right cinfo. (patchset #2 id:20001 of ↵Gravatar bungeman2015-01-21
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/858333002/) Reason for revert: Appears to cause Android dm to segfault. Original issue's description: > Muck with the right cinfo. > > In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and > creating a new one in its place. > > Should fix build breakage. > > Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0 TBR=scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/858323003
* Muck with the right cinfo.Gravatar scroggo2015-01-21
| | | | | | | | | In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and creating a new one in its place. Should fix build breakage. Review URL: https://codereview.chromium.org/858333002
* Easy DM TODO: LazyDecodeBitmap does not help (or hinder).Gravatar mtklein2015-01-21
| | | | | | BUG=skia:3255 Review URL: https://codereview.chromium.org/859303003
* Don't test pipe modes nobody uses.Gravatar mtklein2015-01-21
| | | | | | | | | | | | | SkDeferredCanvas uses a simple pipe: no cross-process, no shared-address, etc. (see src/utils/SkDeferredCanvas.cpp:306). We could just remove these modes from the bot configs, but I'd like to take the opportunity to simplify the DM code too. I'll happily volunteer to put things back should we decide we want to test these modes. BUG=skia: Review URL: https://codereview.chromium.org/861303003
* Move sync code to include/, switch from using platform define to a proxy ↵Gravatar mtklein2015-01-21
| | | | | | | | | | | | | | header in core/ This fixes two problems: 1) #include SK_SOME_DEFINE doesn't work well for all our clients. 2) Things in include/ are #including things in src/, which we don't like. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/862983002
* Use SkLazyPtr in SkPDFGraphicState.cppGravatar halcanary2015-01-21
| | | | | | | Motivation: currently we rely on mutexes for guarding static initialization. These mutexes will go away. Review URL: https://codereview.chromium.org/815223005
* And change SkAutoTUnref<const SkStream to SkAutoTDelete.Gravatar scroggo2015-01-21
| | | | | | | | | | Should have been included with https://codereview.chromium.org/860353005/ TBR=bungeman@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/844193007
* Remove another caller of SkRef(SkStream)Gravatar scroggo2015-01-21
| | | | | | | | TBR=bungeman@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/860353005
* Update the version of cpu-features that we use for testing.Gravatar djsollen2015-01-21
| | | | Review URL: https://codereview.chromium.org/858233003
* Make SkStream *not* ref counted.Gravatar scroggo2015-01-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkStream is a stateful object, so it does not make sense for it to have multiple owners. Make SkStream inherit directly from SkNoncopyable. Update methods which previously called SkStream::ref() (e.g. SkImageDecoder::buildTileIndex() and SkFrontBufferedStream::Create(), which required the existing owners to call SkStream::unref()) to take ownership of their SkStream parameters and delete when done (including on failure). Switch all SkAutoTUnref<SkStream>s to SkAutoTDelete<SkStream>s. In some cases this means heap allocating streams that were previously stack allocated. Respect ownership rules of SkTypeface::CreateFromStream() and SkImageDecoder::buildTileIndex(). Update the comments for exceptional methods which do not affect the ownership of their SkStream parameters (e.g. SkPicture::CreateFromStream() and SkTypeface::Deserialize()) to be explicit about ownership. Remove test_stream_life, which tested that buildTileIndex() behaved correctly when SkStream was a ref counted object. The test does not make sense now that it is not. In SkPDFStream, remove the SkMemoryStream member. Instead of using it, create a new SkMemoryStream to pass to fDataStream (which is now an SkAutoTDelete). Make other pdf rasterizers behave like SkPDFDocumentToBitmap. SkPDFDocumentToBitmap delete the SkStream, so do the same in the following pdf rasterizers: SkPopplerRasterizePDF SkNativeRasterizePDF SkNoRasterizePDF Requires a change to Android, which currently treats SkStreams as ref counted objects. Review URL: https://codereview.chromium.org/849103004
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 19:44:29 +0000