aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert "Revert of factories should return baseclass, allowing the impl to ↵Gravatar reed2015-10-06
| | | | | | | | | | | specialize (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ )" This reverts commit 95376a0dde3cdf414eb97a20cef3af19ed7e0151. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1389083002
* Revert of factories should return baseclass, allowing the impl to specialize ↵Gravatar schenney2015-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ ) Reason for revert: Breaks Chrome with this link error: ../../third_party/skia/include/effects/SkMorphologyImageFilter.h:75: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)' ../../third_party/skia/include/effects/SkMorphologyImageFilter.h:104: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)' Presumably due to code in third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp that contains: #include "SkMorphologyImageFilter.h" ... if (m_type == FEMORPHOLOGY_OPERATOR_DILATE) return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), &rect)); return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), &rect)); Original issue's description: > factories should return baseclass, allowing the impl to specialize > > waiting on https://codereview.chromium.org/1386163002/# to land > > BUG=skia:4424 > > Committed: https://skia.googlesource.com/skia/+/80a6dcaa1b757826ed7414f64b035d512d9ccbf8 TBR=senorblanco@google.com,robertphillips@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4424 Review URL: https://codereview.chromium.org/1389063002
* Blacklisting imagefilterscropexpand on s4 since it often causes the bot to ↵Gravatar egdaniel2015-10-06
| | | | | | | | hang and crash. BUG=skia:4079 Review URL: https://codereview.chromium.org/1373763005
* factories should return baseclass, allowing the impl to specializeGravatar reed2015-10-06
| | | | | | | | waiting on https://codereview.chromium.org/1386163002/# to land BUG=skia:4424 Review URL: https://codereview.chromium.org/1390523005
* Allow SkIcoCodec to fail due to conversionGravatar scroggo2015-10-06
| | | | | | | | | | | | | | Even if the client chooses dimensions that were suggested by SkIcoCodec, it is possible for the color conversion to be incorrect, so it can still reach the exit case of kInvalidConversion. For example, when running nanobench, we attempt to decode the image to Alpha_8, which the codec does not support. This allows running nanobench in debug mode without asserting. BUG=skia:3418 Review URL: https://codereview.chromium.org/1389943002
* SkPDF: when drawing stroked path, draw using SVG rules for zero-length segmentsGravatar halcanary2015-10-06
| | | | | | | | | | | | | | | | | | The "zeroPath" and emptystroke GMs capture this issue. This CL changes the following PDF GMs: emptystroke dashing4 lineclosepath dashing3 zeroPath linepath complexclip3_complex complexclip3_simple roundrects degeneratesegments filltypes strokerect pathfill inverse_paths desk_chalkboard.skp After this change, all PDF GMs look better (closer to 8888). The dashing4, emptystroke, and zeroPath GMs still need a lot of work to make them look right. BUG=538726 Review URL: https://codereview.chromium.org/1374383004
* Bye bye processor data manager.Gravatar bsalomon2015-10-06
| | | | Review URL: https://codereview.chromium.org/1388113002
* Fix for visualbench loops foreverGravatar joshualitt2015-10-06
| | | | | | | TBR=robertphillips@google.com BUG=skia: Review URL: https://codereview.chromium.org/1387823004
* nvpr removal from VisualBench base contextGravatar joshualitt2015-10-06
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1391633002
* Fix SkGifCodec to handle gifs where frameSize != imageSizeGravatar msarett2015-10-06
| | | | | | | | | | | | | | | | | These are quite rare, causing us to miss a few bugs in how we deal with these images. Additionally, there is a behavior change. If the imageSize is not large enough to contain the frame, we will "fix" the image by increasing the image size. SkScaledCodec is still buggy with regard to these gifs. See skbug.com/4421. We will fix that after 1332053002 lands. BUG=skia: Review URL: https://codereview.chromium.org/1386973002
* Remove duplicate .cpp which should have been a .hGravatar herb2015-10-06
| | | | Review URL: https://codereview.chromium.org/1389923002
* Dynamically allocate the GrDrawContextsGravatar robertphillips2015-10-06
| | | | | | This CL moves the allocation and storage of the GrTextContexts into the DrawingManager. The GrDrawContexts now just get their GrTextContext from the DrawingManager. Review URL: https://codereview.chromium.org/1375153007
* [SkDebugger] Handle path empty-bounds gracefullyGravatar fmalita2015-10-06
| | | | | | | | | Paths with empty bounds crash the debugger: mapping their bounds onto the shapshot area gets the canvas into an unhappy state. R=robertphillips@google.com Review URL: https://codereview.chromium.org/1387173003
* Revert of Stop using SkScalerContext::getAdvance() in SkGlyphCache. ↵Gravatar mtklein2015-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/1321243004/ ) Reason for revert: Suspect this is the cause of regressions in crbug.com/527445. It's triggering on Windows and Linux, where getting advances does less than getting full metrics. It's not triggering on Mac, where this CL was a no-op. Original issue's description: > Stop using SkScalerContext::getAdvance() in SkGlyphCache. > > We think it'll simplify things to just always get the full metrics. > On most platforms, it's no different, and we think the platforms that > do differ (FreeType) will be nearly just as cheap. > > Removing this distinction helps us make SkGlyphCaches concurrent by > removing a state (we-have-only-advances) from its logical state machine. > > We see no significant changes running SKPs before and after this CL. > That makes sense, of course, because the SKPs bake some of this into drawPosText. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/518a2923f11b819fa44ed5cff54155326959540f TBR=reed@google.com,bungeman@google.com,herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1383403003
* Make path range loading explicitGravatar cdalton2015-10-05
| | | | | | | | | | Requires the caller to explicitly preload paths within a range before calling drawPaths. This allows us to remove the implicit lazy load, thereby eliminating a redundant check on every redraw of a text blob. BUG=skia: Review URL: https://codereview.chromium.org/1382013002
* Implement cached nvpr text blobsGravatar cdalton2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1381073002
* Use SkTextBlob for nvpr color bitmap fallbacksGravatar cdalton2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1381873003
* Add TextRun object to nvpr textGravatar cdalton2015-10-05
| | | | | | | | | Adds a TextRun object that defines a resolution-independent, paint- indepent draw for a string of nvpr text. BUG=skia: Review URL: https://codereview.chromium.org/1375353004
* SkScaledCodec should implement onRewind()Gravatar msarett2015-10-05
| | | | | | | | This is a bug fix. I'm also adding a test. BUG=skia: Review URL: https://codereview.chromium.org/1385703002
* Cleanup timing state machineGravatar joshualitt2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1386933002
* Add more .h files to the .gypiGravatar herb2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1386963002
* move visual bench interactive module to timing state machineGravatar joshualitt2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1382883003
* Validate text blob runs after SkTextBlob construction.Gravatar fmalita2015-10-05
| | | | | | | | | This avoids tripping CFI when casting uninitialized SkTextBlob ptrs. BUG=chromium:538754 R=bungeman@google.com,reed@google.com,krasin@google.com Review URL: https://codereview.chromium.org/1388543005
* Add ship sampleGravatar jvanverth2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1359033005
* Specify bench_type & source_type for image benchesGravatar scroggo2015-10-05
| | | | | | | | | This will allow us to use perf filtering for comparing SkImageDecoder to SkCodec. BUG=skia:3418 Review URL: https://codereview.chromium.org/1387863002
* Pass --images '' to nanobench to disable image benchmarking.Gravatar mtklein2015-10-05
| | | | | | | | | | | Enabling image benchmarking has caused most nanobench runs to fail, both Debug and Release. BUG=skia:3418 NOTREECHECKS=true TBR=scroggo@google.com Review URL: https://codereview.chromium.org/1381703003
* Fix gpu dashing for case where all intervals are 0.Gravatar egdaniel2015-10-05
| | | | | | BUG=skia:4409 Review URL: https://codereview.chromium.org/1381803005
* Force cache SkTestScalerContext path bounds.Gravatar mtklein2015-10-05
| | | | | | | | | | Looks like a race on this: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/2608/steps/dm/logs/stdio BUG=skia: Review URL: https://codereview.chromium.org/1373363007
* Factor out VisualBench timing code into a helper classGravatar joshualitt2015-10-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1375363003
* Revert of Have GrRectBlurEffect use Linear filtering (rather than Nearest ↵Gravatar robertphillips2015-10-04
| | | | | | | | | | | | | | | | | | | | | Neighbor) (patchset #2 id:20001 of https://codereview.chromium.org/1378023004/ ) Reason for revert: Trial run confirmed layout test expectations - will reland after suppressions Original issue's description: > Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor) > > Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db > > Committed: https://skia.googlesource.com/skia/+/5175b9563055926b4969d57f06e4ae49b86e055b TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1378813004
* SkImage doesn't use props, so don't need to store itGravatar reed2015-10-04
| | | | | | | BUG=skia: TBR=bsalomon Review URL: https://codereview.chromium.org/1372153006
* Fix memory leak in ClipMaskManagerGravatar robertphillips2015-10-04
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1385823002
* Have GrRectBlurEffect use Linear filtering (rather than Nearest Neighbor)Gravatar robertphillips2015-10-04
| | | | | | Committed: https://skia.googlesource.com/skia/+/2d70bcccc9ba8f3898a7ae506ba7410ed8e9c9db Review URL: https://codereview.chromium.org/1378023004
* Update SKP versionGravatar update-skps2015-10-04
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1390433002
* Simplify nvpr textGravatar cdalton2015-10-03
| | | | | | | | | | | | | | | | | - Drops device-space glyphs in favor of perf/simplicity. - Removes residual complexities that would flip glyphs vertically for compatibility with nvpr glyph loading, which is no longer used. - Drops hairline support since they required new paths for every draw matrix, and could only be supported under certain circumstances. - Quits checking for color bitmap fonts in canDrawText since the normal color emoji fallback will handle them anyway. BUG=skia: Review URL: https://codereview.chromium.org/1380973002
* Stop calling jpeg_finish_decompress()Gravatar msarett2015-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | jpeg_finish_decompress() does several things: (1) Reads to the end of the image stream. (2) Calls term_src(), a client provided function that indicates we are done with the memory stream. Our current implementation of term_src() does nothing. (3) Calls jpeg_abort() which aborts the decode and cleans up some memory. I don't think we need to call this anymore. (1) seems irrelevant. It seems a little dangerous to get rid of (2), but it is fine while our implementation of term_src() does nothing. (3) We will call jpeg_destroy() on destruction of the JpegDecoderManager. This should free all the memory, making it unnecessary to call jpeg_abort() beforehand. BUG=skia:4040 Review URL: https://codereview.chromium.org/1370323004
* Move all knowledge of X sampling into SkScaledCodecGravatar scroggo2015-10-02
| | | | | | | | | | | | | | | | | | | | | | | Prior to this CL, each SkCodec subclass that allows sampling does an extra check in onStartScanlineDecode to determine whether the X dimension is supported for sampling. Remove this check, and provide a way for SkScaledCodec to directly access the SkSwizzler, and update it to do sampling. This way, the SkCodec knows nothing of sampling, but we can still save the extra step of sampling afterwards. FIXME: SkBmpRLECodec still calls SkScaledCodec::DimensionsSupported. It seems like it could directly support sampling, rather than dealing with SkScaledCodec (partially). Add a new base class for SkSwizzler. It allows updating the swizzler after it was created, which is done by SkScaledCodec. Modify SkSwizzler's constructor/factory function to stop taking any info about sampling, assume the sample size is one, and move modifying that into a virtual function overridden from the base class. BUG=skia:4284 Review URL: https://codereview.chromium.org/1372973002
* SkPDF: remove suppressionGravatar halcanary2015-10-02
| | | | Review URL: https://codereview.chromium.org/1379183005
* Incrementally flush GrDrawTargetGravatar joshualitt2015-10-02
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/a7e878064509ef96b54d5507dab0b50def66dc13 Review URL: https://codereview.chromium.org/1386463004
* Fix CrOS SampleAppGravatar jvanverth2015-10-02
| | | | | | | | | | | Add compile-time check for GPU build when using GPU flag TBR=robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1376423004
* Revert of Incrementally flush GrDrawTarget (patchset #8 id:130001 of ↵Gravatar joshualitt2015-10-02
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1386463004/ ) Reason for revert: breaking bots Original issue's description: > Incrementally flush GrDrawTarget > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/a7e878064509ef96b54d5507dab0b50def66dc13 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1386683002
* Some iOS fixes to make SampleApp work better.Gravatar jvanverth2015-10-02
| | | | | | | | | | Changes: - Rebuild argc and argv so we can process command line arguments - Remove unnecessary SimpleiOSApp files - Add support for reading files from the app bundle - Add gpu flag so we can start up directly into OpenGL Review URL: https://codereview.chromium.org/1382943004
* Incrementally flush GrDrawTargetGravatar joshualitt2015-10-02
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1386463004
* Add work around for devices/API filters that claim GL_KHR_debug support but ↵Gravatar bsalomon2015-10-02
| | | | | | don't provide functions Review URL: https://codereview.chromium.org/1383763004
* Remove separate cache for clip mask texturesGravatar bsalomon2015-10-02
| | | | Review URL: https://codereview.chromium.org/1377943003
* Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for ↵Gravatar joshualitt2015-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1375733003/ ) Reason for revert: Reverting, optimistically fixed Original issue's description: > Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1382933002/ ) > > Reason for revert: > Not fixed. :-( > > Original issue's description: > > Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ ) > > > > Reason for revert: > > should hopefully be fixed, please reland if not. > > > > Original issue's description: > > > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 > > > > > > BUG=skia:4373 > > > > > > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47 > > > > TBR=borenet@google.com,benjaminwagner@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia:4373 > > > > Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072 > > TBR=borenet@google.com,joshualitt@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4373 > > Committed: https://skia.googlesource.com/skia/+/9442ab8a40dd0effde253e3b2d166bcf47222e92 TBR=borenet@google.com,benjaminwagner@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4373 Review URL: https://codereview.chromium.org/1385633002
* S4 only has 8 texture units on the GLContext we createGravatar joshualitt2015-10-02
| | | | | | BUG=skia:4373 Review URL: https://codereview.chromium.org/1386643002
* Skia: Add Command Buffer support to Linux/MacGravatar hendrikw2015-10-01
| | | | | | | Code added to load libcommand_buffer_gles2.so on linux or mac. Review URL: https://codereview.chromium.org/1346423002
* Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for ↵Gravatar benjaminwagner2015-10-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1382933002/ ) Reason for revert: Not fixed. :-( Original issue's description: > Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ ) > > Reason for revert: > should hopefully be fixed, please reland if not. > > Original issue's description: > > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 > > > > BUG=skia:4373 > > > > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47 > > TBR=borenet@google.com,benjaminwagner@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4373 > > Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072 TBR=borenet@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4373 Review URL: https://codereview.chromium.org/1375733003
* Update Android toolchains and streamline process.Gravatar mtklein2015-10-01
| | | | | | | | | | | | | - This updates to r10e / API v21 everywhere. - This has each host machine fetch the NDK, run make-standalone-toolchain.sh, and copy gdbserver itself. (It will do all this once per $ARCH, which is a little inefficient, but it washes out in steady state.) BUG=skia: Review URL: https://codereview.chromium.org/1385463002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 22:46:39 +0000