aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Revert of Revert[2] of add ImageShader, sharing code with its Bitmap cousin ↵Gravatar reed2015-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #11 id:200001 of https://codereview.chromium.org/1352293002/ ) Reason for revert: guess: Need to handle NPOT support in shader case Original issue's description: > Revert[2] of add ImageShader, sharing code with its Bitmap cousin > > Adjustment from previous land : runtime check for npot-support when texture is requested for tiling. > > (patchset #10 id:180001 of https://codereview.chromium.org/1342113002/ ) > > This reverts commit f2608513626264459a00388537175600b515cae2. > > BUG=skia:4365 > > Committed: https://skia.googlesource.com/skia/+/fe05707c356d2a8c2c69222591d4cafbd456b4e5 TBR=fmalita@chromium.org,robertphillips@google.com,bsalomon@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4365 Review URL: https://codereview.chromium.org/1375673002
* Revert of change pixel-serializer to support reencoding existing data ↵Gravatar reed2015-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:80001 of https://codereview.chromium.org/1373683003/ ) Reason for revert: Need to somehow get access to encoders in chrome -- link error on the roll since SkImageEncoder is not built as part of chrome. Original issue's description: > change pixel-serializer to support reencoding existing data > > Trying to evolve this interface so it can > - support rich set of backend-encoders (including ones like ETC1 that can cheaply convert to KXT > - allow for encoding images as well as bitmaps (e.g. for picture serialization) > - perhaps replace SkImageEncoder as an API (assuming we create a factory that returns a serializer given a format) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/13f48dc85aa68a60da66aaf39c93d527d11d1278 TBR=scroggo@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1371983003
* Revert of SkImage-backed SkPictureShader (patchset #4 id:60001 of ↵Gravatar robertphillips2015-09-28
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1343153003/ ) Reason for revert: This CL appears to be breaking the pictureshader, pictureshadertile and tiled_picture_shader GMs on the iPad4 and the N7. The artifact is black rectangles. Original issue's description: > SkImage-backed SkPictureShader > > Instead of using an explicit image generator + SkBitmap + bitmap shader, > switch to the shiny new SkImage/image generator/image shader. > > R=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/97be9a0c86eedd8ab85ae7d9aaccb0b0a8e4577d TBR=reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1374763003
* Add cast and assignment operators to SkAtomic.Gravatar herb2015-09-28
| | | | | | | | | | This is not really an API change. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1369333002
* change pixel-serializer to support reencoding existing dataGravatar reed2015-09-28
| | | | | | | | | | | Trying to evolve this interface so it can - support rich set of backend-encoders (including ones like ETC1 that can cheaply convert to KXT - allow for encoding images as well as bitmaps (e.g. for picture serialization) - perhaps replace SkImageEncoder as an API (assuming we create a factory that returns a serializer given a format) BUG=skia: Review URL: https://codereview.chromium.org/1373683003
* SkBlockMemoryStream: correct test in getMemoryBase().Gravatar halcanary2015-09-28
| | | | | | | | | The test "nullptr == fBlockMemory->fHead->fNext" tests that all of the data is in one block, but it is also necessary to test "fBlockMemory->fHead" to ensure that there is a first block with data in it. Review URL: https://codereview.chromium.org/1374493002
* Make skpaint->grpaint flow work for composing draws (verts and atlas)Gravatar bsalomon2015-09-28
| | | | | | One side effect is that the SkShader's (or implicit shader's) fragment processor is responsible for the transition from an unpremul paint color to a premul color. Review URL: https://codereview.chromium.org/1348583002
* EdgeClip demo to show scan-converter clipping behaviorGravatar reed2015-09-28
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1367373002
* Update SKP versionGravatar update-skps2015-09-27
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1369923002
* SkImage-backed SkPictureShaderGravatar fmalita2015-09-25
| | | | | | | | | Instead of using an explicit image generator + SkBitmap + bitmap shader, switch to the shiny new SkImage/image generator/image shader. R=reed@google.com Review URL: https://codereview.chromium.org/1343153003
* Remove SkBitmapSourceGravatar fmalita2015-09-25
| | | | | | | | | To avoid breaking existing SKPs, add a deserialization stub which unflattens SkBitmapSource records to SkImageSources. R=reed@google.com,mtklein@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/1363913002
* SkInstallDiscardablePixelRef is deprecated, enforce thatGravatar reed2015-09-25
| | | | | | | | | No functionality change, just a renaming. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1372593002
* use override to make the new xcode happierGravatar reed2015-09-25
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1368673004
* Revert[2] of add ImageShader, sharing code with its Bitmap cousinGravatar reed2015-09-25
| | | | | | | | | | | | Adjustment from previous land : runtime check for npot-support when texture is requested for tiling. (patchset #10 id:180001 of https://codereview.chromium.org/1342113002/ ) This reverts commit f2608513626264459a00388537175600b515cae2. BUG=skia:4365 Review URL: https://codereview.chromium.org/1352293002
* Eliminate some clutter in SkFlattenableGravatar mdempsky2015-09-24
| | | | | | | | | | | | | | | | | | | | | The Registrar class is unnecessary, as SkFlattenable factory registration is now handled via initialization routines that can just call the Register function directly. Also, no need to lazily initialize gCount to 0, as initializing an int to a constant value does not require dynamic initialization. (C++ actually guarantees zero initialization of global ints anyway, but existing practice in Skia appears to favor the explicit "= 0"). Relatedly, this requires removing the unused/unimplemented SkLayerDrawLooper::MyRegistrar class. And removing that allows Clang to realize that SkLayerDrawLooper::fTopRec is unneeded too, so remove that too to squelch the compiler warning/error. This doesn't change any public API. TBR=reed@google.com Review URL: https://codereview.chromium.org/1361323002
* stop scaling loops and improve warmup benchGravatar joshualitt2015-09-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1363663004
* Fix leak in ResourceCache testGravatar Brian Salomon2015-09-24
| | | | Review URL: https://codereview.chromium.org/1359333004 .
* SkPDF Implement colorfilters on bitmapsGravatar halcanary2015-09-24
| | | | | | BUG=484583 Review URL: https://codereview.chromium.org/1367993002
* Make drawbitmaprect GM use Ganesh-backed bitmaps and imagesGravatar robertphillips2015-09-24
| | | | | | This is left over from trying to repro Android not serializing Ganesh-backed bitmaps Review URL: https://codereview.chromium.org/1353313002
* Add warmup bench to visual benchGravatar joshualitt2015-09-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1358373003
* Remove SkImage::newImage()Gravatar fmalita2015-09-24
| | | | | | | | All clients converted to newSubset(). R=reed@google.com Review URL: https://codereview.chromium.org/1364263002
* Make mutex semaphore based.Gravatar herb2015-09-24
| | | | | | | | | | | | This implementation improves performance of SkMutex acquire / release pair from 42ns -> 13 ns. SkSharedMutex and SkSpinlock have the same performance. It also removes specialized windows and linux/mac code. BUG=skia: Review URL: https://codereview.chromium.org/1359733002
* Make methods on GrGpuResource safe to call on abandoned resourceGravatar bsalomon2015-09-24
| | | | | | BUG=chromium:528908 Review URL: https://codereview.chromium.org/1367533004
* Fix GrDrawVerticesBatch to work with override colors and eliminate local ↵Gravatar bsalomon2015-09-24
| | | | | | coords when posssible. Review URL: https://codereview.chromium.org/1365673003
* Improve debugger's visualization of transparent texturesGravatar robertphillips2015-09-24
| | | | Review URL: https://codereview.chromium.org/1362693003
* Blacklist ReadPixels on GalaxyS4 due to skia:4368.Gravatar benjaminwagner2015-09-24
| | | | | | BUG=skia:4368 Review URL: https://codereview.chromium.org/1366723002
* Mangle output var in GrGLFragmentProcessor::emitChildGravatar bsalomon2015-09-24
| | | | | | R=joshualitt@google.com Review URL: https://codereview.chromium.org/1362873002
* Documentation: minor style changes.Gravatar halcanary2015-09-24
| | | | | | | NOTRY=true TBR= Review URL: https://codereview.chromium.org/1361393003
* remove unused (by the outside) SkImage::newSurface, and simplify newImage -> ↵Gravatar reed2015-09-24
| | | | | | | | newSubset BUG=skia: Review URL: https://codereview.chromium.org/1364443002
* Revert "Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of ↵Gravatar reed2015-09-24
| | | | | | | | | | | | | https://codereview.chromium.org/1364743002/ )" removed test for unsupported SkInstallDiscardable... This reverts commit 60c73d51808b9d78f65381b83f628a3f523042fe. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1369443002
* looking for fuzz failureGravatar caryclark2015-09-23
| | | | | | | | | | | | | | | These tests were isolated from their respective minimized test cases. The tests work fine and pass path ops internal validation; hopefully some more intensive x-san or valgrind test will help isolate the bug. Sheriff, please revert if it fails and I don't get to it first. TBR=reed@google.com,halcanary@google.com BUG=535127,535151 Review URL: https://codereview.chromium.org/1359263003
* Avoid last param to CTFontCreateWithGraphicsFont.Gravatar bungeman2015-09-23
| | | | | | | | | | | | | | | The last parameter of CTFontCreateWithGraphicsFont (CTFontDescriptorRef attributes) *must* be nullptr. If non-nullptr then with fonts with variation axes, the copy will fail in CGFontVariationFromDictCallback when it assumes kCGFontVariationAxisName is CFNumberRef which it quite obviously is not. TBR=reed@google.com Blocking dev builds, just removes code. BUG=chromium:535109 Review URL: https://codereview.chromium.org/1362053003
* Documentation: SkDocument::setMetadata()Gravatar halcanary2015-09-23
| | | | | | | | | Land after http://crrev.com/1359943003 NOTRY=true DOCS_PREVIEW= https://skia.org/user/sample/pdf?cl=1360193002 Review URL: https://codereview.chromium.org/1360193002
* GM for http://skbug.com/4374Gravatar halcanary2015-09-23
| | | | | | BUG=skia:4374 Review URL: https://codereview.chromium.org/1367623002
* SkPDF: add basic metadata supportGravatar halcanary2015-09-23
| | | | | | | | | Motivation: I want too finalize this API before working on the more complex problem of adding XMP metadata for PDF/A. BUG=skia:3110 Review URL: https://codereview.chromium.org/1359943003
* android/apps: Add CanvasProof App;Gravatar halcanary2015-09-23
| | | | | | | | | | | | Compare Ganesh and HWUI canvas rendering of SKPs on android. Put SKP files in .../canvasproof/src/main/assets/skps Run on a Marshmallow device. NOTREECHECKS=true Review URL: https://codereview.chromium.org/1258123004
* Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to ↵Gravatar benjaminwagner2015-09-23
| | | | | | | | skia:4373 BUG=skia:4373 Review URL: https://codereview.chromium.org/1365683003
* Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of ↵Gravatar benjaminwagner2015-09-23
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1364743002/ ) Reason for revert: Build failure: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs/builds/1146 Original issue's description: > remove unused SkCachingPixelRef > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/70d58b7da535e32bcac35739d11ab8367e99f224 TBR=halcanary@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1359393004
* Blacklist GLInstancedArraysBench for GalaxyS4 due to skia:4371Gravatar benjaminwagner2015-09-23
| | | | | | BUG=skia:4371 Review URL: https://codereview.chromium.org/1363963002
* remove unused SkCachingPixelRefGravatar reed2015-09-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1364743002
* skia: Add support for ANGLE on linuxGravatar hendrikw2015-09-23
| | | | | | | This will allow the ANGLE guys to test the ANGLE gl backend with nanobench and DM Review URL: https://codereview.chromium.org/1343193005
* Move determiniation of strokerect rects internalGravatar joshualitt2015-09-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1345853005
* Add nanobench tests for BitmapRegionDecoderGravatar msarett2015-09-22
| | | | | | | | | | | | | | | | SkBitmapRegionDecoderInterface provides an interface for multiple implementations of Android's BitmapRegionDecoder. We already have correctness tests in DM that will enable us to compare the quality of our various BRD implementations. We also need these performance tests to compare the speed of our various implementations. BUG=skia:4357 Review URL: https://codereview.chromium.org/1344993003
* fix DM?Gravatar mtklein2015-09-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1359833005
* This file was supposed to be in https://codereview.chromium.org/1347143006/Gravatar benjaminwagner2015-09-22
| | | | | | BUG=skia:4367 Review URL: https://codereview.chromium.org/1351073003
* Stop supporting HW ditherGravatar bsalomon2015-09-22
| | | | Review URL: https://codereview.chromium.org/1359833004
* move mutex construction out of the benchmarks.Gravatar mtklein2015-09-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1345853004
* Small cleanups to SkSmallAllocatorGravatar mdempsky2015-09-22
| | | | | | | | - Add missing #include <new>. - Simplify createT functions with C++11 variadic templates. - Change destroyT helper function into a private static function. Review URL: https://codereview.chromium.org/1359853002
* Fix for degenerate stroke rectGravatar joshualitt2015-09-22
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/511684fb52f20862f8552f5009390ff3987b08d8 Review URL: https://codereview.chromium.org/1359453002
* Fix possible integer overflow in SkTSearch's midpoint calculationGravatar mdempsky2015-09-22
| | | | | | | | | | | | | Probably unlikely to matter in practice, but SkTQSort calculates its midpoint correctly, so we might as well do it here too. For more background, see Joshua Bloch's "Nearly All Binary Searches and Mergesorts are Broken" post: http://googleresearch.blogspot.ru/2006/06/extra-extra-read-all-about-it-nearly.html This doesn't change any public API. TBR=reed@google.com Review URL: https://codereview.chromium.org/1362613002