aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* remove SK_SUPPORT_LEGACY_DEVICE_CONFIG codeGravatar reed2014-06-11
| | | | | | | | | BUG=skia: R=djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/327263002
* Code reviews -> reviews@skia.org.Gravatar mtklein2014-06-11
| | | | | | | | | BUG=skia: R=reed@google.com, skia-review@googlegroups.com, hcm@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/328613003
* MIPS: added optimization for functions from SkBlitRow.Gravatar djordje.pesut2014-06-11
| | | | | | | | | | | | | | | | | | | gain is ~40% following function are optimized: S32_D565_Blend S32A_D565_Opaque_Dither S32_D565_Opaque_Dither S32_D565_Blend_Dither S32A_D565_Opaque S32A_D565_Blend S32_Blend_BlitRow32 R=djsollen@google.com, teodora.petrovic@gmail.com Author: djordje.pesut@imgtec.com Review URL: https://codereview.chromium.org/326913004
* Move Dashing filterPath to a dashing utils fileGravatar egdaniel2014-06-11
| | | | | | | | | | | | | | | | From inside GrContext, we have a need to create an SkPath an original path and some dashing info. We do not have access to the original path effect so we need a way to make the FilterPath function accessible outside of the effect. So I moved the core filterPath code (and all need helper functions) out of SkDashPathEffect and created a SkDashPath in utils to store these helper functions. BUG=skia: Committed: https://skia.googlesource.com/skia/+/576dcdc793a762ec63fbecdbfd5768066b548fe5 Author: egdaniel@google.com Review URL: https://codereview.chromium.org/314623004
* Support for larger than "signed 32b limit" sized bitmaps in BGRAConvolve2D.Gravatar sugoi2014-06-11
| | | | | | | | | | | The multiplication of 2 signed ints was producing a result larger than what's supported by a single signed int and the memory was accessed out of bounds. Using uint64_t solves the issue. BUG=378491 R=reed@google.com, rmistry@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/323013005
* switch to colortype for deepcopyGravatar reed2014-06-11
| | | | | | | | | BUG=skia: R=robertphillips@google.com, bsalomon@google.com, reed@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/323283002
* Whitespace change to test trybot triggeringGravatar rmistry2014-06-11
| | | | | | | | | | | BUG=skia: TBR= NOTREECHECKS=true (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/325213002
* Update SKP version to 20Gravatar borenet2014-06-11
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/329043002
* Add an LATC compressor to the A8 masks, and hide it behind an ifdef.Gravatar krajcevski2014-06-10
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/326223002
* Fix what I just brokeGravatar kelvinly2014-06-10
| | | | | | | | | | BUG=skia: NOTRY=true TBR=bensong@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/328883003
* Fix broken rebaseline codeGravatar kelvinly2014-06-10
| | | | | | | | | | BUG=skia: NOTRY=true R=bensong@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/327943003
* Split caching from allocation in GrClipMaskManagerGravatar krajcevski2014-06-10
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/324963005
* Try 1 at rebaselineGravatar kelvinly2014-06-10
| | | | | | | | | BUG=skia: R=bensong@google.com, bsalomon@google.com, robertphillips@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/324083007
* fix when DEVICE_CONFIG is still definedGravatar reed2014-06-10
| | | | | | | | | BUG=skia: R=djsollen@google.com, bsalomon@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/329553005
* Add texture compression utilityGravatar krajcevski2014-06-10
| | | | | | | | R=robertphillips@google.com, egdaniel@google.com, halcanary@google.com, scroggo@google.com, reed@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/325733004
* SkShader::asNewEffect RefactoringGravatar dandov2014-06-10
| | | | | | | | | | | | | | | The new signature is: bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor, GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const; It will fix the hack for skcolorshader by modifying the GrColor parameter in SkGr::SkPaint2GrPaintShader. BUG=skia:2646 R=jvanverth@google.com, bsalomon@google.com Author: dandov@google.com Review URL: https://codereview.chromium.org/318923005
* Add Daniel and Pavel to committers listGravatar krajcevski2014-06-10
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/316403003
* Silence TSAN warnings about is_lcd_supported for now.Gravatar mtklein2014-06-10
| | | | | | | | | | | BUG=skia:1792 NOTRY=true R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/328663006
* Fix error revealed by Android unit testGravatar robertphillips2014-06-10
| | | | | | | | | | The issue is/was that the original Picture/PictureRecorder that is being partially replayed is not guaranteed to issue any more commands before attempting to modify the existing data. Such modification is prohibited if there is a extant copy-on-write snapshot. Rather then further complicate the SkWriter32::snapshot capability for a dis-preferred use case, this CL simply copies the operation data. R=scroggo@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316063005
* Clean up SkScaledImageCache at exit only in SK_DEVELOPER mode.Gravatar mtklein2014-06-10
| | | | | | | | | | | | | This is triggering ASAN failures in Chrome unit tests. c.f. https://codereview.chromium.org/308003014 BUG=skia: R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/326913007
* Remove unused 'deepCopy' parameterGravatar robertphillips2014-06-10
| | | | | | | | | | This is split out of https://codereview.chromium.org/316063005/ for clarity. Keeping in mind that SkPicture::FakeEndRecording is now only called from SkPictureRecorder, its deepCopy parameter is no longer necessary. This is b.c., given the new Picture recording semantics (where SkPictures can no longer be actively recording), cloning for thread safety only happens when an SkPicturePlayback has already been allocated (i.e., it happens in the SkPicturePlayback copy constructor. R=scroggo@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324093003
* Remove SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALEGravatar fmalita2014-06-10
| | | | | | | | | | Blink has been rebased. R=humper@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/323093002
* Do a better job of enforcing the semantics of the ↵Gravatar krajcevski2014-06-10
| | | | | | | | | | setRequireUnpremultipliedColors flag R=scroggo@google.com, halcanary@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/322813005
* Remove legacy drawPicture entry pointGravatar robertphillips2014-06-10
| | | | | | | | | | With Skia 5713352a (Chromium should no longer need the legacy SkCanvas::drawPicture interface - https://codereview.chromium.org/317193002/) this code should no longer be needed. R=reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324703002
* Gamma correction for distance field text.Gravatar jvanverth2014-06-10
| | | | | | | | | | | | | | Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4d517fdbb145cb95e5e935470df331e1b6667cfc R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/258883002
* Update SKP version to 19Gravatar borenet2014-06-10
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/322943003
* Cleanup: Get rid of make_isize() function from gm.h.Gravatar tfarina2014-06-09
| | | | | | | | | | | | | | | This helper function is not necessary. The same thing can be achieved by using SkISize::Make() provided by SkTSize API. BUG=skia:2645 TEST=make dm && out/Debug/dm R=robertphillips@google.com, reed@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/326523002
* teach Nacl to not call setConfigGravatar reed2014-06-09
| | | | | | | | | TBR= NOTRY=True Author: reed@chromium.org Review URL: https://codereview.chromium.org/327643003
* hide SkBitmap::setConfigGravatar reed2014-06-09
| | | | | | | | | | patch from issue 325733002 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/322963002
* GM/bench for text draws with various parameters and clip rects.Gravatar bsalomon2014-06-09
| | | | | | | | R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/319053002
* second try at landing improved blur rectGravatar humper2014-06-09
| | | | | | | | | | BUG=skia:2095 R=bsalomon@google.com TBR=bsalomon Author: humper@google.com Review URL: https://codereview.chromium.org/325703002
* Add sampler options to SkScaledBitmapSamplerGravatar krajcevski2014-06-09
| | | | | | | | R=scroggo@google.com, halcanary@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/321873003
* Add assertHeld() to SkMutex.Gravatar mtklein2014-06-09
| | | | | | | | | BUG=skia: R=bungeman@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/313823004
* Revert of Gamma correction for distance field text. ↵Gravatar scroggo2014-06-09
| | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/258883002/) Reason for revert: Memory leaks. I suspect this is due to the lack of destructors in SkAutoGlyphCache Original issue's description: > Gamma correction for distance field text. > > Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4d517fdbb145cb95e5e935470df331e1b6667cfc NOTRY=true NOTREECHECKS=true R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, mtklein@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/323513005
* Reland "Clean up Test's resourcePath code."Gravatar tfarina2014-06-09
| | | | | | | | | | | | | This relands commit 91359bed48bc006a4319da86eb26db3b2e6d4afb (Clean up Test's resourcePath code." BUG=None TEST=make dm && out/Debug/dm R=mtklein@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/321723002
* Gamma correction for distance field text.Gravatar jvanverth2014-06-09
| | | | | | | | | | | Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance. BUG=skia: R=reed@google.com, bungeman@google.com, robertphillips@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/258883002
* Fix Assert for gpu ConicalTwoPointGradient edgecase to be correct bounds.Gravatar egdaniel2014-06-09
| | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/311373003
* Generate path names on the client sideGravatar cdalton2014-06-09
| | | | | | | | | | | | | | Pre-allocates a range of path names and manages allocations within that range on the client side. This allows us to generate new path objects in a feed-forward manner that doesn't require round trips to the GL server. BUG=skia: R=bsalomon@google.com, markkilgard@gmail.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/304403003
* New etcbitmap baselinesGravatar krajcevski2014-06-09
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/325783003
* Make sure to copy the LATC alias when copying the GrGLCapsGravatar krajcevski2014-06-09
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/320273003
* Add LATC to alpha only pixel configGravatar krajcevski2014-06-09
| | | | | | | | R=robertphillips@google.com, bsalomon@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/323853003
* bench_record: No need for --flags if there are no RecordingFlags anymore.Gravatar mtklein2014-06-09
| | | | | | | | | BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/327533002
* Add some comments to GrRectanizer_skylineGravatar robertphillips2014-06-09
| | | | | | | | R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324693002
* Add dump() to SkClipStack to help with debugging.Gravatar bsalomon2014-06-09
| | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/311263015
* Fix Chrome build after 9f1c241e (https://codereview.chromium.org/316143003/)Gravatar robertphillips2014-06-09
| | | | | | | | | | | | Remove SkPicture::kUsePathBoundsForClip_RecordingFlag (https://codereview.chromium.org/316143003/) removed an SkPicture flag on which Chromium still relies. R=scroggo@google.com TBR=scroggo@google.com NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/325723002
* remove GM result-grooming tools that use skia-autogenGravatar epoger2014-06-09
| | | | | | | | | BUG=skia:553 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/320443002
* Remove SkPicture::kUsePathBoundsForClip_RecordingFlagGravatar robertphillips2014-06-09
| | | | | | | | | | The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer? R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316143003
* Chromium should no longer need the legacy SkCanvas::drawPicture interfaceGravatar robertphillips2014-06-08
| | | | | | | | | | | | | | | | With: Switch Blink to using new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/316863003/ Switch Chromium to new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/315963003/ Chromium/Blink should no longer need this flag. Note: this patch cannot be landed until the Blink change rolls into Chromium. R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/317193002
* No longer limit SkPictureRecorder::partialReplay to AndroidGravatar robertphillips2014-06-08
| | | | | | | | | | Toggling this for local testing is a bit of a chore. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316173004
* Revert of Clean up Test's resourcePath code. ↵Gravatar mtklein2014-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/319473003/) Reason for revert: Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that. We can try again after a more careful cleanup of GetResourcePath(). Original issue's description: > Clean up resourcePath code. > > 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test. > 2) Make gResourcePath a static pointer to const char and move it inside the classes. > > BUG=None > TEST=make tests && out/Debug/tests > make gm && out/Debug/gm > make bench && out/Debug/bench > R=mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/52e4f413ffe2d281f9e90ff2147db08083ffcba7 R=tfarina@chromium.org TBR=tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Author: mtklein@google.com Review URL: https://codereview.chromium.org/320733002