aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Auto re-gen for gn cmake generator.Gravatar Ben Wagner2016-10-06
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3028 Change-Id: I73c6ce9e852c280bbb2017c30717809b4cb44046 Reviewed-on: https://skia-review.googlesource.com/3028 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Add distance values to interior of filled RRectsGravatar Robert Phillips2016-10-06
| | | | | | | | | | | This doesn't compute the correct distance vector but it suffices for gaussian edges. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2986 Change-Id: I8bd9e37b0f3788c30d85c95a3c0845d093f22554 Reviewed-on: https://skia-review.googlesource.com/2986 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Harden SkPicturePlayback::handleOp() skipsGravatar fmalita2016-10-06
| | | | | | | | | | | SkValidatingReadBuffer::skip() may return null - tread more carefully around it. BUG=skia:5828 R=reed@google.com,mtklein@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2399043002 Review-Url: https://codereview.chromium.org/2399043002
* Fix Vulkan orientation during screne rotationsGravatar Greg Daniel2016-10-06
| | | | | | | | | | | | | | | | | | | | This will fix the Vulkan orientation when the screen is rotated by having the compositor do the corrections for us. However, it is suggested in the Android Vulkan docs that for power reasons it may be better for the app to get the needed rotation off of the VkAndroidSurface and then manually adjust for this rotation in the rendering without the compositor doing any corrections. This is something we can look into a later date as it would require sending some info back from the VulkanWindowContext back to Skia about what Matrix should be applied. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3052 Change-Id: I4d3d620ffcc77e607fce8d06b869c2912a61400c Reviewed-on: https://skia-review.googlesource.com/3052 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Fix SkDeferredCanvas for use on android.Gravatar Herb Derby2016-10-06
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3030 Change-Id: Ie55023257736a12360a233d01096462ba2eb3e74 Reviewed-on: https://skia-review.googlesource.com/3030 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Reed <reed@google.com>
* remove sprintfGravatar caryclark2016-10-06
| | | | | | | | | | | | | | | | | Most uses of sprintf are in pathops testing. Replace them with SkString::appendf and replace the remaining with snprintf R=scroggo@google.com BUG=skia:2716 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391133005 Review-Url: https://codereview.chromium.org/2391133005
* Make load4 and store4 part of SkNx properly.Gravatar Mike Klein2016-10-06
| | | | | | | | | | | | | | | Every type now nominally has Load4() and Store4() methods. The ones that we use are implemented. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3046 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: I7984f0c2063ef8acbc322bd2e968f8f7eaa0d8fd Reviewed-on: https://skia-review.googlesource.com/3046 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* fuzzer fixGravatar Cary Clark2016-10-06
| | | | | | | | | | | | | | | | | | Error out when fuzzing conditions are met. Also, make degenerate input line ends consistent. TBR=reed@google.com BUG=653452, 626164, skia:5829 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3048 Change-Id: I23a01adde9dec07b54d66ab2418b3ea0b96e4456 Reviewed-on: https://skia-review.googlesource.com/3048 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* fix other printf warning for SkBlendModeGravatar reed2016-10-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393253003 Review-Url: https://codereview.chromium.org/2393253003
* fix mac all buildGravatar caryclark2016-10-06
| | | | | | | R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394943002 Review-Url: https://codereview.chromium.org/2394943002
* Fix SkPath::arcTo when sweepAngle is tiny and radius is bigGravatar xidachen2016-10-06
| | | | | | | | | | | | | | | In this function, it first check whether this arc is a lone point or not. If not, it converts angles to unit vectors. The problem here is that when the radius is huge and the sweepAngle is small, the function angles_to_unit_vectors() could return a startV ==stopV. When that happens, it will draw a dot at the point that corresponding to the startAngle. This CL adds a special branch for this case, and draw a connecting line between the points at startAngle and endAngle. BUG=640031, skia:5807 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388833002 Review-Url: https://codereview.chromium.org/2388833002
* fix printf warning in dumpcanvasGravatar Mike Reed2016-10-06
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3040 Change-Id: I850609e499a670cda0fd09941345fe221fbeeffb Reviewed-on: https://skia-review.googlesource.com/3040 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert[8] "replace SkXfermode obj with SkBlendMode enum in paints"Gravatar reed2016-10-05
| | | | | | | | | | | This reverts commit c245574ba3d0e2ade6c94b2812de3baa383bf4c4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2396953002 TBR= Review-Url: https://codereview.chromium.org/2396953002
* tight bounds optimizationGravatar caryclark2016-10-05
| | | | | | | | | | | | | | | | | Add support for tight bounds to detect and return moveTo followed by close or zero-length lineTo. Also short circuit so that hard work is avoided when the path bounds is also the tight bounds. Avoid doing work if the bounds can be trivially computed. Include naked moveTo coordinates in the tight bounds. R=fmalita@chromium.org BUG=skia:5555, skia:5553 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394443004 Review-Url: https://codereview.chromium.org/2394443004
* Revert[7] "replace SkXfermode obj with SkBlendMode enum in paints"Gravatar Mike Reed2016-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8. Reason for revert: new assert from 100K bot Original change's description: > Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints" > > - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter > This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992 > > Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8 > Reviewed-on: https://skia-review.googlesource.com/2992 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I848e5a69c5cd67f2c14889f4f0a346652578c4ff Reviewed-on: https://skia-review.googlesource.com/3023 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Revert "add cast for printf"Gravatar Mike Reed2016-10-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit Ib9277facab87747b3cf9b71585e63067b4be9a58. Reason for revert: reverted related CL Original change's description: > add cast for printf > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3020 > > Change-Id: Ib9277facab87747b3cf9b71585e63067b4be9a58 > Reviewed-on: https://skia-review.googlesource.com/3020 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I1621d4ea42e9a9403ce78db147c62e8a458b4e00 Reviewed-on: https://skia-review.googlesource.com/3024 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* add cast for printfGravatar Mike Reed2016-10-05
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3020 Change-Id: Ib9277facab87747b3cf9b71585e63067b4be9a58 Reviewed-on: https://skia-review.googlesource.com/3020 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* update deferredGravatar Mike Reed2016-10-05
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2994 Change-Id: I49e029d5825e84ba36331586bfcfbf0fe34f7c2c Reviewed-on: https://skia-review.googlesource.com/2994 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
* validate using nx to match boundsGravatar caryclark2016-10-05
| | | | | | | | | | | Check the path against the bounds using Nx instead of straight scalars, R=mtklein@google.com BUG=skia:5541 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388903006 Review-Url: https://codereview.chromium.org/2388903006
* Use calendar.timegm instead of time.mktime in recipesGravatar borenet2016-10-05
| | | | | | | | | Timezones are hard. BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392143004 Review-Url: https://codereview.chromium.org/2392143004
* Revert[6] "replace SkXfermode obj with SkBlendMode enum in paints"Gravatar Mike Reed2016-10-05
| | | | | | | | | | | | | | - perform version check in CreateProc for XfermodeImageFilter and ArithmeticImageFilter This reverts commit 3ed485f4249e17abb4b11f5018d03175fd1afb44. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2992 Change-Id: Ib4a154cdd5f5d1dcac921ef50d53b79a2d6a1be8 Reviewed-on: https://skia-review.googlesource.com/2992 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Fix public API msg in PRESUBMIT.pyGravatar Ravi Mistry2016-10-05
| | | | | | | | | | | BUG=skia:5825 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2989 Change-Id: Ia074ab00ccd1500bee10a5b313636581e8265461 Reviewed-on: https://skia-review.googlesource.com/2989 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Make test lower-level, make const_cast more visible.Gravatar Mike Klein2016-10-05
| | | | | | | | | | | | | | | | | | I can only think there's something funky going on with the hidden const_cast inside SkRasterPipeline.cpp, or with the Sk4h -> Sk4f conversion. So make the const_cast visible and write the test directly in halfs instead of floats. CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3003 Change-Id: I3a7e19ae165fce44f177b4968a63ec04e25c4b93 Reviewed-on: https://skia-review.googlesource.com/3003 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Presubmit recipe: call presubmit_support.py directlyGravatar borenet2016-10-05
| | | | | | | | | | | | For some reason, presubmit_support.py can't find PRESUBMIT.py unless it has a diff. Calling this script directly allows us to specify a fake upstream to force it to find a diff and therefore be able to find PRESUBMIT.py. BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2398653002 Review-Url: https://codereview.chromium.org/2398653002
* Make local coords be highp in default geometry processorGravatar Brian Salomon2016-10-05
| | | | | | | | | | | | | This fixes some regressions on the Nexus 10 that were introduced when the device coordinate feature was removed from GrCoordTransform. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2987 Change-Id: Ib0286b1e056d6d8f875a45beee8b0eda85dc1382 Reviewed-on: https://skia-review.googlesource.com/2987 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* update defer-canvas for lattice and regionsGravatar Mike Reed2016-10-05
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2985 Change-Id: I9106841d1cc246064d0a963b0a1e9feae109589d Reviewed-on: https://skia-review.googlesource.com/2985 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
* PRESUBMIT.py improvementsGravatar Ravi Mistry2016-10-05
| | | | | | | | | | | | | | * Updated code to check for owners in reviewers for Gerrit issues instead for in the TBR= line. * The previous TBR parsing code was not accounting for adding comments. Eg: "TBR=rmistry (Testing only)". BUG=skia:5825 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2981 Change-Id: I910a3ae71a9f57c14f80c0b0404041cbe451a77c Reviewed-on: https://skia-review.googlesource.com/2981 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Harden degenerate gradient context handlingGravatar fmalita2016-10-05
| | | | | | | | | | | | | Certain inputs produce degenerate values at context creation time only. Detect such cases after context creation, and abort drawing by returning a null shader context instead. BUG=skia:5821 R=reed@google.com,brianosman@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397473003 Review-Url: https://codereview.chromium.org/2397473003
* skpbench: add option for gpu timingGravatar csmartdalton2016-10-05
| | | | | | | | | | Adds a gpu timing option with a GL implementation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003 Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96 Review-Url: https://codereview.chromium.org/2388433003
* webpages_playback: use new skia-skps bucketGravatar borenet2016-10-05
| | | | | | | BUG=skia:2969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393043003 Review-Url: https://codereview.chromium.org/2393043003
* fix fuzzGravatar Cary Clark2016-10-05
| | | | | | | | | | | | | | | | This fix is slightly interesting; if the final close of the contour degenerates into a zero-length line, remove the previous line from the generated contour. TBR=reed@google.com BUG=skia:5822 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3004 Change-Id: Id668d13ccf6aad9bc81d78588fc77437527a0b7b Reviewed-on: https://skia-review.googlesource.com/3004 Reviewed-by: Cary Clark <caryclark@google.com>
* Fixes for presubmit recipeGravatar borenet2016-10-05
| | | | | | | | | | | - Add depot_tools to PATH - Run on a branch - Use max verbosity BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394853002 Review-Url: https://codereview.chromium.org/2394853002
* Fix bmp bug exposed by fuzzerGravatar msarett2016-10-05
| | | | | | | BUG=skia:5820 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391933004 Review-Url: https://codereview.chromium.org/2391933004
* Add action_foreach, copy, and proper target naming.Gravatar Ben Wagner2016-10-05
| | | | | | | | | | Also properly handles dependencies across OBJECT libraries. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2939 Change-Id: I4aa48c896caf262772fe9769e742b54f6e265ab0 Reviewed-on: https://skia-review.googlesource.com/2939 Reviewed-by: Brian Salomon <bsalomon@google.com>
* looks like red and blue start wrong (more unit test debugging)Gravatar Mike Klein2016-10-05
| | | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3001 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot Change-Id: I8d26b5484a2bf67d5d5891475640970046e470d8 Reviewed-on: https://skia-review.googlesource.com/3001 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* initialize result in SkRasterPipelineTest... more debuggingGravatar Mike Klein2016-10-05
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2982 Change-Id: I7c40766c3df61fb66f63e17a2da61219d1d95d1b Reviewed-on: https://skia-review.googlesource.com/2982 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add swarm_presubmit recipeGravatar borenet2016-10-05
| | | | | | | | | This allows us to add a Housekeeper-PerCommit-Presubmit bot/trybot BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392663004 Review-Url: https://codereview.chromium.org/2392663004
* remove dead codeGravatar Cary Clark2016-10-05
| | | | | | | | | | | | | | | Use code coverage and a new '-c' flag to find and remove unneeded code. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2397593002 patch from issue 2397593002 at patchset 1 (http://crrev.com/2397593002#ps1) Change-Id: I741a82de9191146c10457d4c0b9cb9605dff2069 Reviewed-on: https://skia-review.googlesource.com/2983 Reviewed-by: Cary Clark <caryclark@google.com>
* more debugging for this test.Gravatar Mike Klein2016-10-05
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2965 Change-Id: I583bcdeb199212840ff227942ab6ebbf57a481d7 Reviewed-on: https://skia-review.googlesource.com/2965 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Mac: Remove use of deprecated font APIsGravatar ccameron2016-10-04
| | | | | | | | | | | | | Remove use of CGContextSelectFont CGContextShowTextAtPoint APIs. Verified that the new calls create the same pixel value for the smoothing test as before. Also remove workarounds for 10.6, because it is not supported anymore. BUG=skia:5803 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2395613002 Review-Url: https://codereview.chromium.org/2395613002
* Fold extra_*_flags into GN as a config.Gravatar Mike Klein2016-10-04
| | | | | | | | | | | | | | This should make them visible to things like gn_to_cmake.py. I'm not exactly sure what this implies about ordering and overriding. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2938 Change-Id: I0740613993fb5bbfb8363cfa126d1f59768abf60 Reviewed-on: https://skia-review.googlesource.com/2938 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Debug Mac test failure."Gravatar Mike Klein2016-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit I0ed569b585f4962a90a0b6993acc484a74055177. Reason for revert: Mac bots look okay now. I am puzzled. Original change's description: > Debug Mac test failure. > > CQ_EXTRA_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN-Trybot > TBR= > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2933 > > Change-Id: I0ed569b585f4962a90a0b6993acc484a74055177 > Reviewed-on: https://skia-review.googlesource.com/2933 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4feef1f58172d1cc649bc311c9e6d3c86f915617 Reviewed-on: https://skia-review.googlesource.com/2963 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert[5] "replace SkXfermode obj with SkBlendMode enum in paints"Gravatar Mike Reed2016-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit I0fa5c58af428f3da8565465d1219a34ef8417d9a. Reason for revert: failing to deserialize some of the 100K Original change's description: > Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints" > > This reverts commit 2cbcd12281ee807214df094964c584c78932e10b. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924 > > Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a > Reviewed-on: https://skia-review.googlesource.com/2924 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I1805a57eef5ebcac203da5989c8539345ecf806f Reviewed-on: https://skia-review.googlesource.com/2962 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove SK_SUPPORT_LEGACY_TEXTBLOB_BUILDER from public.bzlGravatar Ben Wagner2016-10-04
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2960 Change-Id: I945782a5aaf416b630181bf65f517f89bae95d9f Reviewed-on: https://skia-review.googlesource.com/2960 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Use uint64_t for PlatformFenceGravatar csmartdalton2016-10-04
| | | | | | | | | VkFence is 64 bit even on 32-bit platforms. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2391113002 Review-Url: https://codereview.chromium.org/2391113002
* Make the housekeeper upload doxygen to a newer bucketGravatar borenet2016-10-04
| | | | | | | | BUG=skia:2969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370153003 DOCS_PREVIEW= https://skia.org/?cl=2370153003 Review-Url: https://codereview.chromium.org/2370153003
* Make global use-analytic-AA bit threadsafe.Gravatar Mike Klein2016-10-04
| | | | | | | | | | | | | | | | I also had to cut it down to just a global atomic bool... as a field in a global singleton accessed through instance(), it's very hard to make threadsafe. CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2937 Change-Id: If80be987906dd521fbe644d1d0d577009f06d0e3 Reviewed-on: https://skia-review.googlesource.com/2937 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints"Gravatar Mike Reed2016-10-04
| | | | | | | | | | | | | This reverts commit 2cbcd12281ee807214df094964c584c78932e10b. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2924 Change-Id: I0fa5c58af428f3da8565465d1219a34ef8417d9a Reviewed-on: https://skia-review.googlesource.com/2924 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* disallow -4 pointerGravatar caryclark2016-10-04
| | | | | | | | | | | | | | A user's homegrown unsigned integer overflow tool complains if a nullptr is decremented. The conicWeight pointer likes to predecrement before walking, but this is unnecessary if its value is nullptr. R=reed@google.com BUG=skia:5415 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061833005 Review-Url: https://codereview.chromium.org/2061833005
* Revert of skpbench: add option for gpu timing (patchset #7 id:120001 of ↵Gravatar mtklein2016-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2388433003/ ) Reason for revert: many bots failing Original issue's description: > skpbench: add option for gpu timing > > Adds a gpu timing option with a GL implementation. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2388433003 > > Committed: https://skia.googlesource.com/skia/+/c06720d06faab3b01eba1b8693e0ac791f06dc96 TBR=egdaniel@google.com,bsalomon@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2390383002
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-19 03:44:07 +0000