aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Actually generate the gm images on the DDL1 botGravatar Robert Phillips2018-04-12
| | | | | | | Change-Id: Iea8a798c2711233eaf8e8ce1d627745f7071b77f Reviewed-on: https://skia-review.googlesource.com/121081 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* son of path is rect bugGravatar Cary Clark2018-04-12
| | | | | | | | | | | | | | | | | | | This variation tricks SkPath::isRect by exploiting that the implementation resets the point pointer to process the close verb, and using the reset pointer to walk over a series of points that don't move. In addition to fixing this, rename variables to make the line creation more obvious, since left, right, and friends, are not the left and right. R=robertphillips@google.com Bug: 824145,skia:7792 Change-Id: If8ebbc3eedd270652670d6e111a5bc02e61f0eec Reviewed-on: https://skia-review.googlesource.com/121122 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>
* workaround for buggy macOS GLSL shader compilerGravatar Ethan Nicholas2018-04-12
| | | | | | | | Bug: skia: Change-Id: Ib77e11d80f93f76e65eac6119dbf2bd03523aaf9 Reviewed-on: https://skia-review.googlesource.com/117626 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Delete getRenderTargetHandle call on SkSurface.Gravatar Greg Daniel2018-04-12
| | | | | | | | | | | All clients and internal code should be switched (once changes land soon) to the new getBackendRenderTarget call instead. Bug: skia: Change-Id: I6f490b6d26a72f37f97216be04e541483206510d Reviewed-on: https://skia-review.googlesource.com/121103 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* check for non-finite values output by clipperGravatar Mike Reed2018-04-12
| | | | | | | | | | Bug: oss-fuzz:7452 Change-Id: Id1b9bd1ad9245f32d69b7ce97544955fcde5670f Reviewed-on: https://skia-review.googlesource.com/121102 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Fail fast when trying to make a texture that's too largeGravatar Brian Osman2018-04-12
| | | | | | | | | | | | | This saves us from doing lots of throwaway decoding work if the image can't be uploaded. This is based on -- but doesn't entirely fix -- https://github.com/flutter/flutter/issues/16454 Change-Id: I4025f31f1334b715a04b4503aeb4f857851b5772 Reviewed-on: https://skia-review.googlesource.com/121104 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Include shadow ops in the debugger.Gravatar Derek Sollenberger2018-04-12
| | | | | | | | Bug: skia:7803 Change-Id: Ic4441e696a56b898e5095f747ab1b9a9c0e0f858 Reviewed-on: https://skia-review.googlesource.com/121100 Commit-Queue: Derek Sollenberger <djsollen@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Reland "Add private fIsBadForDAA bit to SkPath"Gravatar Yuqian Li2018-04-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ed5e069dbb0b2ef49e22b9d17af3875e3682cd61. Reason for revert: add the guard flag Original change's description: > Revert "Add private fIsBadForDAA bit to SkPath" > > This reverts commit 54aefc74103a5c1810a7cc074746915c78ab3132. > > Reason for revert: Forget the guard flag. Pixel tests would fail. > > Original change's description: > > Add private fIsBadForDAA bit to SkPath > > > > Bug: chromium:821353 > > Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4 > > Reviewed-on: https://skia-review.googlesource.com/120201 > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > TBR=caryclark@google.com,liyuqian@google.com,reed@google.com > > Change-Id: I2fe7cfcc3a80a51415f72d656da95a894a3240a4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:821353 > Reviewed-on: https://skia-review.googlesource.com/120505 > Reviewed-by: Yuqian Li <liyuqian@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com Change-Id: Iebf7caf9ca74f305dec25b1b6512e93cb41cc8ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:821353 Reviewed-on: https://skia-review.googlesource.com/120620 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* add conservative bounds to raster tilingGravatar Mike Reed2018-04-12
| | | | | | | | | | | | | | This allows the tiler to optimally visit only the tiles that might intersect the drawing. Not all call-sites can cheaply compute their bounds, so for those we just pass nullptr, which tells the tiler to visit all of the tiles. Bug: 818693 Bug: 820245 Bug: 820470 Change-Id: I8bda668a99bcdb2a9a74a8278ec0cf1004acba6e Reviewed-on: https://skia-review.googlesource.com/119570 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* always clear the looper when we're unrolling it, to not confused devicesGravatar Mike Reed2018-04-12
| | | | | | | | | | Discovered by https://skia-review.googlesource.com/c/skia/+/119570 Bug: skia: Change-Id: I18c13052c5eb410a46ab16e2f1015861948678af Reviewed-on: https://skia-review.googlesource.com/121062 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Disable CCPR and the small path renderer on DDL1 botGravatar Robert Phillips2018-04-12
| | | | | | | | | This should make the comparison between the DDL1 & DDL3 images easier Change-Id: I9402364816da009a3991cc38e6a16bfa94899705 Reviewed-on: https://skia-review.googlesource.com/120542 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* another rect is path fixGravatar Cary Clark2018-04-12
| | | | | | | | | | | | | | | | | | | | | | | | This addresses comment #17 of skbug.com/7792. The bug overshoots the end and exploits that the first point tracked by close isn't the first point in the rectangle. Fixing this slightly regresses the example in comment #14; before it was treated as a filled rect but now it is not; this conservative approach doesn't cause any other regressions. bug7792 in pathfill.cpp verifies that all paths in the bug draw correctly by comparing CPU and GPU. R=robertphillips@google.com Bug: 824145,skia:7792 Change-Id: I55bea023d2ad7456c8c3ebd9d1df95fe34e0a0d4 Reviewed-on: https://skia-review.googlesource.com/120996 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Add SK_SUPPORT_LEGACY_BACKEND_OBJECTSGravatar Robert Phillips2018-04-12
| | | | | | | | | This relies on the Chrome CL: https://chromium-review.googlesource.com/c/chromium/src/+/999796 (Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS to SkUserConfig.h) landing first. Change-Id: Ie0a2b7b84cc02e46957765a0a7d6444a5320769d Reviewed-on: https://skia-review.googlesource.com/119140 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Implement Sk2f Load2Gravatar Chris Dalton2018-04-12
| | | | | | | | Bug: skia: Change-Id: I7d37a76bcb9df9c5a1c22eb1b0277387816df7bb Reviewed-on: https://skia-review.googlesource.com/120602 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* ccpr: Blacklist ANGLE againGravatar Chris Dalton2018-04-12
| | | | | | | | Bug: skia:7805 Change-Id: I58290feeca649ffefb389052c127e01703025d61 Reviewed-on: https://skia-review.googlesource.com/120606 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Allow SkImage_Gpu to fail some requests in DDL modeGravatar Robert Phillips2018-04-12
| | | | | | | | | In particular, anything that forces an instantiation is forbidden. Change-Id: I3cf83a6fdedb03105dda7d928b9c0f73315199cc Reviewed-on: https://skia-review.googlesource.com/120421 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* update_meta_config: Use new LUCI optional GPU trybot on WindowsGravatar Corentin Wallez2018-04-12
| | | | | | | | | BUG=chromium:815092 Change-Id: I4b1ef90d6053a30e4f66a93974b24b8694dbc351 Reviewed-on: https://skia-review.googlesource.com/120563 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Implement Sk4f min/maxGravatar Chris Dalton2018-04-12
| | | | | | | | Bug: skia: Change-Id: Icf235dea81e9f125c1c8590ec87cb3591393036c Reviewed-on: https://skia-review.googlesource.com/120281 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Remove obsolete commentGravatar Yuqian Li2018-04-12
| | | | | | | | | Bug: skia: Change-Id: I4a290e643275c4e41e7f42496ffc14a9a1abca82 TBR: reed@google.com, mtklein@google.com, herb@google.com Reviewed-on: https://skia-review.googlesource.com/120560 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Upgrade PixelC and NexusPlayer OS.Gravatar Ben Wagner2018-04-12
| | | | | | | | No-Try: true Change-Id: I9295739ce755325182a956a0c2ac068b599df767 Reviewed-on: https://skia-review.googlesource.com/120300 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/2dadd1d08e23..14f4817c4dad $ git log 2dadd1d08..14f4817c4 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 lucferron Vulkan: Simplify viewport / scissor updates 2018-04-11 cwallez cq.cfg: equivalent_to to 100% for Windows tryservers. Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: I5415bfeab6cf1006f28f9f15f80b25932da55e46 Reviewed-on: https://skia-review.googlesource.com/120820 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* fix bm gmGravatar Cary Clark2018-04-12
| | | | | | | | | | | | | gm bug7792 had wrong dimensions and clipped out half the draws bm SkRect_Reference.bmh referred to SkIPoint::center.. which has been removed. Docs-Preview: https://skia.org/?cl=120640 Bug: skia:6898 Change-Id: Id4c59c82005e1060d0ca933d9a3650fe4f121264 Reviewed-on: https://skia-review.googlesource.com/120640 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* skcms→1654786 concat gamut transform matrices togetherGravatar Mike Klein2018-04-12
| | | | | | | | | No-Tree-Checks: true Change-Id: Ibfbbfe35caf9e2ed8a80aa9add2c4cae50585120 Reviewed-on: https://skia-review.googlesource.com/120997 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Reland "Fix handling of MaskFilter matrices"Gravatar Florin Malita2018-04-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c64ee20e135a336ed775ccb6dec8a87efd19ec02. Reason for revert: initial failures should be fixed in https://skia.googlesource.com/skia.git/+/8eaf64ae12696d4189d3cea9f023658494cf82b8 Original change's description: > Revert "Fix handling of MaskFilter matrices" > > This reverts commit 2097fd03ffea48bd904c48c93348b2350600870e. > > Reason for revert: This is breaking a lot of Windows bots (esp. on the shadermaskfilter_localmatrix) > > Original change's description: > > Fix handling of MaskFilter matrices > > > > 1) extend GrFPArgs to track pre/post local matrices, add helpers for > > creating pre/post wrapper args > > > > 2) add a SkShaderBase helper (totalLocalMatrix) to centralize the LM > > sandwich logic. > > > > 3) update call sites to use the above > > > > 4) rename SkMatrixFilter::makeWithLocalMatrix -> makeWithMatrix, to > > disambiguate vs. SkShader::makeWithLocalMatrix. > > > > BUG=skia:7744 > > > > Change-Id: Ib2b7b007e6924979b00649dde7c94ef4b34771f1 > > Reviewed-on: https://skia-review.googlesource.com/119330 > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com,fmalita@chromium.org,reed@google.com > > Change-Id: I918dbb95bf00b3122e6699b84566ec82dbb5fc5c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7744 > Reviewed-on: https://skia-review.googlesource.com/120340 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com,fmalita@chromium.org,reed@google.com Change-Id: If194862a928d1abe22ed8fa968436c725d19a8fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7744 Reviewed-on: https://skia-review.googlesource.com/120480 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Roll third_party/externals/angle2/ 785b20b7a..2dadd1d08 (11 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/785b20b7af9b..2dadd1d08e23 $ git log 785b20b7a..2dadd1d08 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 jmadill D3D11: Fix inactive attrib VAO perf regression. 2018-03-31 jmadill Texture: Pass ImageIndex to relevant methods. 2018-04-08 jmadill Vulkan: Rename vk::LineLoopHelper. 2018-04-10 lucferron Vulkan: Cleanup some TODOs in TextureTest.cpp 2018-04-10 jdarpinian D3D11: Fix primitive topology dirty bit tracking. 2018-03-23 oetuaho Take all attributes into account when checking for aliasing 2018-04-09 lfy GLES1: glMultMatrix(f|x) 2018-04-09 lfy GLES1: glLoadIdentity / glLoadMatrix(f|x) 2018-04-10 jmadill D3D11: Add more debug names. 2018-04-10 ynovikov Skip RobustResourceInitTestES3.MaskedStencilClearBuffer on Mac NVIDIA. 2018-04-05 lucferron Vulkan: 3 Final bugfixes to enable all dEQP depth_stencil tests Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: If230990ec760fd071f52ae12ff0c6ecad40b874e Reviewed-on: https://skia-review.googlesource.com/120580 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Upgrade Windows Skolo bots.Gravatar Ben Wagner2018-04-11
| | | | | | | Change-Id: Iab663424527bbc65566341056664673f02204dce Reviewed-on: https://skia-review.googlesource.com/119263 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* remove unused/dumb methods from SkRectGravatar Mike Reed2018-04-11
| | | | | | | | Bug: skia: Change-Id: I407dc94256a347c7a9343b75a5af43c4294891d3 Reviewed-on: https://skia-review.googlesource.com/119360 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Clean-up paints for drawImage (etc.) to enforce that we alwaysGravatar Mike Reed2018-04-11
| | | | | | | | | | ignore stroking and patheffects. Bug: skia:7804 Change-Id: I0b5f3a6734c5e4201a6e3a2bd5e398d213c8950e Reviewed-on: https://skia-review.googlesource.com/120504 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* more path is rect bugsGravatar Cary Clark2018-04-11
| | | | | | | | | | | | | More edge cases found; clean up the logic a bit to make more clear where the rectangle points start and stop. R=robertphillips@google.com,brianosman@google.com Bug: 824145,skia:7792 Change-Id: Ie24dfd1519f30875f44ffac68e20d777490b00b9 Reviewed-on: https://skia-review.googlesource.com/120422 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* skcms→9334796 reject non-XYZ/Lab PCS profilesGravatar Mike Klein2018-04-11
| | | | | | | Change-Id: I6dd917c1f090a18e6508b0391f119f8f91929162 Reviewed-on: https://skia-review.googlesource.com/120502 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Add private fIsBadForDAA bit to SkPath"Gravatar Yuqian Li2018-04-11
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 54aefc74103a5c1810a7cc074746915c78ab3132. Reason for revert: Forget the guard flag. Pixel tests would fail. Original change's description: > Add private fIsBadForDAA bit to SkPath > > Bug: chromium:821353 > Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4 > Reviewed-on: https://skia-review.googlesource.com/120201 > Commit-Queue: Yuqian Li <liyuqian@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com Change-Id: I2fe7cfcc3a80a51415f72d656da95a894a3240a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:821353 Reviewed-on: https://skia-review.googlesource.com/120505 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* skcms→56f2a09 add sRGB profile and ApproximatelyEqualProfiles()Gravatar Mike Klein2018-04-11
| | | | | | | Change-Id: Ic6408fdc8819342da175ec8b99b5838669b1b2ae Reviewed-on: https://skia-review.googlesource.com/120501 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add private fIsBadForDAA bit to SkPathGravatar Yuqian Li2018-04-11
| | | | | | | | Bug: chromium:821353 Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4 Reviewed-on: https://skia-review.googlesource.com/120201 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Add Vulkan to the DDL botsGravatar Robert Phillips2018-04-11
| | | | | | | | | This cannot land before: https://skia-review.googlesource.com/c/skia/+/118989 (Get ViaDDL working with Vulkan) Change-Id: If6e2cdc51c7fb0b709bfa49a7c8a8d75f324eaae Reviewed-on: https://skia-review.googlesource.com/120121 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* roll to particular targetsGravatar Mike Klein2018-04-11
| | | | | | | Change-Id: Iafbcab2fd406a81766f534d70b36f38b1c369506 Reviewed-on: https://skia-review.googlesource.com/120500 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Switch to latest Windows Intel Skylake GPU driver.Gravatar Ben Wagner2018-04-11
| | | | | | | | | | | | | This is in preparation for upgrading the Windows Skolo bots. See also https://skia-review.googlesource.com/c/buildbot/+/119320 -- pnputil.exe doesn't like installing drivers older than the ones available from Windows Update. Bug: skia:7680 Change-Id: I8e8dedad89a70eb02730803a777671514ed1e84e Reviewed-on: https://skia-review.googlesource.com/120440 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix SkTCopyOnFirstWrite copy semanticsGravatar Florin Malita2018-04-11
| | | | | | | | | | | | | | | The implicit SkTCopyOnFirstWrite copy-ctor and assignment operator are incorrect: fObj must point to the local copy, not to the source copy (when a copy has been made). Add corrected explicit copy (and move) ctor + assignment operator. Also add a get() helper to facilitate rawptr access. Change-Id: Ie3983e12c04eae4f32c40e3e267618cf02008c20 Reviewed-on: https://skia-review.googlesource.com/120442 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* no need to tile draws that don't involve pathsGravatar Mike Reed2018-04-11
| | | | | | | | Bug: skia: Change-Id: I2e974162982a81b1d2ac2505df809f15354ded07 Reviewed-on: https://skia-review.googlesource.com/120425 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* skcms→91a8958 Detect and canonicalize identity tablesGravatar Mike Klein2018-04-11
| | | | | | | Change-Id: I36957b8d7d96ac262b509c218779775c90864314 Reviewed-on: https://skia-review.googlesource.com/120420 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* skcms→307ec0f remove a layer of nesting in skcms_CurveGravatar Mike Klein2018-04-11
| | | | | | | Change-Id: I0b0959063c22b2066b2103a4e93e396c10eb388e Reviewed-on: https://skia-review.googlesource.com/120382 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix alpha threshold image filter GPU implementationGravatar Robert Phillips2018-04-11
| | | | | | | | BUG=skia:7760 Change-Id: I674d705ce637c405361ecf45ea8604d1606f7af7 Reviewed-on: https://skia-review.googlesource.com/120203 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove guard around getBackendTexture/RenderTarget callsGravatar Greg Daniel2018-04-11
| | | | | | | | Bug: skia: Change-Id: Ia9ad987d4af183985724f32b022553af0fcb2b78 Reviewed-on: https://skia-review.googlesource.com/120124 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Fix handling of MaskFilter matrices"Gravatar Robert Phillips2018-04-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2097fd03ffea48bd904c48c93348b2350600870e. Reason for revert: This is breaking a lot of Windows bots (esp. on the shadermaskfilter_localmatrix) Original change's description: > Fix handling of MaskFilter matrices > > 1) extend GrFPArgs to track pre/post local matrices, add helpers for > creating pre/post wrapper args > > 2) add a SkShaderBase helper (totalLocalMatrix) to centralize the LM > sandwich logic. > > 3) update call sites to use the above > > 4) rename SkMatrixFilter::makeWithLocalMatrix -> makeWithMatrix, to > disambiguate vs. SkShader::makeWithLocalMatrix. > > BUG=skia:7744 > > Change-Id: Ib2b7b007e6924979b00649dde7c94ef4b34771f1 > Reviewed-on: https://skia-review.googlesource.com/119330 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com,fmalita@chromium.org,reed@google.com Change-Id: I918dbb95bf00b3122e6699b84566ec82dbb5fc5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7744 Reviewed-on: https://skia-review.googlesource.com/120340 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll third_party/externals/angle2/ 0ce016c1b..785b20b7a (7 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-04-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0ce016c1bd12..785b20b7af9b $ git log 0ce016c1b..785b20b7a --date=short --no-merges --format='%ad %ae %s' 2018-04-10 lucferron Vulkan: PointSprite suppress 3 tests that are failing the android tests 2018-04-06 lucferron Vulkan: Enable point sprite end2end tests 2018-04-06 lucferron Vulkan: Implement support for structs in uniforms 2018-04-09 jmadill Vulkan: Create TextureVk's Image lazily. 2018-04-09 jmadill Optimize Subject's binding method. 2018-03-30 jiawei.shao Use ShaderBitSet for active use bits on uniforms 2018-04-06 brandon1.jones Create Stubs For Unimplemented Extensions Created with: roll-dep third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=borenet@google.com Change-Id: I57a37b6aacbbeacecbc34c37d4539eaa14a8dd41 Reviewed-on: https://skia-review.googlesource.com/120280 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Fix handling of MaskFilter matricesGravatar Florin Malita2018-04-11
| | | | | | | | | | | | | | | | | | | | 1) extend GrFPArgs to track pre/post local matrices, add helpers for creating pre/post wrapper args 2) add a SkShaderBase helper (totalLocalMatrix) to centralize the LM sandwich logic. 3) update call sites to use the above 4) rename SkMatrixFilter::makeWithLocalMatrix -> makeWithMatrix, to disambiguate vs. SkShader::makeWithLocalMatrix. BUG=skia:7744 Change-Id: Ib2b7b007e6924979b00649dde7c94ef4b34771f1 Reviewed-on: https://skia-review.googlesource.com/119330 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Get ViaDDL working with VulkanGravatar Robert Phillips2018-04-11
| | | | | | | Change-Id: Iab5ab689529227d2c8a6dbea89e555b73622a99c Reviewed-on: https://skia-review.googlesource.com/118989 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* skcms→e753c6d disable -Wdouble-promotionGravatar Brian Osman2018-04-11
| | | | | | | Change-Id: I8cfebed0a6617a625dd91e31af4b581aaeae86fe Reviewed-on: https://skia-review.googlesource.com/120122 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Move GrBackendRenderTarget over to new system of getting backed infosGravatar Greg Daniel2018-04-11
| | | | | | | | Bug: skia: Change-Id: I3927390894715e8424b3d0240dad3ee6cd03dc38 Reviewed-on: https://skia-review.googlesource.com/120181 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Remove unused field fBitmapBytesGravatar Yuqian Li2018-04-11
| | | | | | | | Bug: skia: Change-Id: I3544b8ed8a02447e765a5389a4c0ea9ca2f09944 Reviewed-on: https://skia-review.googlesource.com/120240 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Add ctor to GrVkImageInfo.Gravatar Greg Daniel2018-04-10
| | | | | | | | | | | Adds an additional ctor so clients who used brace initialization on the struct don't break. Bug: skia: Change-Id: I78ebdbe8242147e48859f2234265365141fe81b1 Reviewed-on: https://skia-review.googlesource.com/120185 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>