aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* guard legacy bilerp-ignorning hackGravatar Mike Reed2017-07-06
| | | | | | | | Bug: skia:6835 Change-Id: I7f3136595299f9193bc9173a03b782888043aeb5 Reviewed-on: https://skia-review.googlesource.com/21722 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Unfriend SkImageFilter subclassesGravatar Florin Malita2017-07-06
| | | | | | | | | | Subclasses should call SkColorSpaceXformer::apply methods, not makeColorSpace(). Change-Id: I64732641b90dd3f82e331adfd36f2c60dcf996b2 Reviewed-on: https://skia-review.googlesource.com/21724 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* add stages for black and white colorsGravatar Mike Reed2017-07-06
| | | | | | | | | | | | | | histogram of test skps: black: 1/7 white: 2/7 other: 4/7 Bug: skia: Change-Id: I3a092899d31ce87837e66e5c8ea9ec5e0f239361 Reviewed-on: https://skia-review.googlesource.com/21408 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Image filter DAG test for makeColorSpace()Gravatar Florin Malita2017-07-06
| | | | | | | Change-Id: I8aa3a8c701fdfe215cae639bc9c7082340c756d4 Reviewed-on: https://skia-review.googlesource.com/21721 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* only create new instance if needed for colorspacexformerGravatar Mike Reed2017-07-06
| | | | | | | | | | just an experiment to address performance when imagefilters are cached. Bug: skia: Change-Id: Ic1033c897d0a569b46a339fb3ae7f8f961882953 Reviewed-on: https://skia-review.googlesource.com/21395 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Add SkCodec::Result indicating error in the dataGravatar Leon Scroggins III2017-07-06
| | | | | | | | | | | | | | | | | | Previously, SkGifCodec treated an error in the LZW data as incomplete, since we can still draw the partially decoded image. But a client doing incremental decodes needs to distinguish this from truly incomplete data. In the case of an error, the client should not attempt to provide more data and decode again. Add kErrorInInput, and return it when SkGifCodec sees a fatal error. Treat it the same as kIncompleteInput when it comes to filling and DM. Bug: skia:6825 Change-Id: Ic6ce3a62c0b065ed34dcd8006309e43272a3db9f Reviewed-on: https://skia-review.googlesource.com/21530 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Chris Blume <cblume@chromium.org>
* ICO: Prevent calling 'new' with large valuesGravatar Leon Scroggins III2017-07-06
| | | | | | | | | | | numImages is read from untrusted data, and as an unsigned short could be up to 65,536. Avoid calling new with this number, which could result in a crash if it pushes the device over the memory limit. Change-Id: Ifff9e0ac6ade2b3d8584af656ea7d2f9eb4998e2 Reviewed-on: https://skia-review.googlesource.com/21269 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* SkPDF: Change some identifiers.Gravatar Hal Canary2017-07-06
| | | | | | | | | | | s/SkPDFShader::GetPDFShader/SkPDFMakeShader/g s/SkPDFShader::State/SkPDFImageShaderKey/g s/state/key/g Change-Id: I86dc932c3407c73f387c972fb6674dc09ea0be3c Reviewed-on: https://skia-review.googlesource.com/21661 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Make mock GrContext unit testable.Gravatar Brian Salomon2017-07-06
| | | | | | | | Bug: skia: Change-Id: I959122f1f2c390832ab1033bcdbdd2ca6cfc0419 Reviewed-on: https://skia-review.googlesource.com/20699 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* GR_TEST_UTILS fixesGravatar Brian Salomon2017-07-06
| | | | | | | | | | | | | | Fixes build of Skia lib when GR_TEST_UTILS=0 Makes GR_TEST_UTILS=0 for official builds Makes "Mini" builder bot exercise building GPU with is_official_build=true Bug: skia:6786 Change-Id: I6186683a3a216d2e779645bd9e8276a66bcff4d5 Reviewed-on: https://skia-review.googlesource.com/21524 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* add --forceRasterPipeline to dm, (already in nanobench)Gravatar Mike Reed2017-07-06
| | | | | | | | Bug: skia: Change-Id: I0e5f7dd2aaa03340687cdfe5578c8697088cd714 Reviewed-on: https://skia-review.googlesource.com/21532 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Fix perf blacklist after test name changeGravatar Greg Daniel2017-07-06
| | | | | | | | Bug: skia: Change-Id: Id5494c4818e5ed19ed25a67cc3e95b1358bf1496 Reviewed-on: https://skia-review.googlesource.com/21663 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* output flags onceGravatar Cary Clark2017-07-06
| | | | | | | | | | | | | When asking for help on more than one item, e.g. foo -h me -h oh -h my just print Flags: once. TBR=scroggo@google.com Change-Id: I67080c7390e6bacf4c36096304dd959229fdd07b Reviewed-on: https://skia-review.googlesource.com/21660 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* srgb conversion needs to be in unpremulGravatar Mike Reed2017-07-06
| | | | | | | | Bug: skia: Change-Id: Ic7dffb2cb30aae33a6c127ab10ea4282e1360114 Reviewed-on: https://skia-review.googlesource.com/21536 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* protect against fuzzerGravatar Cary Clark2017-07-06
| | | | | | | | | | | | Fuzzer data may generate path without a computable length. R=reed@google.com Bug: 739190 Change-Id: I052540932937f24951ce66699080b8b959fb1a46 Reviewed-on: https://skia-review.googlesource.com/21500 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* SkTypeface: fix non-determinism on AdvacedMetricsGravatar Hal Canary2017-07-06
| | | | | | | | | Calculate fStemV and fCapHeight using SkPaint in SkPDFFont if needed. Change-Id: Iaf762e6c44178fac659dfe9fa312d0caed9138ae Reviewed-on: https://skia-review.googlesource.com/21535 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* SkDocument: consolidate trimBox codeGravatar Hal Canary2017-07-05
| | | | | | | | Change-Id: I56f651320964eb3bd33475d21e6977803c4ca140 Reviewed-on: https://skia-review.googlesource.com/21370 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Use RGBA rather than N32 for GPU testsGravatar Brian Salomon2017-07-05
| | | | | | | | | This is to support a Mock backend that passes non-rendering context unit tests and has minimal config support. Change-Id: I57c3ad2d347659d14382a8a7cf53424633bd86c6 Reviewed-on: https://skia-review.googlesource.com/21534 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add basic metal build files for backendGravatar Greg Daniel2017-07-05
| | | | | | | | | Bug: skia: Change-Id: Iddeeb91b378bdb61d200070d8faa3610299ab733 Reviewed-on: https://skia-review.googlesource.com/21533 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* rewrote GrAlphaThresholdFragmentProcessor in skslGravatar Ethan Nicholas2017-07-05
| | | | | | | | Bug: skia: Change-Id: I641b206fc3bc19ac190ad94ee755ab9e1caab9b3 Reviewed-on: https://skia-review.googlesource.com/21341 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* add srgb gamma colorfiltersGravatar Mike Reed2017-07-05
| | | | | | | | | | | | | ... faster and more accurate than using SkTableColorFilter todo: update blink after this lands Bug:737981 Change-Id: I55b5c60dd23b9d2cbe9d60f83c74be1a8f3dcfcf Reviewed-on: https://skia-review.googlesource.com/21368 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* SkPDF: GradientShaderPatterns use one hashmap not two.Gravatar Hal Canary2017-07-05
| | | | | | | Change-Id: Icdebaf891884aa06bdc36ed930d7bab5400bd04f Reviewed-on: https://skia-review.googlesource.com/21529 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* add --csv option to nanobenchGravatar Mike Reed2017-07-05
| | | | | | | | | | | This makes it trivial to copy/paste into spreadsheets for sorting/diffing Bug: skia: Change-Id: I02c920e2b8be8f59270da9fb9bb3e6763987e0bc Reviewed-on: https://skia-review.googlesource.com/21378 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Remove CodecSrc::kIndex8_Always_DstColorTypeGravatar Leon Scroggins III2017-07-05
| | | | | | | | | | We have removed support for drawing Index8, so stop testing it in DM. Bug: skia: 6828 Change-Id: Ib2c4d3ebd371be704151a9f956c0ca2aaf2926a6 Reviewed-on: https://skia-review.googlesource.com/21525 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* doh -- fix capitalizationGravatar Mike Reed2017-07-05
| | | | | | | | Bug: skia: Change-Id: I25d4f4eeb3d06f3e2b64aad652ef91743494755a Reviewed-on: https://skia-review.googlesource.com/21528 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkPDF: Refactor PDFShader to use ShTHashMap<>Gravatar Hal Canary2017-07-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | my tests run ~14% faster. - Split out gradient shaders from image shaders. new compilation unit: SkPDFGradientShader - Common functions InverseTransformBBox and PopulateTilingPatternDict moved to SkPDFUtils - Split SkPDFShader::State into image and gradient structures. - SkPDFCanon is now a simpler structure, with no logic of its own. I am considering just moving all of its fields into SkPDFDocument - SkPDFShader::State (the image/fallback shader) now is POD, making the use of a hashmap for canonicalization straightforward. Formerly, we used a linear search. - Do not bother trying to canonicalize the falback image shader. - SkPDFGradientShader::Key is not POD; comparison of two objects requires looking at the contents of two variable-sized arrays. We now pre-calculate the hash of the arrays using SkOpts::hash and store a hash for the object in the fHash field. Using that hash, we can now canonicalize using a hashmap instead of a linar search! - several static functions renamed to follow style guidelines - stop using codeFunction function pointer; I find that less clear than it could be. - operator==() for SkPDFShader::State and SkPDFGradientShader::Key is now much simpler and can now be inlined. - SkArrayEqual template in SkPDFUtils.h No change to PDF output. BUG=skia:3585 Change-Id: I354ad1b600be6d6749abccb58d13db257370bc0b Reviewed-on: https://skia-review.googlesource.com/21376 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "Indicate texel buffer support in Vulkan"Gravatar Chris Dalton2017-07-05
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2dd222639dba16fab4e81dbf3e7916fc1eb2cd29. Reason for revert: Programs test assertion failures Original change's description: > Indicate texel buffer support in Vulkan > > Bug: skia: > Change-Id: I116dd2b15320e3a61afba82b003b13a14ce6122f > Reviewed-on: https://skia-review.googlesource.com/21402 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=egdaniel@google.com,csmartdalton@google.com Change-Id: I41ee31624636c497125ff38bcb7ce0382d9f386b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/21582 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Disallow burst context instantiation for non-invertible CTMsGravatar Florin Malita2017-07-05
| | | | | | | | | | | | Similar to SkShaderBase::makeContext(), catch this condition and bail early. BUG=chromium:738682 Change-Id: I4c7a2036bed8ab8699023c4f8f3bc2161de0c41d Reviewed-on: https://skia-review.googlesource.com/21521 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* optimize for diff matrix typesGravatar Mike Reed2017-07-05
| | | | | | | | Bug: skia: Change-Id: I671e07c5bbb9e4ced92303c9959143324f7a6bdc Reviewed-on: https://skia-review.googlesource.com/21523 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com>
* update bots after renaming benchGravatar Mike Reed2017-07-05
| | | | | | | | | | See https://skia-review.googlesource.com/c/21407/ Bug: skia: Change-Id: I94e34d1058c187d1f183aecedf6f33db2a6baad6 Reviewed-on: https://skia-review.googlesource.com/21527 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Indicate texel buffer support in VulkanGravatar Chris Dalton2017-07-05
| | | | | | | | Bug: skia: Change-Id: I116dd2b15320e3a61afba82b003b13a14ce6122f Reviewed-on: https://skia-review.googlesource.com/21402 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add a nanobench for drawing glyphs as pathsGravatar Chris Dalton2017-07-05
| | | | | | | | Bug: skia: Change-Id: I6e620befd2fe8e84f744e79e9287d9d2d19ffa57 Reviewed-on: https://skia-review.googlesource.com/21389 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* header cleanupGravatar Hal Canary2017-07-05
| | | | | | | Change-Id: I3f7667a1357194ae2bdd341ad9d46eb93920f404 Reviewed-on: https://skia-review.googlesource.com/21374 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "enable new tiling for android"Gravatar Mike Reed2017-07-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fe11e458b0282bf5ebb7943d3bb9455cb46adf9e. Reason for revert: android roll failed, even with newer images: junit.framework.AssertionFailedError: 80 dpi: totalDiffPixelCount is 2 at junit.framework.Assert.fail(Assert.java:50) at android.graphics.drawable.cts.DrawableTestUtils.compareImages(DrawableTestUtils.java:193) at android.graphics.drawable.cts.BitmapDrawableTest.compareOrSave(BitmapDrawableTest.java:629) at android.graphics.drawable.cts.BitmapDrawableTest.verifyPreloadDensityInner(BitmapDrawableTest.java:598) at android.graphics.drawable.cts.BitmapDrawableTest.testPreloadDensity(BitmapDrawableTest.java:556) Original change's description: > enable new tiling for android > > android roll will need to be coordinated w/ > https://googleplex-android-review.git.corp.google.com/#/c/2483600/ > > Bug: skia: > Change-Id: Iee6d6cd246f2e5b64f24440a17791821c8fb2f94 > Reviewed-on: https://skia-review.googlesource.com/21369 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Derek Sollenberger <djsollen@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=djsollen@google.com,reed@google.com Change-Id: Ic8cd056d0737a817d558cc1de9d90d8d334d0ec1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/21522 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* enable new tiling for androidGravatar Mike Reed2017-07-05
| | | | | | | | | | | | android roll will need to be coordinated w/ https://googleplex-android-review.git.corp.google.com/#/c/2483600/ Bug: skia: Change-Id: Iee6d6cd246f2e5b64f24440a17791821c8fb2f94 Reviewed-on: https://skia-review.googlesource.com/21369 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Mike Reed <reed@google.com>
* We should draw at least once for benchmarkGravatar Yuqian Li2017-07-04
| | | | | | | | Bug: skia:6792 Change-Id: Ia69c7601abead8f30963de709f22e27e04798319 Reviewed-on: https://skia-review.googlesource.com/20697 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* experimental/documentation/gerrit.md: fix errorGravatar Hal Canary2017-07-04
| | | | | | | | NOTRY=true Change-Id: I40762016f28cd5814c79e4159fa4f73d585f6545 Reviewed-on: https://skia-review.googlesource.com/21377 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* update blendmode benchGravatar Mike Reed2017-07-04
| | | | | | | | Bug: skia: Change-Id: Id47fedd9e346035af0f14b9a9c171c79eec0d9cd Reviewed-on: https://skia-review.googlesource.com/21407 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* consolidate logic for matrix stageGravatar Mike Reed2017-07-04
| | | | | | | | Bug: skia: Change-Id: Id1559b31692a1aed9aa4d15620b2019ae9c7c22b Reviewed-on: https://skia-review.googlesource.com/21404 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Handle degenerate 2pt conical center values gracefullyGravatar Florin Malita2017-07-03
| | | | | | | | | | | | | SkMatrix::setPolyToPoly() may fail to map degenerate values. Handle this case explicitly, instead of assuming it never fails. BUG=chromium:738746 TBR= Change-Id: Ie1049b98f7e07ae5d6bdb706ba7b4a399388e5d8 Reviewed-on: https://skia-review.googlesource.com/21375 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* remove unneeded code for index8 imagseGravatar Mike Reed2017-07-03
| | | | | | | | Bug: skia:6828 Change-Id: I039d6bc35a1ed93ce747247f32fe4e9d5b09da0c Reviewed-on: https://skia-review.googlesource.com/21400 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* hide index8 supportGravatar Mike Reed2017-07-03
| | | | | | | | Bug: skia: Change-Id: I4ab7f4665cc9992319d3c9a5e02a417d503c189e Reviewed-on: https://skia-review.googlesource.com/20121 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* experimental/documentation/gerrit.md: check for error caseGravatar Hal Canary2017-07-02
| | | | | | | | NOTRY=true Change-Id: I0eebe482111efa90dc2fb9d106bdacaf689a38d3 Reviewed-on: https://skia-review.googlesource.com/21371 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SPIR-V comma operator supportGravatar Ethan Nicholas2017-06-30
| | | | | | | | Bug: skia: Change-Id: I9792674c49a0243017bb5f2b3c11d0678e62138e Reviewed-on: https://skia-review.googlesource.com/21367 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Added new edge handling mode (clamp and repeat) to Gaussian blur filter.Gravatar wutao2017-06-30
| | | | | | | | | | | | | | | | | | | Gaussian blur filter will interpolate value by using out of bounds coords, which is 0. This makes it appears darker near the bounds in the blurred images. There are two issues: 1) when downsampling and upsampling, we should use GrTextureDomainEffect kClamp_Mode to clamp the texture coords to the bounds; 2) during Gaussian blur, we need to clamp to texture bounds. BUG=622128 TEST=cc_unittests, GM image test & manual. Some test results can be found at: https://bugs.chromium.org/p/chromium/issues/detail?id=622128#c49 Change-Id: I9283da1d91efb0da94a991f2d372e9f62c288bdc Reviewed-on: https://skia-review.googlesource.com/20465 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Delete non-raster-pipeline SkTwoPointConicalGradient implGravatar Florin Malita2017-06-30
| | | | | | | | Change-Id: If39a2b01d6099fef14695a4ce05b57a3d5c3d99c Reviewed-on: https://skia-review.googlesource.com/21320 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* clean up GCC 6.3 workaroundGravatar Mike Klein2017-06-30
| | | | | | | | | | | This is all kind of silly... this is just a little bit of code that's not really reachable, but there to satisfy compilers that can't figure that out. Change-Id: Ib39e8bf0fd26e28541cfad37c7ea135a30dbe85a Reviewed-on: https://skia-review.googlesource.com/21365 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkPDF: simplify SkPDFGraphicStateGravatar Hal Canary2017-06-30
| | | | | | | | | | | | | | - Separate graphic state objects for Stroke and Fill. - SkPDFGraphicState::GetGraphicStateForPaint simplified. - No more SkPDFGraphicState objects.Simplify SkPDFCanon. All PDFs render the same. Most PDFs are slightly smaller, especially those from captured web pages. Change-Id: Id9605c1d7495645da558d5f378ba585cdc201bba Reviewed-on: https://skia-review.googlesource.com/21343 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkPDF: clean up fRasterDpiGravatar Hal Canary2017-06-30
| | | | | | | | | | | | - PDFDevice no longer has a fRasterDpi; simply queries document. - #define DPI_FOR_RASTER_SCALE_ONE becomes constexpr float. - PDFShader::GetPDFShader no longer takes rasterScale or dpi - Remove un-needed factory functions. We're all adults here. Change-Id: Id2ce75d4e61af385763ccfb1db210465a1600067 Reviewed-on: https://skia-review.googlesource.com/21348 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Speculative "fix" for crash in analyzeProcessorsGravatar Robert Phillips2017-06-30
| | | | | | | | | | | | | | From the bug it looks like a null fragment processors may be getting into the processor set. This CL tries to plug any gaps in our fragmentProcessor handling. The only real substantive part to this CL is the addition of some "if (!fp) { return nullptr; }" blocks. Everything else is just to add chokepoints for processor allocation. Bug: 734076 Change-Id: I4952b1a05bc6690d5aa09de977fa6dc54c80338a Reviewed-on: https://skia-review.googlesource.com/21267 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 23:00:53 +0000