aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix (1 << 31) to (1u << 31) in SkOTTable_OS_2.Gravatar bungeman@google.com2014-03-12
| | | | | | | | | | When ints are 32 bits, (1 << 31) is undefined. R=reed@google.com Review URL: https://codereview.chromium.org/189093020 git-svn-id: http://skia.googlecode.com/svn/trunk@13757 2bbb7eff-a529-9590-31e7-b0007b416f81
* make onReadPixels protected and have default impl (so we can remove chrome ↵Gravatar commit-bot@chromium.org2014-03-12
| | | | | | | | | | | | | override) R=reed@google.com TBR=bsalomon@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/196543004 git-svn-id: http://skia.googlecode.com/svn/trunk@13756 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-03-12
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13755 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Revert "De-virtualize SkCanvas save/restore." ↵Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/194923008/) Reason for revert: Re-landing after roll fix. Original issue's description: > Revert "De-virtualize SkCanvas save/restore." > > (To allow a roll fix into the tree). > > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. > > R=halcanary@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=13748 R=halcanary@google.com, fmalita@chromium.org TBR=fmalita@chromium.org, halcanary@google.com NOTREECHECKS=true NOTRY=true Author: fmalita@google.com Review URL: https://codereview.chromium.org/196323003 git-svn-id: http://skia.googlecode.com/svn/trunk@13754 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SK_SUPPORT_LEGACY_COPYTO_CONFIGGravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | R=halcanary@google.com TBR=halcanary@google.com NOTRY=True NOTREECHECK=True Author: reed@chromium.org Review URL: https://codereview.chromium.org/196003003 git-svn-id: http://skia.googlecode.com/svn/trunk@13753 2bbb7eff-a529-9590-31e7-b0007b416f81
* Alter bench_pictures to "respect" the logPerIter flag.Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | | When --logPerIters is set and --repeat is great then 2 then bench_pictures will run each test "repeat" times (to generate the correct number of timings) by rendering 5 times. This CL also adds a swapBuffers in addition to the pre-existing flush calls. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/194973003 git-svn-id: http://skia.googlecode.com/svn/trunk@13752 2bbb7eff-a529-9590-31e7-b0007b416f81
* First pass at a web app that lets you run Skia code and see the results.Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | BUG=skia: R=reed@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/195143004 git-svn-id: http://skia.googlecode.com/svn/trunk@13751 2bbb7eff-a529-9590-31e7-b0007b416f81
* Only set USE_ANDROID_NDK_CPU_FEATURES if it's not already been explicitly setGravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | R=djsollen@google.com, reed@google.com BUG=skia: Author: george@mozilla.com Review URL: https://codereview.chromium.org/189263015 git-svn-id: http://skia.googlecode.com/svn/trunk@13750 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix build error in chromiumGravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=fmalita@google.com, jvanverth@google.com, fmalita@chromium.org TBR=fmalita@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/195223004 git-svn-id: http://skia.googlecode.com/svn/trunk@13749 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "De-virtualize SkCanvas save/restore."Gravatar fmalita@google.com2014-03-11
| | | | | | | | | | | | (To allow a roll fix into the tree). This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. R=halcanary@google.com Review URL: https://codereview.chromium.org/194923008 git-svn-id: http://skia.googlecode.com/svn/trunk@13748 2bbb7eff-a529-9590-31e7-b0007b416f81
* De-virtualize SkCanvas save/restore.Gravatar fmalita@google.com2014-03-11
| | | | | | | | | | | This moves the state management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=robertphillips@google.com, reed@google.com Review URL: https://codereview.chromium.org/194713008 git-svn-id: http://skia.googlecode.com/svn/trunk@13747 2bbb7eff-a529-9590-31e7-b0007b416f81
* Drop executable flag from headers so that they can be packagedGravatar robertphillips@google.com2014-03-11
| | | | | | | | https://codereview.chromium.org/194883004/ git-svn-id: http://skia.googlecode.com/svn/trunk@13746 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix linking errors on android builds due to cdd0f92b1acGravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | NOTREECHECKS=true NOTRY=true R=iancottrell@google.com, tomhudson@google.com TBR=tomhudson@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/194563003 git-svn-id: http://skia.googlecode.com/svn/trunk@13745 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SkOffsetImageFilter to use a temporary for bounds computations.Gravatar senorblanco@chromium.org2014-03-11
| | | | | | | | | | | | | | SkOffsetImageFilter::onFilterBounds() was writing to *dst, and later referring to src. These may be the same memory location, so the results were incorrect. Covered by the 5th test case in offsetimagefilter. BUG=skia: Review URL: https://codereview.chromium.org/195163004 git-svn-id: http://skia.googlecode.com/svn/trunk@13744 2bbb7eff-a529-9590-31e7-b0007b416f81
* New version of the bbh shootout.Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | | | | | | | There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree. The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed. Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO. Doing this so I can reasonably compare the new QuadTree implementation. BUG=skia:2242 Committed: http://code.google.com/p/skia/source/detail?r=13736 R=tomhudson@google.com, mtklein@google.com, reed@google.com Author: iancottrell@google.com Review URL: https://codereview.chromium.org/186973005 git-svn-id: http://skia.googlecode.com/svn/trunk@13743 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix radical assumption that 0.5 in double is exactly convertible to float.Gravatar bsalomon@google.com2014-03-11
| | | | | | | | BUG=skia:2181 Review URL: https://codereview.chromium.org/195423002 git-svn-id: http://skia.googlecode.com/svn/trunk@13742 2bbb7eff-a529-9590-31e7-b0007b416f81
* Enable use of distance fields via SkPaint flag.Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | Now that distance field generation is fast enough to make it practical, this makes distances field fonts easily available to anyone who wants to try them out (i.e Chromium). BUG=skia:2173 R=reed@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/193163003 git-svn-id: http://skia.googlecode.com/svn/trunk@13741 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add new module for distance field generation.Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | | | | This improves the speed over the previous method by 10x+, and makes using distance fields practical. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=13729 R=bsalomon@google.com, robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/178543007 git-svn-id: http://skia.googlecode.com/svn/trunk@13740 2bbb7eff-a529-9590-31e7-b0007b416f81
* Handle rrects with one circular corner and three square corners in ↵Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | GrRRectEffect. BUG=skia:2181 R=jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/193263002 git-svn-id: http://skia.googlecode.com/svn/trunk@13739 2bbb7eff-a529-9590-31e7-b0007b416f81
* bench rebaseline after Brian's improvement e5a041cGravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | BUG=skia:2274 NOTRY=true R=bsalomon@google.com TBR=bsalomon@google.com Author: bensong@google.com Review URL: https://codereview.chromium.org/195053003 git-svn-id: http://skia.googlecode.com/svn/trunk@13738 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of New version of the bbh shootout ↵Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/186973005/) Reason for revert: breaking build on at least 12 configurations. Original issue's description: > New version of the bbh shootout. > There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree. > The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed. > Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO. > > Doing this so I can reasonably compare the new QuadTree implementation. > BUG=skia:2242 > > Committed: http://code.google.com/p/skia/source/detail?r=13736 R=tomhudson@google.com, mtklein@google.com, reed@google.com, iancottrell@google.com TBR=iancottrell@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2242 Author: halcanary@google.com Review URL: https://codereview.chromium.org/194903003 git-svn-id: http://skia.googlecode.com/svn/trunk@13737 2bbb7eff-a529-9590-31e7-b0007b416f81
* New version of the bbh shootout.Gravatar commit-bot@chromium.org2014-03-11
| | | | | | | | | | | | | | | | There were a bunch of problems with the existing code, all of which I would of ignored, except it could only benchmark none and rtree. The new version measures the same numbers, in almost exactly the same way, it's the structure over the top of the actual test runner that I changed. Now it only loads the pictures once, it is configurable in which bbh's it runs and how may loops on them it does, it uses standard command line processing, and it does not do so much redundant work so it runs quicker. It is also much easier to understand and change IMHO. Doing this so I can reasonably compare the new QuadTree implementation. BUG=skia:2242 R=tomhudson@google.com, mtklein@google.com, reed@google.com Author: iancottrell@google.com Review URL: https://codereview.chromium.org/186973005 git-svn-id: http://skia.googlecode.com/svn/trunk@13736 2bbb7eff-a529-9590-31e7-b0007b416f81
* plumbing for GPU fast blurGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | BUG=skia:2281 R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/193193002 git-svn-id: http://skia.googlecode.com/svn/trunk@13735 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebase bezier_effect GMs and lingering changed GMs from laggy botsGravatar bsalomon@google.com2014-03-10
| | | | | | Review URL: https://codereview.chromium.org/190663019 git-svn-id: http://skia.googlecode.com/svn/trunk@13734 2bbb7eff-a529-9590-31e7-b0007b416f81
* plumb API for analytic rrect blurGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | BUG=skia:2281 R=bsalomon@google.com, reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/189663012 git-svn-id: http://skia.googlecode.com/svn/trunk@13733 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Add new module for distance field generation. ↵Gravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/178543007/) Reason for revert: multiple compile errors Original issue's description: > Add new module for distance field generation. > > This improves the speed over the previous method by 10x+, and makes using distance fields practical. > > BUG=skia:2173 > > Committed: http://code.google.com/p/skia/source/detail?r=13729 R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2173 Author: halcanary@google.com Review URL: https://codereview.chromium.org/190753015 git-svn-id: http://skia.googlecode.com/svn/trunk@13732 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix no GPU build after r13728Gravatar bsalomon@google.com2014-03-10
| | | | | | Review URL: https://codereview.chromium.org/193163002 git-svn-id: http://skia.googlecode.com/svn/trunk@13731 2bbb7eff-a529-9590-31e7-b0007b416f81
* flag to make kClipToLayer_SaveFlag the default behaviorGravatar reed@google.com2014-03-10
| | | | | | | | | | | | #define SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG to get the old behavior The goal is to remove the feature of saveLayer that allows the canvas to draw outside of the top-most layer. R=robertphillips@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/190723004 git-svn-id: http://skia.googlecode.com/svn/trunk@13730 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add new module for distance field generation.Gravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | This improves the speed over the previous method by 10x+, and makes using distance fields practical. BUG=skia:2173 R=bsalomon@google.com, robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/178543007 git-svn-id: http://skia.googlecode.com/svn/trunk@13729 2bbb7eff-a529-9590-31e7-b0007b416f81
* reorg iteration code in rrects GM, tightly pack rrects drawn in _effect version.Gravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/190953008 git-svn-id: http://skia.googlecode.com/svn/trunk@13728 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: disable image magnifier, for huge UI speedupGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | BUG=skia:2248 NOTREECHECKS=True NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/193073003 git-svn-id: http://skia.googlecode.com/svn/trunk@13727 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: add actual_repo and actual_revision command line optionsGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | | | | So, if you want to see divergences from expectations as of https://code.google.com/p/skia-autogen/source/detail?r=29365 , specify --actuals-revision 29365 This is also handy for testing rebaseline_server performance improvements against a static set of results. BUG=skia:2248 NOTREECHECKS=True NOTRY=True R=borenet@google.com, bsalomon@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/193023002 git-svn-id: http://skia.googlecode.com/svn/trunk@13726 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: fix reload delay when there is client/server clock skewGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | | | Currently, if there is >10 second clock skew between client and server, the client will attempt to reload constantly while the server is still loading results. NOTREECHECKS=True NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/192833003 git-svn-id: http://skia.googlecode.com/svn/trunk@13725 2bbb7eff-a529-9590-31e7-b0007b416f81
* Pulling these out of other reviews so avoid code review clutter.Gravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | R=jvanverth@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/192783002 git-svn-id: http://skia.googlecode.com/svn/trunk@13724 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use bitfield rather than distinct enum types for circular corners in ↵Gravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | RRectEffect. BUG=skia:2181 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/191613003 git-svn-id: http://skia.googlecode.com/svn/trunk@13723 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove legacy ifdef wrapping fast blurGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/192833002 git-svn-id: http://skia.googlecode.com/svn/trunk@13722 2bbb7eff-a529-9590-31e7-b0007b416f81
* Avoid black flashes when resizing debugger window using MSAAGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | | | | | | | | Avoid black flashes when resizing debugger window using MSAA. Clear the stencil buffer always after resize. Also reset the GrContext state when Qt calls resizeGL -- we do not know what GL state Qt changes. Remove setting of white background to SkGLWidget, it is not effective. QGLWidget does not respect the stylesheet. Also move the initial stencil clearing before GrContext is created in order to preserve GrContext state consistent with actual GL state. R=robertphillips@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/192433003 git-svn-id: http://skia.googlecode.com/svn/trunk@13721 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: display how long it took to render the listGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | BUG=skia:2248 NOTREECHECKS=True NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/189833008 git-svn-id: http://skia.googlecode.com/svn/trunk@13720 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "remove flag for legacy copyTo -- call sites have been updated"Gravatar reed@google.com2014-03-10
| | | | | | This reverts commit 85586a92f50942ede4422aca7308b9d8a88469db. git-svn-id: http://skia.googlecode.com/svn/trunk@13719 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factory methods for heap-allocated SkImageFilter objects.Gravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | | | | | This is part of an effort to ensure that all SkPaint effects can only be allocated on the heap. This patch makes the constructors of SkImageFilter and its subclasses non-public and instead provides factory methods for creating these objects on the heap. We temporarily keep constructor of publicly visible classes public behind a flag. BUG=skia:2187 R=scroggo@google.com, mtklein@chromium.org, reed@google.com, senorblanco@google.com, senorblanco@chromium.org, bsalomon@google.com, sugoi@chromium.org, zork@chromium.org Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/182983003 git-svn-id: http://skia.googlecode.com/svn/trunk@13718 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add API for GrContext to recommend rendertarget sample countGravatar commit-bot@chromium.org2014-03-10
| | | | | | | | | | | | | | | | | | | | Add GrContext::getRecommendedSampleCount method that can be used to determine which GPU backend and what exact sample count is recommendeded for a particular render target at particular dpi. Make this initially recommend 4xMSAA for contexts which have NVPR enabled if dpi is 250 or more, 16 if dpi is less than 250 and no MSAA for others. BUG=chromium:347962 R=bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/188403003 git-svn-id: http://skia.googlecode.com/svn/trunk@13717 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-03-09
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13716 2bbb7eff-a529-9590-31e7-b0007b416f81
* hide getTotalClip, so we can eventually remove it Gravatar commit-bot@chromium.org2014-03-08
| | | | | | | | | | | | | | hide getClipType, so we can eventually remove it patch from issue 189443007 TBR=robertphilips@google.com Author: reed@chromium.org Review URL: https://codereview.chromium.org/189883010 git-svn-id: http://skia.googlecode.com/svn/trunk@13715 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-03-08
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13714 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaselines for https://codereview.chromium.org/188693008/Gravatar bsalomon@google.com2014-03-07
| | | | | | Review URL: https://codereview.chromium.org/189913006 git-svn-id: http://skia.googlecode.com/svn/trunk@13713 2bbb7eff-a529-9590-31e7-b0007b416f81
* update ignored-tests.txt to accound for acceptable changes due to r13710Gravatar bsalomon@google.com2014-03-07
| | | | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/189803005 git-svn-id: http://skia.googlecode.com/svn/trunk@13712 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove dead codeGravatar reed@google.com2014-03-07
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13711 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement the clip as 4 or fewer GrEffects when possible.Gravatar commit-bot@chromium.org2014-03-07
| | | | | | | | | | | BUG=skia:2181 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/188693008 git-svn-id: http://skia.googlecode.com/svn/trunk@13710 2bbb7eff-a529-9590-31e7-b0007b416f81
* Once Chromium starts holding on to paths and we can actually reuse cached ↵Gravatar commit-bot@chromium.org2014-03-07
| | | | | | | | | | | | | | | path data (e.g., masks & geometry) we will need a way to preserve that reuse in the skps. This CL begins adding that capability. More analysis & profiling needs to be done before it is always enabled. When enabled it does make the disabled path de-duping test in the Canvas unit test pass. BUG=skia:507 R=bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/190923002 git-svn-id: http://skia.googlecode.com/svn/trunk@13709 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add nvprmsaa4 and nvprmsaa16 configs to bench_picturesGravatar commit-bot@chromium.org2014-03-07
| | | | | | | | | | | | Add nvprmsaa4 and nvprmsaa16 configs to bench_pictures. R=bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/189263012 git-svn-id: http://skia.googlecode.com/svn/trunk@13708 2bbb7eff-a529-9590-31e7-b0007b416f81