diff options
Diffstat (limited to 'src/core')
-rw-r--r-- | src/core/SkBlitRow_D32.cpp | 25 | ||||
-rw-r--r-- | src/core/SkOpts.cpp | 3 | ||||
-rw-r--r-- | src/core/SkOpts.h | 1 |
3 files changed, 6 insertions, 23 deletions
diff --git a/src/core/SkBlitRow_D32.cpp b/src/core/SkBlitRow_D32.cpp index 0f8cbe8104..75330ae337 100644 --- a/src/core/SkBlitRow_D32.cpp +++ b/src/core/SkBlitRow_D32.cpp @@ -8,6 +8,7 @@ #include "SkBlitRow.h" #include "SkBlitMask.h" #include "SkColorPriv.h" +#include "SkOpts.h" #include "SkUtils.h" #define UNROLL @@ -131,32 +132,10 @@ SkBlitRow::Proc32 SkBlitRow::Factory32(unsigned flags) { return proc; } -#include "Sk4px.h" - -// Color32 uses the blend_256_round_alt algorithm from tests/BlendTest.cpp. -// It's not quite perfect, but it's never wrong in the interesting edge cases, -// and it's quite a bit faster than blend_perfect. -// -// blend_256_round_alt is our currently blessed algorithm. Please use it or an analogous one. void SkBlitRow::Color32(SkPMColor dst[], const SkPMColor src[], int count, SkPMColor color) { switch (SkGetPackedA32(color)) { case 0: memmove(dst, src, count * sizeof(SkPMColor)); return; case 255: sk_memset32(dst, color, count); return; } - - // This Sk4px impl works great on other platforms or when we have NEON. -#if defined(SK_CPU_ARM32) && !defined(SK_ARM_HAS_NEON) - if (auto proc = PlatformColor32Proc()) { return proc(dst, src, count, color); } -#endif - - unsigned invA = 255 - SkGetPackedA32(color); - invA += invA >> 7; - SkASSERT(invA < 256); // We've already handled alpha == 0 above. - - Sk16h colorHighAndRound = Sk4px::DupPMColor(color).widenHi() + Sk16h(128); - Sk16b invA_16x(invA); - - Sk4px::MapSrc(count, dst, src, [&](const Sk4px& src4) -> Sk4px { - return (src4 * invA_16x).addNarrowHi(colorHighAndRound); - }); + return SkOpts::blit_row_color32(dst, src, count, color); } diff --git a/src/core/SkOpts.cpp b/src/core/SkOpts.cpp index 69373c0fd1..492fae3a6b 100644 --- a/src/core/SkOpts.cpp +++ b/src/core/SkOpts.cpp @@ -10,6 +10,7 @@ #define SK_OPTS_NS sk_default #include "SkBlitMask_opts.h" +#include "SkBlitRow_opts.h" #include "SkBlurImageFilter_opts.h" #include "SkColorCubeFilter_opts.h" #include "SkFloatingPoint_opts.h" @@ -55,6 +56,8 @@ namespace SkOpts { decltype(blit_mask_d32_a8) blit_mask_d32_a8 = sk_default::blit_mask_d32_a8; + decltype(blit_row_color32) blit_row_color32 = sk_default::blit_row_color32; + // Each Init_foo() is defined in src/opts/SkOpts_foo.cpp. void Init_ssse3(); void Init_sse41(); diff --git a/src/core/SkOpts.h b/src/core/SkOpts.h index 04aa9b1753..d73319a73c 100644 --- a/src/core/SkOpts.h +++ b/src/core/SkOpts.h @@ -44,6 +44,7 @@ namespace SkOpts { extern bool (*fill_block_dimensions)(SkTextureCompressor::Format, int* x, int* y); extern void (*blit_mask_d32_a8)(SkPMColor*, size_t, const SkAlpha*, size_t, SkColor, int, int); + extern void (*blit_row_color32)(SkPMColor*, const SkPMColor*, int, SkPMColor); // This function is an optimized version of SkColorCubeFilter::filterSpan extern void (*color_cube_filter_span)(const SkPMColor[], |