diff options
author | 2017-03-22 12:05:03 -0400 | |
---|---|---|
committer | 2017-03-22 16:06:18 +0000 | |
commit | d3b65972aad96453ff4510caa3e25a2b847c6d1e (patch) | |
tree | b79341c2266afe3b529aa1f4cd80c97b9a9e71ae /tools | |
parent | 30a38ff737c61799b0f36d2e6ba412f7e612f617 (diff) |
Mark overridden destructors with 'override' and remove 'virtual'
This silences a new warning in clang 5.0
Change-Id: Ieb5b75a6ffed60107c3fd16075d2ecfd515b55e8
Reviewed-on: https://skia-review.googlesource.com/10006
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/debugger/SkDebugCanvas.h | 2 | ||||
-rw-r--r-- | tools/debugger/SkDrawCommand.h | 12 | ||||
-rw-r--r-- | tools/gpu/gl/GLTestContext.h | 2 | ||||
-rw-r--r-- | tools/gpu/gl/debug/GrBufferObj.h | 2 | ||||
-rw-r--r-- | tools/gpu/gl/debug/GrFrameBufferObj.h | 2 | ||||
-rw-r--r-- | tools/gpu/gl/debug/GrTextureObj.h | 2 |
6 files changed, 11 insertions, 11 deletions
diff --git a/tools/debugger/SkDebugCanvas.h b/tools/debugger/SkDebugCanvas.h index 0f2ae514dd..7c6a0f4d54 100644 --- a/tools/debugger/SkDebugCanvas.h +++ b/tools/debugger/SkDebugCanvas.h @@ -26,7 +26,7 @@ class SkDebugCanvas : public SkCanvas { public: SkDebugCanvas(int width, int height); - virtual ~SkDebugCanvas(); + ~SkDebugCanvas() override; void toggleFilter(bool toggle) { fFilter = toggle; } diff --git a/tools/debugger/SkDrawCommand.h b/tools/debugger/SkDrawCommand.h index e23eed138c..4004b3bc2c 100644 --- a/tools/debugger/SkDrawCommand.h +++ b/tools/debugger/SkDrawCommand.h @@ -533,7 +533,7 @@ class SkDrawPointsCommand : public SkDrawCommand { public: SkDrawPointsCommand(SkCanvas::PointMode mode, size_t count, const SkPoint pts[], const SkPaint& paint); - virtual ~SkDrawPointsCommand() { delete [] fPts; } + ~SkDrawPointsCommand() override { delete [] fPts; } void execute(SkCanvas* canvas) const override; bool render(SkCanvas* canvas) const override; Json::Value toJSON(UrlDataManager& urlDataManager) const override; @@ -552,7 +552,7 @@ class SkDrawTextCommand : public SkDrawCommand { public: SkDrawTextCommand(const void* text, size_t byteLength, SkScalar x, SkScalar y, const SkPaint& paint); - virtual ~SkDrawTextCommand() { delete [] fText; } + ~SkDrawTextCommand() override { delete [] fText; } void execute(SkCanvas* canvas) const override; Json::Value toJSON(UrlDataManager& urlDataManager) const override; static SkDrawTextCommand* fromJSON(Json::Value& command, UrlDataManager& urlDataManager); @@ -571,7 +571,7 @@ class SkDrawPosTextCommand : public SkDrawCommand { public: SkDrawPosTextCommand(const void* text, size_t byteLength, const SkPoint pos[], const SkPaint& paint); - virtual ~SkDrawPosTextCommand() { delete [] fPos; delete [] fText; } + ~SkDrawPosTextCommand() override { delete [] fPos; delete [] fText; } void execute(SkCanvas* canvas) const override; Json::Value toJSON(UrlDataManager& urlDataManager) const override; static SkDrawPosTextCommand* fromJSON(Json::Value& command, UrlDataManager& urlDataManager); @@ -589,7 +589,7 @@ class SkDrawTextOnPathCommand : public SkDrawCommand { public: SkDrawTextOnPathCommand(const void* text, size_t byteLength, const SkPath& path, const SkMatrix* matrix, const SkPaint& paint); - virtual ~SkDrawTextOnPathCommand() { delete [] fText; } + ~SkDrawTextOnPathCommand() override { delete [] fText; } void execute(SkCanvas* canvas) const override; Json::Value toJSON(UrlDataManager& urlDataManager) const override; static SkDrawTextOnPathCommand* fromJSON(Json::Value& command, UrlDataManager& urlDataManager); @@ -628,7 +628,7 @@ class SkDrawPosTextHCommand : public SkDrawCommand { public: SkDrawPosTextHCommand(const void* text, size_t byteLength, const SkScalar xpos[], SkScalar constY, const SkPaint& paint); - virtual ~SkDrawPosTextHCommand() { delete [] fXpos; delete [] fText; } + ~SkDrawPosTextHCommand() override { delete [] fXpos; delete [] fText; } void execute(SkCanvas* canvas) const override; Json::Value toJSON(UrlDataManager& urlDataManager) const override; static SkDrawPosTextHCommand* fromJSON(Json::Value& command, UrlDataManager& urlDataManager); @@ -759,7 +759,7 @@ private: class SkSaveLayerCommand : public SkDrawCommand { public: SkSaveLayerCommand(const SkCanvas::SaveLayerRec&); - virtual ~SkSaveLayerCommand(); + ~SkSaveLayerCommand() override; void execute(SkCanvas* canvas) const override; Json::Value toJSON(UrlDataManager& urlDataManager) const override; static SkSaveLayerCommand* fromJSON(Json::Value& command, UrlDataManager& urlDataManager); diff --git a/tools/gpu/gl/GLTestContext.h b/tools/gpu/gl/GLTestContext.h index 09dce05685..9bd10395f7 100644 --- a/tools/gpu/gl/GLTestContext.h +++ b/tools/gpu/gl/GLTestContext.h @@ -18,7 +18,7 @@ namespace sk_gpu_test { */ class GLTestContext : public TestContext { public: - virtual ~GLTestContext(); + ~GLTestContext() override; virtual GrBackend backend() override { return kOpenGL_GrBackend; } virtual GrBackendContext backendContext() override { diff --git a/tools/gpu/gl/debug/GrBufferObj.h b/tools/gpu/gl/debug/GrBufferObj.h index c91606da92..d0217b2ffa 100644 --- a/tools/gpu/gl/debug/GrBufferObj.h +++ b/tools/gpu/gl/debug/GrBufferObj.h @@ -25,7 +25,7 @@ public: , fSize(0) , fUsage(GR_GL_STATIC_DRAW) { } - virtual ~GrBufferObj() { + ~GrBufferObj() override { delete[] fDataPtr; } diff --git a/tools/gpu/gl/debug/GrFrameBufferObj.h b/tools/gpu/gl/debug/GrFrameBufferObj.h index 3bd642f460..9003127a6c 100644 --- a/tools/gpu/gl/debug/GrFrameBufferObj.h +++ b/tools/gpu/gl/debug/GrFrameBufferObj.h @@ -27,7 +27,7 @@ public: , fStencilBuffer(nullptr) { } - virtual ~GrFrameBufferObj() { + ~GrFrameBufferObj() override { fColorBuffer = nullptr; fDepthBuffer = nullptr; fStencilBuffer = nullptr; diff --git a/tools/gpu/gl/debug/GrTextureObj.h b/tools/gpu/gl/debug/GrTextureObj.h index e2908386cb..5532723969 100644 --- a/tools/gpu/gl/debug/GrTextureObj.h +++ b/tools/gpu/gl/debug/GrTextureObj.h @@ -22,7 +22,7 @@ public: : GrFBBindableObj() { } - virtual ~GrTextureObj() { + ~GrTextureObj() override { GrAlwaysAssert(0 == fTextureUnitReferees.count()); } |