diff options
| author |  mtklein <mtklein@chromium.org> | 2016-02-19 14:27:14 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-02-19 14:27:14 -0800 |
| commit | cbf897802b41d61dc35d6db0552d8d9604945fdc (patch) | |
| tree | 72e6f95b3ae85c470e88ddc52ac81c2fe678a93c /tools | |
| parent | 365bbff200a58a12a38631e53639c12a878b1fea (diff) | |
DM: remove unnecessary use of std::function
This draw_to_canvas() function doesn't need the power of std::function.
This skips a copy or two, which is nice, and seems to clear
up most of my MSAN problems. Why? I do not know.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
Review URL: https://codereview.chromium.org/1718633002
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/dm_flags.json | 12 | ||||
| -rwxr-xr-x | tools/dm_flags.py | 8 |
2 files changed, 12 insertions, 8 deletions
diff --git a/tools/dm_flags.json b/tools/dm_flags.json index 5950dfad22..1191ac9342 100644 --- a/tools/dm_flags.json +++ b/tools/dm_flags.json @@ -2076,8 +2076,20 @@ "--config", "565", "8888", + "gpu", + "upright-matrix-8888", + "upright-matrix-gpu", + "sp-8888", + "twice-8888", + "2ndpic-8888", + "remote-8888", + "remote_cache-8888", + "msaa16", "pdf", "pdf_poppler", + "serialize-8888", + "tiles_rt-8888", + "pic-8888", "--src", "tests", "gm", diff --git a/tools/dm_flags.py b/tools/dm_flags.py index 747598fa46..db09eee9a2 100755 --- a/tools/dm_flags.py +++ b/tools/dm_flags.py @@ -77,14 +77,6 @@ def get_args(bot): if 'GalaxyS3' in bot: configs.append('gpudft') - if 'MSAN' in bot: - configs = [ - '565', - '8888', - 'pdf', - 'pdf_poppler', - ] - args.append('--config') args.extend(configs) |