diff options
| author |  mtklein <mtklein@chromium.org> | 2014-07-09 07:52:32 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-07-09 07:52:32 -0700 |
| commit | bd7746da97e389c1068333117407b213b378f9db (patch) | |
| tree | 46c0f9612d9802bd49b68ac37e73a8f1638bcd4c /tools | |
| parent | ecce60bad6e3b7a72e1eba820bc3be15d39a1c21 (diff) | |
Remove ability for Release code to call getRefCnt() or getWeakRefCnt().
These getRefCnt() methods are not thread safe, so Skia code should not
be calling them. unique() is fine.
SkDEBUG code (SkASSERTs) can still call getRefCnt() / getWeakRefCnt().
This adds tools/RefCntIs.{h,cpp}, which lets tests make their assertions in
both debug and release modes.
BUG=skia:2726
Committed: https://skia.googlesource.com/skia/+/4ae94ffce5ecf1b71cb5e295b68bf4ec9e697443
R=senorblanco@chromium.org, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/378643003
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/tsan.supp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tools/tsan.supp b/tools/tsan.supp index 8c95e7a9c5..f687014040 100644 --- a/tools/tsan.supp +++ b/tools/tsan.supp @@ -25,6 +25,3 @@ race:is_lcd_supported race:RefFCI race:SkString race:SkPDF - -# This calls SkRefCnt::getRefCnt(), which is not thread safe. skia:2726 -race:SkImageFilter::filterImage |