diff options
| author |  Cary Clark <caryclark@skia.org> | 2018-06-14 15:34:14 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-14 19:57:34 +0000 |
| commit | a74019072281169b99ea13134ff6bc3ca9bdf7a4 (patch) | |
| tree | 34cac5876e278f692bf4e95a78cae84dfb46a213 /tools | |
| parent | 0acb79eb2a63c404257889890a4ace0efc022ef9 (diff) | |
do not mistake locals for methods
bookmaker parsed xxx(xxx) as a method but in this case
fXxx(xxx) was a local initialization. Look for 'f' followed
by an upper case letter to know the difference.
TBR=csmartdalton@google.com
Bug: skia:6898
Change-Id: Ie0138d9412bc6c06915af81a5b83cbd7e83ebef6
Reviewed-on: https://skia-review.googlesource.com/135041
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/bookmaker/includeParser.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/bookmaker/includeParser.cpp b/tools/bookmaker/includeParser.cpp index 16c99af520..2a1e03b79e 100644 --- a/tools/bookmaker/includeParser.cpp +++ b/tools/bookmaker/includeParser.cpp @@ -2027,6 +2027,9 @@ bool IncludeParser::parseObject(Definition* child, Definition* markupDef) { fAttrDeprecated = &*tokenIter; break; } + if ('f' == previousToken.fStart[0] && isupper(previousToken.fStart[1])) { + break; + } if (Bracket::kPound == child->fParent->fBracket && KeyWord::kIf == child->fParent->fKeyWord) { // TODO: this will skip methods named defined() -- for the |