diff options
| author |  mtklein <mtklein@chromium.org> | 2015-11-18 09:56:28 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-11-18 09:56:28 -0800 |
| commit | 988adddd48322bfa3e3cb0c017cfce71fbbf1123 (patch) | |
| tree | 30faaa91cb80045309c815e5a06ca6e2fa630d34 /tools | |
| parent | 835c1b69a2b4238b63ad2daf0698c4fbb5fc944f (diff) | |
Fix UB in SkDivBits
DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no.
This turns numer into a uint32_t to make those defined, and adds a few notes.
x >= 0 is always true for unsigned x, so we needed a few small logic refactors.
BUG=skia:3562
Review URL: https://codereview.chromium.org/1455163004
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/dm_flags.json | 4 | ||||
| -rwxr-xr-x | tools/dm_flags.py | 5 |
2 files changed, 1 insertions, 8 deletions
diff --git a/tools/dm_flags.json b/tools/dm_flags.json index be6bc3d747..3c557865dc 100644 --- a/tools/dm_flags.json +++ b/tools/dm_flags.json @@ -1221,9 +1221,7 @@ "_", "image", "_", - "interlaced3.png", - "--match", - "~Math" + "interlaced3.png" ], "Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind": [ "--matrix", diff --git a/tools/dm_flags.py b/tools/dm_flags.py index 7c901891ca..5341b221da 100755 --- a/tools/dm_flags.py +++ b/tools/dm_flags.py @@ -169,11 +169,6 @@ def get_args(bot): if 'Valgrind' in bot: # skia:3021 match.append('~Threaded') - # skia:3562 - if ('TSAN' in bot or - 'Test-Mac10.8-Clang-MacMini4.1-CPU-SSE4-x86_64-Release' in bot): - match.append('~Math') - if 'GalaxyS3' in bot: # skia:1699 match.append('~WritePixels') |