aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar Hal Canary <halcanary@google.com>2018-02-02 13:24:41 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-02-02 19:00:19 +0000
commit553ca26136492fa31e08e9eed2c263e8af85d5e2 (patch)
tree19e276267401e6be23ce2758fc4beebae2cc079e /tools
parent7b046312edd9219ba8e66c255f5347c000b69ee1 (diff)
SkQP: stop using global across jni calls
BIG=skia:7572 Change-Id: I9231e5264305eb871e31ec7b9d23c042135bbefc Reviewed-on: https://skia-review.googlesource.com/103022 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/skqp/jni/org_skia_skqp_SkQPRunner.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/skqp/jni/org_skia_skqp_SkQPRunner.cpp b/tools/skqp/jni/org_skia_skqp_SkQPRunner.cpp
index 2203888062..b59af6a8d4 100644
--- a/tools/skqp/jni/org_skia_skqp_SkQPRunner.cpp
+++ b/tools/skqp/jni/org_skia_skqp_SkQPRunner.cpp
@@ -169,6 +169,7 @@ void Java_org_skia_skqp_SkQP_nInit(JNIEnv* env, jobject object, jobject assetMan
gUnitTests = gm_runner::GetUnitTests();
jassert(env, gUnitTests.size() > 0);
gStringClass = env->FindClass("java/lang/String");
+ jassert(env, gStringClass);
constexpr char stringArrayType[] = "[Ljava/lang/String;";
env->SetObjectField(object, env->GetFieldID(clazz, "mBackends", stringArrayType),
@@ -218,7 +219,9 @@ jobjectArray Java_org_skia_skqp_SkQP_nExecuteUnitTest(JNIEnv* env,
if (errors.size() == 0) {
return nullptr;
}
- jobjectArray array = env->NewObjectArray(errors.size(), gStringClass, nullptr);
+ jclass stringClass = env->FindClass("java/lang/String");
+ jassert(env, stringClass);
+ jobjectArray array = env->NewObjectArray(errors.size(), stringClass, nullptr);
for (unsigned i = 0; i < errors.size(); ++i) {
set_string_array_element(env, array, errors[i].c_str(), i);
}