aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar jcgregorio <jcgregorio@google.com>2014-11-13 08:06:40 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2014-11-13 08:06:40 -0800
commit3b27adef0a52f6d321fdee7412ef69e7a7284bcc (patch)
tree44edab4ef6bc06603d150d35575cbef69833c82e /tools
parent1c6e7571d40e31247609fd7469f8422018304310 (diff)
Revert of Make nanobench and dm be usable from Chromium build (patchset #5 id:80001 of https://codereview.chromium.org/657373002/)
Reason for revert: Causing breakages on Mac build. Original issue's description: > Make nanobench and dm be usable from Chromium build > > Move the app logic for each app as follows: > > <app>.cpp -- the file which contains main(). Embedders that compile > their own apps, such as ios shell, upcoming Chromium dm etc, do not use this. > > <app>_main.cpp -- the main logic of the Skia test application. This will be > used by Skia -compiled apps as well as embedder -compiled apps. > > <app>_main.h -- the API for the main logic. This will be > used by Skia -compiled apps as well as embedder -compiled apps. > > This way (the upcoming) Chromium dm can setup its Chromium-specific setup > in custom main(), and then call dm_main(), without the need of any > SK_BUILD_FOR_XXXX defines controlling whether the tool defines main or not. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/c092d3bdab5f723576cc0346cea3ee282a9cb444 TBR=mtklein@chromium.org,mtklein@google.com,borenet@google.com,kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/724073002
Diffstat (limited to 'tools')
-rw-r--r--tools/iOSShell.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/iOSShell.cpp b/tools/iOSShell.cpp
index 99d5ebd29a..8656e645aa 100644
--- a/tools/iOSShell.cpp
+++ b/tools/iOSShell.cpp
@@ -13,8 +13,6 @@
#include "SkCommonFlags.h"
#include "SkGraphics.h"
#include "SkWindow.h"
-#include "dm.h"
-#include "nanobench.h"
#include "sk_tool_utils.h"
//////////////////////////////////////////////////////////////////////////////
@@ -58,6 +56,9 @@ void ShellWindow::onSizeChange() {
DEFINE_bool(dm, false, "run dm");
DEFINE_bool(nanobench, false, "run nanobench");
+int nanobench_main();
+int dm_main();
+
IOS_launch_type set_cmd_line_args(int argc, char *argv[], const char* resourceDir) {
SkCommandLineFlags::Parse(argc, argv);
SetResourcePath(resourceDir);