diff options
| author |  Mike Klein <mtklein@chromium.org> | 2017-07-24 14:27:18 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-07-24 19:22:05 +0000 |
| commit | 3bf0042caa550b1f0cd56633ed66174141f2728f (patch) | |
| tree | 2e3d4e204b66e138114292d8ba98a87a2ba26232 /tools/trace/SkEventTracingPriv.h | |
| parent | 89d9d95570227533e4a87b41e5a7ed9fad4dd04a (diff) | |
ok, basic tracing support
This doesn't do anything in the default process-per-task mode, because
those child tasks exit using _exit(), which doesn't trigger the event
tracer destructor to flush.
I don't remember exactly why I exit with _exit(), so I'm going to have
to follow up on that. But written this way as I think I'm at least
initializing the tracing in the right place for each process for the
future.
In threaded (-j -1) and serial (-j 0) modes, everything seems to work
great.
I'm also thinking I might add a tracer like the SkDebugf tracer but
using ok_log(), which handles interlaced logging from concurrent tasks
better than vanilla SkDebugf.
Example:
ninja -C out ok; and out/ok gm 8888 filter:search=fontmgr_bounds trace -j -1
Change-Id: Ia3cdad930ce65e6fd12fa74f3fb00894e35138d3
Reviewed-on: https://skia-review.googlesource.com/26350
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'tools/trace/SkEventTracingPriv.h')
| -rw-r--r-- | tools/trace/SkEventTracingPriv.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/trace/SkEventTracingPriv.h b/tools/trace/SkEventTracingPriv.h index aa3ee6d4d9..fb7b2f3fa5 100644 --- a/tools/trace/SkEventTracingPriv.h +++ b/tools/trace/SkEventTracingPriv.h @@ -11,9 +11,10 @@ #include "SkMutex.h" /** - * Construct and install an SkEventTracer, based on the 'trace' command line argument. + * Construct and install an SkEventTracer, based on the mode, + * defaulting to the --trace command line argument. */ -void initializeEventTracingForTools(); +void initializeEventTracingForTools(const char* mode = nullptr); /** * Helper class used by internal implementations of SkEventTracer to manage categories. |