diff options
author | bsalomon <bsalomon@google.com> | 2014-10-08 04:45:09 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-08 04:45:10 -0700 |
commit | 10805961ce424868e8315e00f6dbeeaa62d466ac (patch) | |
tree | 87fbeec3c52176c1794c25ae639adb38c6bcfa60 /tools/timer | |
parent | a5ee45ce9daba663c28ba5f6634af93702aecd96 (diff) |
Revert of Make the Sk GL context class an abstract base class (patchset #4 id:60001 of https://codereview.chromium.org/630843002/)
Reason for revert:
nanobech failing on Android
Original issue's description:
> Make the Sk GL context class an abstract base class
>
> Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before,
> it depended on ifdefs to implement the platform dependent polymorphism. Move
> the logic to subclasses of the various platform implementations.
>
> This a step to enable Skia embedders to compile dm and bench_pictures. The
> concrete goal is to support running these test apps with Chromium command buffer.
>
> With this change, Chromium can implement its own version of SkGLNativeContext
> that uses command buffer, and host the implementation in its own repository.
>
> Implements the above by renaming the SkGLContextHelper to SkGLContext and
> removing the unneeded SkGLNativeContext. Also removes
> SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused:
> no use in Skia code, and no tests.
>
> BUG=skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/a90ed4e83897b45d6331ee4c54e1edd4054de9a8
TBR=kkinnunen@nvidia.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2992
Review URL: https://codereview.chromium.org/639793002
Diffstat (limited to 'tools/timer')
-rw-r--r-- | tools/timer/GpuTimer.cpp | 4 | ||||
-rw-r--r-- | tools/timer/GpuTimer.h | 6 | ||||
-rw-r--r-- | tools/timer/Timer.cpp | 2 | ||||
-rw-r--r-- | tools/timer/Timer.h | 4 |
4 files changed, 8 insertions, 8 deletions
diff --git a/tools/timer/GpuTimer.cpp b/tools/timer/GpuTimer.cpp index 0fdd999922..aac10a3b07 100644 --- a/tools/timer/GpuTimer.cpp +++ b/tools/timer/GpuTimer.cpp @@ -6,10 +6,10 @@ * found in the LICENSE file. */ #include "GpuTimer.h" -#include "gl/SkGLContext.h" +#include "gl/SkGLContextHelper.h" #include "gl/GrGLUtil.h" -GpuTimer::GpuTimer(const SkGLContext* glctx) : fContext(glctx) { +GpuTimer::GpuTimer(const SkGLContextHelper* glctx) : fContext(glctx) { if (fContext) { fContext->ref(); fContext->makeCurrent(); diff --git a/tools/timer/GpuTimer.h b/tools/timer/GpuTimer.h index da1fdab5c0..2100312a21 100644 --- a/tools/timer/GpuTimer.h +++ b/tools/timer/GpuTimer.h @@ -7,18 +7,18 @@ #ifndef GpuTimer_DEFINED #define GpuTimer_DEFINED -class SkGLContext; +class SkGLContextHelper; class GpuTimer { public: - GpuTimer(const SkGLContext*); + GpuTimer(const SkGLContextHelper*); ~GpuTimer(); void start(); double end(); private: unsigned fQuery; int fStarted; - const SkGLContext* fContext; + const SkGLContextHelper* fContext; bool fSupported; }; diff --git a/tools/timer/Timer.cpp b/tools/timer/Timer.cpp index a9f04afe75..4f3fc85cff 100644 --- a/tools/timer/Timer.cpp +++ b/tools/timer/Timer.cpp @@ -6,7 +6,7 @@ */ #include "Timer.h" -Timer::Timer(SkGLContext* gl) +Timer::Timer(SkGLContextHelper* gl) : fCpu(-1.0) , fWall(-1.0) , fTruncatedCpu(-1.0) diff --git a/tools/timer/Timer.h b/tools/timer/Timer.h index 81d1ca50ef..15c93f5603 100644 --- a/tools/timer/Timer.h +++ b/tools/timer/Timer.h @@ -21,7 +21,7 @@ #include "GpuTimer.h" #endif -class SkGLContext; +class SkGLContextHelper; /** * SysTimers and GpuTimers are implemented orthogonally. @@ -34,7 +34,7 @@ class SkGLContext; */ class Timer { public: - explicit Timer(SkGLContext* gl = NULL); + explicit Timer(SkGLContextHelper* gl = NULL); void start(); void truncatedEnd(); |