diff options
author | Brian Osman <brianosman@google.com> | 2017-02-08 10:47:28 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-02-08 17:34:05 +0000 |
commit | f750fbcb699fff2bdd264969515fc4045a1248be (patch) | |
tree | a540a926801c5a2b1beccd674236c5e33795f5e1 /tools/sk_tool_utils.cpp | |
parent | b782627376c0db63ba42684eb901ff006db7a2b0 (diff) |
Simplify viewer's handling of backbuffer surface and color space
WindowContext still supports color spaces, but not other color
types. Any off-screen rendering is the app's responsibility.
This change also adds (working) F16 support to viewer. Note that
the previous 10-bit and FP16 support in WindowContext was broken.
There was no code to push the off-screen canvas to the window.
If you ever made it to the unreachable off-screen code path in
createSurface, it would have simply stopped drawing.
The decision to limit the window's gamut to sRGB is mostly driven
by my desire to add real-time editing of gamut. This design lets
us do that, without tearing down and rebuilding the window for
every change. An application could still supply a different gamut
via setDisplayParams and render directly to the back buffer with
proper color correction.
BUG=skia:
Change-Id: I94df35c7a42faee396009acc83683e40bb3c284d
Reviewed-on: https://skia-review.googlesource.com/8153
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Diffstat (limited to 'tools/sk_tool_utils.cpp')
-rw-r--r-- | tools/sk_tool_utils.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/sk_tool_utils.cpp b/tools/sk_tool_utils.cpp index 0383897bd8..f8236bfa45 100644 --- a/tools/sk_tool_utils.cpp +++ b/tools/sk_tool_utils.cpp @@ -201,6 +201,7 @@ const char* colortype_name(SkColorType ct) { case kRGB_565_SkColorType: return "RGB_565"; case kRGBA_8888_SkColorType: return "RGBA_8888"; case kBGRA_8888_SkColorType: return "BGRA_8888"; + case kRGBA_F16_SkColorType: return "RGBA_F16"; default: SkASSERT(false); return "unexpected colortype"; |