diff options
| author |  caryclark <caryclark@google.com> | 2015-10-22 07:23:52 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-10-22 07:23:52 -0700 |
| commit | ed0935a28a29af7d3b16ac8d9365f291a335c6bd (patch) | |
| tree | f16bcde492ecfdbf19fcfcec9713c42e52326cb1 /tools/pathops_sorter.htm | |
| parent | 7f53819ea9f8317b4bae1d54239b5b4c18240ef0 (diff) | |
Reland of path ops: fix conic weight and partial coincidence (patchset #1 id:1 of https://codereview.chromium.org/1408923003/ )
Reason for revert:
suppressions have landed in chrome
Original issue's description:
> Revert of path ops: fix conic weight and partial coincidence (patchset #5 id:80001 of https://codereview.chromium.org/1413763002/ )
>
> Reason for revert:
> path ops change breaks svg clipping layout tests -- conic is now more accurate, changing edge of circle in clip
>
> These need to be rebaselined
>
> svg/clip-path/clip-path-child-clipped.svg
> svg/clip-path/clip-path-nonzero.svg
> svg/clip-path/clip-path-evenodd-nonzero.svg
> svg/clip-path/clip-path-nonzero-evenodd.svg
>
> Original issue's description:
> > The remaining 1m skp bugs are asserts that can be harmlessly
> > suppressed and bugs around conics.
> >
> > The conic calculation for a subdivided w was just wrong.
> >
> > Also added debugging to template intersection to initialize
> > reused structures and dump additional data.
> >
> > TBR=reed@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/ef33b1e739b23a1201100ff17a572da85b03d9af
>
> TBR=
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/f428df1be3e96d3f8970d0f7f415b862f7da5404
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1407003016
Diffstat (limited to 'tools/pathops_sorter.htm')
| -rw-r--r-- | tools/pathops_sorter.htm | 23 |
1 files changed, 19 insertions, 4 deletions
diff --git a/tools/pathops_sorter.htm b/tools/pathops_sorter.htm index ed93ad687c..a86353b5f9 100644 --- a/tools/pathops_sorter.htm +++ b/tools/pathops_sorter.htm @@ -6,9 +6,22 @@ <title></title> <div style="height:0"> -<div id="cubics"> -{{{231.80000305175781, 2084.800048828125}, {255.60000610351562, 2084.800048828125}, {275, 2065.39990234375}, {275, 2041.5999755859375}}}, -{{{275, 2041.5999755859375}, {275, 2084.800048828125}, {231.80000305175781, 2084.800048828125}}, 0.707107008}, +<div id="conics"> +{{{78.000016756859424, 4590.0127645689281}, {78, 4590.005859375}}}, +{{{78.000022914349017, 4590.0165822692597}, {78.000005725317905, 4590.0082887743229}}}, +{{{{83, 4595}, {78.008674621582031, 4595}, {78, 4590.005859375}}}, 0.707720578f}, +{{{{84, 4596}, {78, 4596}, {78, 4590}}}, 0.707106769f}, +</div> + +<div id="conicLines"> +{{{78.000016756859424, 4590.0127645689281}, {78, 4590.005859375}}}, +{{{78.000022914349017, 4590.0165822692597}, {78.000005725317905, 4590.0082887743229}}}, +</div> + +<div id="thisopp"> +{{{78.000016756859424, 4590.0127645689281}, {78, 4590.005859375}}}, +{{{{84, 4596}, {78, 4596}, {78, 4590}}}, 0.707106769f}, +{{{78.0000055,4590.00813) (78.0000367,4590.02099 </div> </div> @@ -16,7 +29,9 @@ <script type="text/javascript"> var testDivs = [ -cubics, +conics, +conicLines, +thisopp, ]; var decimal_places = 3; |