diff options
| author |  Mike Klein <mtklein@chromium.org> | 2016-11-14 08:39:39 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2016-11-14 14:07:54 +0000 |
| commit | bde64e438ae24f9f1c90fff5e1a12e71db5742de (patch) | |
| tree | afd220ff026c71f389fef2a2428a6ea047049733 /tools/gpu/GrContextFactory.cpp | |
| parent | e7bd81d0a8e41432c9ad62e452742813b21e9923 (diff) | |
Mark inline functions in SkTypes.h as static.
If these are not marked static (or SK_FORCE_INLINE) they become extremely dangerous to use from files built with different optimization flags than the baseline. The One Definition Rule becomes trivially easy to violate, and the linker can easily pick a CPU-specific version of the function.
TBR=reed@google.com
BUG=chromium:664864
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4752
Change-Id: If3044a32229db1a1e3a8b83aace6047d92b36d05
Reviewed-on: https://skia-review.googlesource.com/4752
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'tools/gpu/GrContextFactory.cpp')
0 files changed, 0 insertions, 0 deletions