diff options
author | Eric Boren <borenet@google.com> | 2018-06-22 10:13:52 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-22 14:38:28 +0000 |
commit | 5e0909776e81803dd140255fb89fa19e3b8d158f (patch) | |
tree | d848f174fa2744b328d8980a8ed04960e6445f1c /tools/copyright | |
parent | 5741a5ba7f369a85cb1f93466cb710bcb0bb49d5 (diff) |
Fix pylint check in presubmit
This fixes the unexpected behavior where we only run pylint over the
affected Python files *unless* there are affected Python files which we
have explicitly blacklisted, in which case we run pylint over ALL Python
files in every subdirectory of the Skia checkout, including repos in
DEPS.
- Added buildtools and common to the blacklist.
- Changed to run pylint over all Python files in Skia, like
presubmit_support expects.
- Fix existing pylint problems.
Bug: skia:
Change-Id: Ife1321f5ae5eaff2a28cc14c99a82a0716c12677
Reviewed-on: https://skia-review.googlesource.com/137126
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Diffstat (limited to 'tools/copyright')
-rw-r--r-- | tools/copyright/main.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/copyright/main.py b/tools/copyright/main.py index 24969a7ac5..e428448d21 100644 --- a/tools/copyright/main.py +++ b/tools/copyright/main.py @@ -67,7 +67,7 @@ def GetAllFilepaths(root_directory): @param root_directory root directory within which to find all files """ path_list = [] - for dirpath, dirnames, filenames in os.walk(root_directory): + for dirpath, _, filenames in os.walk(root_directory): for filename in filenames: path_list.append(os.path.abspath(os.path.join(dirpath, filename))) return path_list |