aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/bookmaker/selfCheck.cpp
diff options
context:
space:
mode:
authorGravatar Cary Clark <caryclark@skia.org>2018-02-01 09:37:32 -0500
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-02-01 15:09:17 +0000
commit08895c48144cedaf81006803afe4a5a2becfdb92 (patch)
tree395b9eece35410bc75115e16a2c6b86e6bf35de8 /tools/bookmaker/selfCheck.cpp
parent4dab72f60664b50f66cdd1b26a59bfa873e899f7 (diff)
auto table generation
Replace manually entered summary tables with ones that are populated and sorted by bookmaker. This introduces a slight regression for anonymous enums but fixes a lot of bugs and omissions. The format is #Topic somethingTopical #Populate ## where somethingTopical is one of Subtopics, Constructors, Constants, Classes_and_Structs, Members, Member_Functions, and Related_Functions. Fix the bad formatting in SkCanvas reference. The #Error tag was was corrupting the markdown table. Remove the tag and replace it with #NoExample. Next up: revise self-check to know about populated topics. TBR=caryclark@google.com Docs-Preview: https://skia.org/?cl=102080 Bug: skia:6898 Change-Id: Idef5d1c14c740c18a81d6a5106182788dd2a09e1 Reviewed-on: https://skia-review.googlesource.com/102080 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
Diffstat (limited to 'tools/bookmaker/selfCheck.cpp')
-rw-r--r--tools/bookmaker/selfCheck.cpp15
1 files changed, 2 insertions, 13 deletions
diff --git a/tools/bookmaker/selfCheck.cpp b/tools/bookmaker/selfCheck.cpp
index f30a5824bc..fd8ef59fa1 100644
--- a/tools/bookmaker/selfCheck.cpp
+++ b/tools/bookmaker/selfCheck.cpp
@@ -66,7 +66,7 @@ protected:
// should be 'creators' instead of constructors?
bool checkConstructorsSummary() {
for (auto& rootChild : fRoot->fChildren) {
- if (!this->isStructOrClass(rootChild)) {
+ if (!rootChild->isStructOrClass()) {
continue;
}
auto& cs = rootChild;
@@ -357,7 +357,7 @@ protected:
const Definition* classOrStruct() {
for (auto& rootChild : fRoot->fChildren) {
- if (this->isStructOrClass(rootChild)) {
+ if (rootChild->isStructOrClass()) {
return rootChild;
}
}
@@ -460,17 +460,6 @@ protected:
return true;
}
- bool isStructOrClass(const Definition* definition) const {
- if (MarkType::kStruct != definition->fMarkType &&
- MarkType::kClass != definition->fMarkType) {
- return false;
- }
- if (string::npos != definition->fFileName.find("undocumented.bmh")) {
- return false;
- }
- return true;
- }
-
private:
const BmhParser& fBmhParser;
RootDefinition* fRoot;