diff options
| author |  Cary Clark <caryclark@skia.org> | 2017-09-21 12:31:06 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-09-21 16:50:10 +0000 |
| commit | 6fc5041adbc05b7dc8c48d44492ae86aac30e203 (patch) | |
| tree | 654664af2cc4507ffe0a9b1847314f10560d2e1f /tools/bookmaker/bookmaker.cpp | |
| parent | 8a02b0bca0905e6e151c1584b923ae288b7c5af4 (diff) | |
feedback
feedback from include review
Docs-Preview: https://skia.org/?cl=49260
Bug: skia: 6898
Change-Id: Ic60980dfe53d14fd8c6973ef2f4dabb6b650cdd8
Reviewed-on: https://skia-review.googlesource.com/49260
Commit-Queue: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
Diffstat (limited to 'tools/bookmaker/bookmaker.cpp')
| -rw-r--r-- | tools/bookmaker/bookmaker.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/bookmaker/bookmaker.cpp b/tools/bookmaker/bookmaker.cpp index ac1a4a9939..2ec987b333 100644 --- a/tools/bookmaker/bookmaker.cpp +++ b/tools/bookmaker/bookmaker.cpp @@ -1119,8 +1119,10 @@ bool BmhParser::addDefinition(const char* defStart, bool hasEnd, MarkType markTy case MarkType::kTime: case MarkType::kVolatile: case MarkType::kWidth: - if (hasEnd) { + if (hasEnd && MarkType::kAnchor != markType) { return this->reportError<bool>("one liners omit end element"); + } else if (!hasEnd && MarkType::kAnchor == markType) { + return this->reportError<bool>("anchor line must have end element last"); } fMarkup.emplace_front(markType, defStart, fLineCount, fParent); definition = &fMarkup.front(); |