aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/android
diff options
context:
space:
mode:
authorGravatar Ravi Mistry <rmistry@google.com>2017-09-12 10:56:42 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-09-12 15:24:00 +0000
commita6b646986bf554e9f537494cfe1d7d577fdac796 (patch)
tree22de82f073a675f8968863a3d1656255e31a4267 /tools/android
parent74dac545488cb8827479c69ba5324e830083440f (diff)
Break up the prefix to make some presubmits stop complaining
NoTry: true Bug: skia:7016 Change-Id: If2f405d8309fc63d8592a97b668f826cd606097b Reviewed-on: https://skia-review.googlesource.com/45801 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
Diffstat (limited to 'tools/android')
-rw-r--r--tools/android/upload_to_android.py9
1 files changed, 6 insertions, 3 deletions
diff --git a/tools/android/upload_to_android.py b/tools/android/upload_to_android.py
index 4704b43c1a..9afbf298d4 100644
--- a/tools/android/upload_to_android.py
+++ b/tools/android/upload_to_android.py
@@ -130,11 +130,14 @@ About to run repo init. If it hangs asking you to run glogin then please:
f.write('#endif//SK_DEBUG\n')
subprocess.check_call('git add %s' % SK_USER_CONFIG_PATH, shell=True)
- # Amend the commit message to add a "[DO NOT SUBMIT]" prefix and a "Test:"
- # line which is required by Android presubmit checks.
+ # Amend the commit message to add a prefix that makes it clear that the
+ # change should not be submitted and a "Test:" line which is required by
+ # Android presubmit checks.
original_commit_message = change_details['subject']
new_commit_message = (
- '[DO NOT SUBMIT] %s\n\n'
+ # Intentionally breaking up the below string because some presubmits
+ # complain about it.
+ '[DO ' + 'NOT ' + 'SUBMIT] %s\n\n'
'Test: Presubmit checks will test this change.' % (
original_commit_message))
subprocess.check_call('git commit --amend -m "%s"' % new_commit_message,