diff options
author | scroggo <scroggo@chromium.org> | 2015-08-12 07:24:13 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-12 07:24:13 -0700 |
commit | b427db1d457a083f2652756a453fbb91bc6a7447 (patch) | |
tree | 7f75aa76f1b488fb97a5fa4222c1a04a2906a5ae /tools/CrashHandler.h | |
parent | 4b5472bdb05404681388b5c5a4962f24a76e088b (diff) |
Consolidate SkCodec functions for handling rewind
Previously, many of our codec implementations followed the same
pattern (often in a function named handleRewind):
switch (this->rewindIfNeeded()) {
case CouldNotRewind:
return CouldNotRewind;
case NoRewindNecessary:
// keep going
break;
case Rewound:
<re-read header etc>
break;
}
In this CL, remove the enum, and put the piece that happens in the
Rewound case into a virtual function, onRewind. rewindIfNeeded now
contains the common pieces from various functions named handleRewind.
In SkBmpCodec, add a function that returns whether the BMP is in ICO,
so it can have a common implementation for onRewind.
BUG=skia:3257
Review URL: https://codereview.chromium.org/1288483002
Diffstat (limited to 'tools/CrashHandler.h')
0 files changed, 0 insertions, 0 deletions