aboutsummaryrefslogtreecommitdiffhomepage
path: root/third_party
diff options
context:
space:
mode:
authorGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-01-09 17:37:38 +0000
committerGravatar commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>2014-01-09 17:37:38 +0000
commit9a907fa0d3ac573af2f5b45bd41af76c9035777f (patch)
treeaccf1380a8085cc5193a0108bbe12abf5cd9cbcd /third_party
parent18b75e54ab64763615e09761fcaeb3f439835f59 (diff)
Fix Mac fontconfig build
The Mac fontconfig just #defines the cache directory, which works fine if fontconfig never has to look up any fonts (the case until now). If it has to actually find fonts from the disk, the cache directory and config directory need to be properly defined as well as running fc-cache to populate the cache directory. Populating the cache directory can take some time, but should only happen on a clean build. To remove this extra time, we have to not build poppler on Mac, which can now be accomplished with GYP_DEFINES="skia_mac_poppler=0" R=bungeman@google.com, epoger@google.com Author: vandebo@chromium.org Review URL: https://codereview.chromium.org/113203003 git-svn-id: http://skia.googlecode.com/svn/trunk@12994 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'third_party')
-rw-r--r--third_party/fontconfig/README.chromium11
-rw-r--r--third_party/fontconfig/config/mac/config.h.template (renamed from third_party/fontconfig/config/mac/config.h)6
-rwxr-xr-xthird_party/fontconfig/process-template.py51
3 files changed, 64 insertions, 4 deletions
diff --git a/third_party/fontconfig/README.chromium b/third_party/fontconfig/README.chromium
index f9ea5b62b3..07bc5f59f8 100644
--- a/third_party/fontconfig/README.chromium
+++ b/third_party/fontconfig/README.chromium
@@ -33,9 +33,14 @@ third_party/fontconfig/config:
fc-lang/fclang.h
src/fcobjshash.h
-On Linux and Mac, these are the files generated by ./configure, with no
-additional flags.
+On Mac, these are the files generated by
+ ./configure --with-add-fonts=/System/Library/Fonts,/Library/Fonts
+config/mac/config.h.template then has a section added to the top:
+
++/* Manually added template defines */
++#define FC_CACHEDIR "@FC_CACHEDIR@"
++#define FONTCONFIG_PATH "@FONTCONFIG_PATH@"
+
On Windows, the configuration files were from
http://comments.gmane.org/gmane.comp.fonts.fontconfig/4438
(fontconfig development list).
-
diff --git a/third_party/fontconfig/config/mac/config.h b/third_party/fontconfig/config/mac/config.h.template
index 963ede8494..3eea946a19 100644
--- a/third_party/fontconfig/config/mac/config.h
+++ b/third_party/fontconfig/config/mac/config.h.template
@@ -1,6 +1,10 @@
/* config.h. Generated from config.h.in by configure. */
/* config.h.in. Generated from configure.ac by autoheader. */
+/* Manually added template defines */
+#define FC_CACHEDIR "@FC_CACHEDIR@"
+#define FONTCONFIG_PATH "@FONTCONFIG_PATH@"
+
/* Define if building universal (internal helper macro) */
/* #undef AC_APPLE_UNIVERSAL_BUILD */
@@ -11,7 +15,7 @@
/* #undef ENABLE_LIBXML2 */
/* Additional font directories */
-#define FC_ADD_FONTS "yes"
+#define FC_ADD_FONTS "/System/Library/Fonts,/Library/Fonts"
/* Architecture prefix to use for cache file names */
/* #undef FC_ARCHITECTURE */
diff --git a/third_party/fontconfig/process-template.py b/third_party/fontconfig/process-template.py
new file mode 100755
index 0000000000..5ea60bdb8a
--- /dev/null
+++ b/third_party/fontconfig/process-template.py
@@ -0,0 +1,51 @@
+#!/usr/bin/python
+
+# Copyright 2014 Google Inc.
+#
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# A simple template processing script.
+
+import argparse
+import os
+import sys
+
+parser = argparse.ArgumentParser()
+parser.add_argument('-i', '--input')
+parser.add_argument('-o', '--output')
+parser.add_argument(
+ '-k', '--keyword_substitution', action='append', nargs=2,
+ metavar=('KEY', 'VALUE'), help='Changes KEY to VALUE in the template.')
+parser.add_argument(
+ '-p', '--path_substitution', action='append', nargs=2,
+ metavar=('KEY', 'PATH'),
+ help='Makes PATH absolute then changes KEY to PATH in the template.')
+
+args = parser.parse_args()
+
+input = sys.stdin
+if args.input:
+ input = open(args.input, 'r')
+
+output = sys.stdout
+if args.output:
+ output = open(args.output, 'w')
+
+path_subs = None
+if args.path_substitution:
+ path_subs = [
+ [sub[0], os.path.abspath(sub[1])] for sub in args.path_substitution
+ ]
+
+for line in input:
+ if args.keyword_substitution:
+ for (key, value) in args.keyword_substitution:
+ line = line.replace(key, value)
+ if path_subs:
+ for (key, path) in path_subs:
+ line = line.replace(key, path)
+ output.write(line)
+
+input.close()
+output.close()