diff options
author | mtklein <mtklein@chromium.org> | 2016-07-19 08:25:00 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-07-19 08:25:00 -0700 |
commit | f037d48e29000554abcd117445c4249071bb9fb3 (patch) | |
tree | 8492f6981c971f486cf29958620604aa6bcb2275 /third_party/third_party.gni | |
parent | 916e02a6d004af5b83a636d1507bfdf2da8543ce (diff) |
GN: refactor third_party/gni
This fixes the build on Linux (dep on third_party:zlib -> third_party/zlib).
I've moved declare_args() {} back to each .gn file... seems like args want
to be as local as possible in GN land.
Additionally, refactor all the common third_party config and warning flag
changes into a template, third_party. This lets it all live together in a
.gni: at head unwanted_configs can be in a .gni (it's just a variable) but
config("no_warnings") (and thus third_party_configs) cannot, as configs
cannot be part of .gni files.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163653002
Review-Url: https://codereview.chromium.org/2163653002
Diffstat (limited to 'third_party/third_party.gni')
-rw-r--r-- | third_party/third_party.gni | 24 |
1 files changed, 15 insertions, 9 deletions
diff --git a/third_party/third_party.gni b/third_party/third_party.gni index 813ee385f3..ede698c4af 100644 --- a/third_party/third_party.gni +++ b/third_party/third_party.gni @@ -3,13 +3,19 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -declare_args() { -} +template("third_party") { + source_set(target_name) { + forward_variables_from(invoker, "*") + + # Warnings are just noise if we're not maintaining the code. + cflags = [ "-w" ] -# Chrome's GN environment sets up a bunch of default configs we don't need/want here. -unwanted_configs = [ - "//build/config/clang:extra_warnings", - "//build/config/clang:find_bad_constructs", - "//build/config/compiler:chromium_code", - "//build/config:feature_flags", -] + # Chrome's GN environment sets up a bunch of default configs we don't need/want here. + configs -= [ + "//build/config/clang:extra_warnings", + "//build/config/clang:find_bad_constructs", + "//build/config/compiler:chromium_code", + "//build/config:feature_flags", + ] + } +} |