diff options
| author |  reed <reed@google.com> | 2016-09-22 14:12:46 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2016-09-22 14:12:47 -0700 |
| commit | d14df7c700bf77c8c42c791ca7a865c1bbc96679 (patch) | |
| tree | 553e6ab4662bc2737c7fccc8f90ba780726c853b /tests | |
| parent | ae6e4869c94596eb3bf5069888b32ab06199aec0 (diff) | |
document.close from bool to void
Nothing meaningful is returned, it is inconsistent with the bulk of the rest of skia's api. The C api is waiting on this change as well.
Required chrome CL: https://codereview.chromium.org/2355343003/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002
Review-Url: https://codereview.chromium.org/2354403002
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/AnnotationTest.cpp | 4 | ||||
| -rw-r--r-- | tests/CanvasTest.cpp | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/tests/AnnotationTest.cpp b/tests/AnnotationTest.cpp index 0a9dfeac18..cc2fd1f912 100644 --- a/tests/AnnotationTest.cpp +++ b/tests/AnnotationTest.cpp @@ -50,7 +50,7 @@ DEF_TEST(Annotation_PdfLink, reporter) { sk_sp<SkData> data(SkData::MakeWithCString("http://www.gooogle.com")); SkAnnotateRectWithURL(canvas, r, data.get()); - REPORTER_ASSERT(reporter, doc->close()); + doc->close(); sk_sp<SkData> out = outStream.detachAsData(); const char* rawOutput = (const char*)out->data(); @@ -68,7 +68,7 @@ DEF_TEST(Annotation_NamedDestination, reporter) { sk_sp<SkData> data(SkData::MakeWithCString("example")); SkAnnotateNamedDestination(canvas, p, data.get()); - REPORTER_ASSERT(reporter, doc->close()); + doc->close(); sk_sp<SkData> out = outStream.detachAsData(); const char* rawOutput = (const char*)out->data(); diff --git a/tests/CanvasTest.cpp b/tests/CanvasTest.cpp index 59642975b4..2be83f3d2f 100644 --- a/tests/CanvasTest.cpp +++ b/tests/CanvasTest.cpp @@ -515,8 +515,6 @@ static void TestPdfDevice(skiatest::Reporter* reporter, const TestData& d, Canva REPORTER_ASSERT(reporter, canvas); step->setAssertMessageFormat(kPdfAssertMessageFormat); step->draw(canvas, d, reporter); - - REPORTER_ASSERT(reporter, doc->close()); } /* |