diff options
author | 2013-10-10 13:51:19 +0000 | |
---|---|---|
committer | 2013-10-10 13:51:19 +0000 | |
commit | b295fb6ff3222453912dfcb7a1ea5184d40014b5 (patch) | |
tree | e15812e8b5c505bce63d6a3b277be97456ecc23c /tests | |
parent | f29c3802899c3e1e285a44140eb32cfa329764dc (diff) |
Change SkImageFilter's cropRect from SkIRect to a CropRect struct, containing an SkRect and flags indicating which parameters are set.
NOTE: this will require SK_CROP_RECT_IS_INT=1 to be set in Chrome until Blink has been updated to use SkImageFilter::CropRect. Include https://codereview.chromium.org/26528002/ with the Skia roll.
Note also that SK_CROP_RECT_IS_INT is a temporary measure until all call sites in Blink have been updated to use SkRect.
R=reed@google.com
Review URL: https://codereview.chromium.org/26371002
git-svn-id: http://skia.googlecode.com/svn/trunk@11692 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'tests')
-rw-r--r-- | tests/ImageFilterTest.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp index 99b5a72866..4165f2f750 100644 --- a/tests/ImageFilterTest.cpp +++ b/tests/ImageFilterTest.cpp @@ -67,7 +67,7 @@ public: return SkColorFilterImageFilter::Create(filter, input); } - static SkImageFilter* make_grayscale(SkImageFilter* input = NULL, const SkIRect* cropRect = NULL) { + static SkImageFilter* make_grayscale(SkImageFilter* input = NULL, const SkImageFilter::CropRect* cropRect = NULL) { SkScalar matrix[20]; memset(matrix, 0, 20 * sizeof(SkScalar)); matrix[0] = matrix[5] = matrix[10] = SkFloatToScalar(0.2126f); @@ -109,7 +109,11 @@ public: { // Check that a color filter image filter with a crop rect cannot // be expressed as a color filter. +#ifdef SK_CROP_RECT_IS_INT SkIRect cropRect = SkIRect::MakeXYWH(0, 0, 100, 100); +#else + SkImageFilter::CropRect cropRect(SkRect::MakeXYWH(0, 0, 100, 100)); +#endif SkAutoTUnref<SkImageFilter> grayWithCrop(make_grayscale(NULL, &cropRect)); REPORTER_ASSERT(reporter, false == grayWithCrop->asColorFilter(NULL)); } |