diff options
| author |  Cary Clark <caryclark@skia.org> | 2018-04-17 09:30:14 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-04-17 13:50:13 +0000 |
| commit | a7651567ca7e5462de993f1b23d681c6171bcccf (patch) | |
| tree | 11d2f27bb78b83528b7e3918a6d558dd5ee6b452 /tests | |
| parent | 8954d097c35296d2b33293e65552cc3de39c5d2a (diff) | |
yet another path is rect exploit
This one accumulates the othershoot when all four sides
have the same direction, and the final side when closed
should cause the overshoot to be ignored.
Docs-Preview: https://skia.org/?cl=121787
Bug: 824145,skia:7792
Change-Id: I71ea0fcdd0f03a4fcac224b57220c65c321112f6
Reviewed-on: https://skia-review.googlesource.com/121787
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/PathTest.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp index 38b5bf7424..817aa82b75 100644 --- a/tests/PathTest.cpp +++ b/tests/PathTest.cpp @@ -5003,4 +5003,13 @@ DEF_TEST(Path_isRect, reporter) { SkPoint points29[] = { {75, 75}, {150, 75}, {150, 150}, {75, 150}, {75, 250}, {75, 75} }; path = makePath2(points29, verbs29, SK_ARRAY_COUNT(verbs29)); REPORTER_ASSERT(reporter, !path.isRect(&rect, nullptr, nullptr)); + // isolated from skbug.com/7792#c31 + SkPath::Verb verbs31[] = { SkPath::kMove_Verb, SkPath::kLine_Verb, SkPath::kLine_Verb, + SkPath::kLine_Verb, SkPath::kLine_Verb, SkPath::kMove_Verb, + SkPath::kClose_Verb }; + SkPoint points31[] = { {75, 75}, {150, 75}, {150, 150}, {75, 150}, {75, 10}, {75, 75} }; + path = makePath2(points31, verbs31, SK_ARRAY_COUNT(verbs31)); + REPORTER_ASSERT(reporter, path.isRect(&rect, nullptr, nullptr)); + compare.set(&points31[0], 4); + REPORTER_ASSERT(reporter, rect == compare); } |