diff options
author | Hal Canary <halcanary@google.com> | 2017-04-19 13:17:59 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-04-25 13:12:54 +0000 |
commit | a294be24040262d530c54dc01fc322132c5d2a24 (patch) | |
tree | 9ca2c11a82977a53124e4f4f31bee5885528c37f /tests | |
parent | 600effbdc7d8fb1cfb1b9dcecf785a2e42cc1cc3 (diff) |
SkDiscardableMemoryPool: modernize
* Use unique_ptr, sk_sp, SkAutoFree, using.
* Rely on thread-safe static global initializion.
Change-Id: I7c14e0e57622163b1b81b97a218b816fe6d02926
Reviewed-on: https://skia-review.googlesource.com/13818
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/CachedDataTest.cpp | 2 | ||||
-rw-r--r-- | tests/DiscardableMemoryPoolTest.cpp | 2 | ||||
-rw-r--r-- | tests/DiscardableMemoryTest.cpp | 4 | ||||
-rw-r--r-- | tests/ImageCacheTest.cpp | 2 | ||||
-rw-r--r-- | tests/SkResourceCacheTest.cpp | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/tests/CachedDataTest.cpp b/tests/CachedDataTest.cpp index b2d47855bd..fe7bb5f547 100644 --- a/tests/CachedDataTest.cpp +++ b/tests/CachedDataTest.cpp @@ -72,7 +72,7 @@ static SkCachedData* test_locking(skiatest::Reporter* reporter, * and when the cache is. */ DEF_TEST(CachedData, reporter) { - sk_sp<SkDiscardableMemoryPool> pool(SkDiscardableMemoryPool::Create(1000)); + sk_sp<SkDiscardableMemoryPool> pool(SkDiscardableMemoryPool::Make(1000)); for (int useDiscardable = 0; useDiscardable <= 1; ++useDiscardable) { const size_t size = 100; diff --git a/tests/DiscardableMemoryPoolTest.cpp b/tests/DiscardableMemoryPoolTest.cpp index 79b257d1b0..b8fd6d712a 100644 --- a/tests/DiscardableMemoryPoolTest.cpp +++ b/tests/DiscardableMemoryPoolTest.cpp @@ -10,7 +10,7 @@ DEF_TEST(DiscardableMemoryPool, reporter) { sk_sp<SkDiscardableMemoryPool> pool( - SkDiscardableMemoryPool::Create(1, nullptr)); + SkDiscardableMemoryPool::Make(1, nullptr)); pool->setRAMBudget(3); REPORTER_ASSERT(reporter, 0 == pool->getRAMUsed()); diff --git a/tests/DiscardableMemoryTest.cpp b/tests/DiscardableMemoryTest.cpp index 5d2d6b9e1e..e0125ec21b 100644 --- a/tests/DiscardableMemoryTest.cpp +++ b/tests/DiscardableMemoryTest.cpp @@ -52,8 +52,8 @@ DEF_TEST(DiscardableMemory_global, reporter) { } DEF_TEST(DiscardableMemory_nonglobal, reporter) { - std::unique_ptr<SkDiscardableMemoryPool> pool( - SkDiscardableMemoryPool::Create(1024, /* mutex = */ nullptr)); + sk_sp<SkDiscardableMemoryPool> pool( + SkDiscardableMemoryPool::Make(1024, /* mutex = */ nullptr)); std::unique_ptr<SkDiscardableMemory> dm(pool->create(kTestStringLength)); test_dm(reporter, dm.get(), true); } diff --git a/tests/ImageCacheTest.cpp b/tests/ImageCacheTest.cpp index 6d1e1ac86c..9472388225 100644 --- a/tests/ImageCacheTest.cpp +++ b/tests/ImageCacheTest.cpp @@ -121,7 +121,7 @@ DEF_TEST(ImageCache, reporter) { test_cache(reporter, cache, true); } { - sk_sp<SkDiscardableMemoryPool> pool(SkDiscardableMemoryPool::Create(defLimit, nullptr)); + sk_sp<SkDiscardableMemoryPool> pool(SkDiscardableMemoryPool::Make(defLimit, nullptr)); gPool = pool.get(); SkResourceCache cache(pool_factory); test_cache(reporter, cache, true); diff --git a/tests/SkResourceCacheTest.cpp b/tests/SkResourceCacheTest.cpp index 708c8d4d83..7a9c8760e5 100644 --- a/tests/SkResourceCacheTest.cpp +++ b/tests/SkResourceCacheTest.cpp @@ -127,7 +127,7 @@ DEF_TEST(BitmapCache_discarded_bitmap, reporter) { testBitmapCache_discarded_bitmap(reporter, &cache, nullptr); } { - sk_sp<SkDiscardableMemoryPool> pool(SkDiscardableMemoryPool::Create(byteLimit, nullptr)); + sk_sp<SkDiscardableMemoryPool> pool(SkDiscardableMemoryPool::Make(byteLimit, nullptr)); gPool = pool.get(); SkResourceCache::DiscardableFactory factory = pool_factory; SkResourceCache cache(factory); |