diff options
author | reed <reed@google.com> | 2016-03-18 10:00:32 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-18 10:00:32 -0700 |
commit | 9fbee18f691a0afed1e38a851048ce06063505ed (patch) | |
tree | cd647dad4bae251bbbadea7fdd85b8a4b22cecc7 /tests | |
parent | 1195260e22fc2e9c92b435491d4d19108a20df5c (diff) |
switch patheffects over to sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813553005
Review URL: https://codereview.chromium.org/1813553005
Diffstat (limited to 'tests')
-rw-r--r-- | tests/AsADashTest.cpp | 6 | ||||
-rw-r--r-- | tests/DashPathEffectTest.cpp | 6 | ||||
-rw-r--r-- | tests/DrawPathTest.cpp | 8 | ||||
-rw-r--r-- | tests/GpuDrawPathTest.cpp | 5 | ||||
-rw-r--r-- | tests/PictureTest.cpp | 8 |
5 files changed, 15 insertions, 18 deletions
diff --git a/tests/AsADashTest.cpp b/tests/AsADashTest.cpp index fc4efecbb2..2077b66425 100644 --- a/tests/AsADashTest.cpp +++ b/tests/AsADashTest.cpp @@ -12,7 +12,7 @@ #include "SkCornerPathEffect.h" DEF_TEST(AsADashTest_noneDash, reporter) { - SkAutoTUnref<SkPathEffect> pe(SkCornerPathEffect::Create(1.0)); + sk_sp<SkPathEffect> pe(SkCornerPathEffect::Make(1.0)); SkPathEffect::DashInfo info; SkPathEffect::DashType dashType = pe->asADash(&info); @@ -22,7 +22,7 @@ DEF_TEST(AsADashTest_noneDash, reporter) { DEF_TEST(AsADashTest_nullInfo, reporter) { SkScalar inIntervals[] = { 4.0, 2.0, 1.0, 3.0 }; const SkScalar phase = 2.0; - SkAutoTUnref<SkPathEffect> pe(SkDashPathEffect::Create(inIntervals, 4, phase)); + sk_sp<SkPathEffect> pe(SkDashPathEffect::Make(inIntervals, 4, phase)); SkPathEffect::DashType dashType = pe->asADash(nullptr); REPORTER_ASSERT(reporter, SkPathEffect::kDash_DashType == dashType); @@ -33,7 +33,7 @@ DEF_TEST(AsADashTest_usingDash, reporter) { SkScalar totalIntSum = 10.0; const SkScalar phase = 2.0; - SkAutoTUnref<SkPathEffect> pe(SkDashPathEffect::Create(inIntervals, 4, phase)); + sk_sp<SkPathEffect> pe(SkDashPathEffect::Make(inIntervals, 4, phase)); SkPathEffect::DashInfo info; diff --git a/tests/DashPathEffectTest.cpp b/tests/DashPathEffectTest.cpp index fa2395ef75..7e832cdd66 100644 --- a/tests/DashPathEffectTest.cpp +++ b/tests/DashPathEffectTest.cpp @@ -18,7 +18,7 @@ DEF_TEST(DashPathEffectTest_crbug_348821, r) { SkScalar intervals[] = { 1.76934361e+36f, 2.80259693e-45f }; // Values from bug. const int count = 2; SkScalar phase = SK_ScalarInfinity; // Used to force a nonsense effect. - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, count, phase)); + sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, count, phase)); REPORTER_ASSERT(r, dash == nullptr); } @@ -28,7 +28,7 @@ DEF_TEST(DashPathEffectTest_asPoints, r) { const SkScalar intervals[] = { 1.0f, 1.0f }; const int count = 2; - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, count, 0.0f)); + sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, count, 0.0f)); SkRect cull = SkRect::MakeWH(1.0f, 1.0f); @@ -90,7 +90,7 @@ DEF_TEST(DashPath_bug4871, r) { path.close(); SkScalar intervals[2] = { 1, 1 }; - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, 2, 0)); + sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, 2, 0)); SkPaint paint; paint.setStyle(SkPaint::kStroke_Style); diff --git a/tests/DrawPathTest.cpp b/tests/DrawPathTest.cpp index e9aa4499d9..8c46b100b3 100644 --- a/tests/DrawPathTest.cpp +++ b/tests/DrawPathTest.cpp @@ -192,7 +192,7 @@ static void test_crbug_140642() { */ const SkScalar vals[] = { 27734, 35660, 2157846850.0f, 247 }; - SkAutoTUnref<SkPathEffect> dontAssert(SkDashPathEffect::Create(vals, 4, -248.135982067f)); + auto dontAssert = SkDashPathEffect::Make(vals, 4, -248.135982067f); } static void test_crbug_124652() { @@ -202,7 +202,7 @@ static void test_crbug_124652() { large values can "swamp" small ones. */ SkScalar intervals[2] = {837099584, 33450}; - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, 2, -10)); + auto dontAssert = SkDashPathEffect::Make(intervals, 2, -10); } static void test_bigcubic() { @@ -281,7 +281,7 @@ static void test_infinite_dash(skiatest::Reporter* reporter) { path.lineTo(5000000, 0); SkScalar intervals[] = { 0.2f, 0.2f }; - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, 2, 0)); + sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, 2, 0)); SkPath filteredPath; SkPaint paint; @@ -301,7 +301,7 @@ static void test_crbug_165432(skiatest::Reporter* reporter) { path.lineTo(10000000, 0); SkScalar intervals[] = { 0.5f, 0.5f }; - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, 2, 0)); + sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, 2, 0)); SkPaint paint; paint.setStyle(SkPaint::kStroke_Style); diff --git a/tests/GpuDrawPathTest.cpp b/tests/GpuDrawPathTest.cpp index d454d9bb67..1f9361ad1e 100644 --- a/tests/GpuDrawPathTest.cpp +++ b/tests/GpuDrawPathTest.cpp @@ -49,7 +49,7 @@ static void test_drawPathEmpty(skiatest::Reporter*, SkCanvas* canvas) { } static void fill_and_stroke(SkCanvas* canvas, const SkPath& p1, const SkPath& p2, - SkPathEffect* effect) { + sk_sp<SkPathEffect> effect) { SkPaint paint; paint.setAntiAlias(true); paint.setPathEffect(effect); @@ -73,8 +73,7 @@ static void test_drawSameRectOvals(skiatest::Reporter*, SkCanvas* canvas) { fill_and_stroke(canvas, oval1, oval2, nullptr); const SkScalar intervals[] = { 1, 1 }; - SkAutoTUnref<SkPathEffect> dashEffect(SkDashPathEffect::Create(intervals, 2, 0)); - fill_and_stroke(canvas, oval1, oval2, dashEffect); + fill_and_stroke(canvas, oval1, oval2, SkDashPathEffect::Make(intervals, 2, 0)); } DEF_GPUTEST_FOR_ALL_CONTEXTS(GpuDrawPath, reporter, context) { diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp index 0ac50d97f9..58a08ecc34 100644 --- a/tests/PictureTest.cpp +++ b/tests/PictureTest.cpp @@ -144,7 +144,7 @@ static void test_gpu_veto(skiatest::Reporter* reporter) { path.lineTo(50, 50); SkScalar intervals[] = { 1.0f, 1.0f }; - SkAutoTUnref<SkPathEffect> dash(SkDashPathEffect::Create(intervals, 2, 0)); + sk_sp<SkPathEffect> dash(SkDashPathEffect::Make(intervals, 2, 0)); SkPaint paint; paint.setStyle(SkPaint::kStroke_Style); @@ -233,8 +233,7 @@ static void test_gpu_veto(skiatest::Reporter* reporter) { { SkPaint paint; SkScalar intervals [] = { 10, 20 }; - SkPathEffect* pe = SkDashPathEffect::Create(intervals, 2, 25); - paint.setPathEffect(pe)->unref(); + paint.setPathEffect(SkDashPathEffect::Make(intervals, 2, 25)); SkPoint points [2] = { { 0, 0 }, { 100, 0 } }; @@ -250,8 +249,7 @@ static void test_gpu_veto(skiatest::Reporter* reporter) { { SkPaint paint; SkScalar intervals [] = { 10, 20 }; - SkPathEffect* pe = SkDashPathEffect::Create(intervals, 2, 25); - paint.setPathEffect(pe)->unref(); + paint.setPathEffect(SkDashPathEffect::Make(intervals, 2, 25)); for (int i = 0; i < 50; ++i) { canvas->drawRect(SkRect::MakeWH(10, 10), paint); |