diff options
| author |  fmalita <fmalita@chromium.org> | 2014-11-20 20:44:04 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-11-20 20:44:04 -0800 |
| commit | 8ebaa7171246eb5b3a7dd65ba42ef42a888508d7 (patch) | |
| tree | 53caf01479f56733a51197521047592b8ffdb762 /tests | |
| parent | 60b24d0df70392a89dfd7d4a8ae58411812c3067 (diff) | |
Revert of SkCanvas::clear() should call down to devices even when the clip is empty. (patchset #1 id:1 of https://codereview.chromium.org/735233003/)
Reason for revert:
Chrome unit_tests failures on Mac & Win, blocking the roll: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/5613
Original issue's description:
> SkCanvas::clear() should call down to devices even when the clip is empty.
>
> SkDrawIter had a lovely, completely unused, option for this. Oversight?
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/378e70d8e561b72a904286ea231946f5c8345b9a
TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/748733002
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/CanvasTest.cpp | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/tests/CanvasTest.cpp b/tests/CanvasTest.cpp index 58be9dadb2..5437d5b2da 100644 --- a/tests/CanvasTest.cpp +++ b/tests/CanvasTest.cpp @@ -795,17 +795,3 @@ DEF_TEST(Canvas, reporter) { test_newraster(reporter); } - -// Make sure SkCanvas passes clear() calls down to its devices even when they're clipped out. -DEF_TEST(Canvas_clear, reporter) { - SkBitmap bm; - bm.allocN32Pixels(1,1); - - SkCanvas canvas(bm); - canvas.clear(SK_ColorRED); - REPORTER_ASSERT(reporter, SK_ColorRED == bm.getColor(0,0)); - - canvas.clipRect(SkRect::MakeEmpty()); - canvas.clear(SK_ColorGREEN); - REPORTER_ASSERT(reporter, SK_ColorGREEN == bm.getColor(0,0)); -} |