diff options
author | herb <herb@google.com> | 2016-06-10 13:01:27 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-06-10 13:01:27 -0700 |
commit | 7df9e4a87d84415391c167ea54cd389d4b423c2d (patch) | |
tree | 15314082e379437acef1acace3ae222cba6fb14f /tests | |
parent | a233620f9ce9d94272619ecf94962319faec693a (diff) |
Make SkBlitter hierarchy explicit about what needs to be implemented.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2053823002
Review-Url: https://codereview.chromium.org/2053823002
Diffstat (limited to 'tests')
-rw-r--r-- | tests/BlitMaskClip.cpp | 4 | ||||
-rw-r--r-- | tests/FillPathTest.cpp | 43 |
2 files changed, 27 insertions, 20 deletions
diff --git a/tests/BlitMaskClip.cpp b/tests/BlitMaskClip.cpp index 8ba2cea3e0..21fe562368 100644 --- a/tests/BlitMaskClip.cpp +++ b/tests/BlitMaskClip.cpp @@ -24,6 +24,10 @@ public: REPORTER_ASSERT(fReporter, right > fBounds.fLeft && right <= fBounds.fRight); } + void blitAntiH(int x, int y, const SkAlpha antialias[], const int16_t runs[]) override { + SkDEBUGFAIL("blitAntiH not implemented"); + } + private: SkIRect fBounds; skiatest::Reporter* fReporter; diff --git a/tests/FillPathTest.cpp b/tests/FillPathTest.cpp index cc8d329652..1f14d4f7f3 100644 --- a/tests/FillPathTest.cpp +++ b/tests/FillPathTest.cpp @@ -12,34 +12,37 @@ #include "Test.h" struct FakeBlitter : public SkBlitter { - FakeBlitter() - : m_blitCount(0) - {} + FakeBlitter() + : m_blitCount(0) { } - virtual void blitH(int x, int y, int width) { - m_blitCount++; - } + void blitH(int x, int y, int width) override { + m_blitCount++; + } - int m_blitCount; + void blitAntiH(int x, int y, const SkAlpha antialias[], const int16_t runs[]) override { + SkDEBUGFAIL("blitAntiH not implemented"); + } + + int m_blitCount; }; // http://code.google.com/p/skia/issues/detail?id=87 // Lines which is not clipped by boundary based clipping, // but skipped after tessellation, should be cleared by the blitter. DEF_TEST(FillPathInverse, reporter) { - FakeBlitter blitter; - SkIRect clip; - SkPath path; - int height = 100; - int width = 200; - int expected_lines = 5; - clip.set(0, height - expected_lines, width, height); - path.moveTo(0.0f, 0.0f); - path.quadTo(SkIntToScalar(width/2), SkIntToScalar(height), + FakeBlitter blitter; + SkIRect clip; + SkPath path; + int height = 100; + int width = 200; + int expected_lines = 5; + clip.set(0, height - expected_lines, width, height); + path.moveTo(0.0f, 0.0f); + path.quadTo(SkIntToScalar(width/2), SkIntToScalar(height), SkIntToScalar(width), 0.0f); - path.close(); - path.setFillType(SkPath::kInverseWinding_FillType); - SkScan::FillPath(path, clip, &blitter); + path.close(); + path.setFillType(SkPath::kInverseWinding_FillType); + SkScan::FillPath(path, clip, &blitter); - REPORTER_ASSERT(reporter, blitter.m_blitCount == expected_lines); + REPORTER_ASSERT(reporter, blitter.m_blitCount == expected_lines); } |