diff options
author | 2014-08-07 11:33:59 -0700 | |
---|---|---|
committer | 2014-08-07 11:33:59 -0700 | |
commit | 7b624480654222a72e05deb1b3cc7d1849ce043d (patch) | |
tree | ef238afcbb74ea687eb4d0d391672876314d3826 /tests | |
parent | 9f2ed6d4d85464bda359d04e646629d96b757362 (diff) |
Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/444093002/)
Reason for revert:
Breaking DM
Original issue's description:
> - Add astcbitmap to gm slides
> - Add additional ASTC formats
> - Add astc image decoder files
>
> Committed: https://skia.googlesource.com/skia/+/2fc05823fed4b9649338f3029cd1ba05ef49a02f
R=reed@google.com, robertphillips@google.com, halcanary@google.com
TBR=halcanary@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/447343002
Diffstat (limited to 'tests')
-rw-r--r-- | tests/ImageDecodingTest.cpp | 5 | ||||
-rw-r--r-- | tests/TextureCompressionTest.cpp | 37 |
2 files changed, 6 insertions, 36 deletions
diff --git a/tests/ImageDecodingTest.cpp b/tests/ImageDecodingTest.cpp index 8838e75566..5e63611348 100644 --- a/tests/ImageDecodingTest.cpp +++ b/tests/ImageDecodingTest.cpp @@ -55,10 +55,9 @@ static bool skip_image_format(SkImageDecoder::Format format) { // decoders do not, so skip them as well. case SkImageDecoder::kICO_Format: case SkImageDecoder::kBMP_Format: - // KTX and ASTC are texture formats so it's not particularly clear how to - // decode the alpha from them. + // KTX is a Texture format so it's not particularly clear how to + // decode the alpha from it. case SkImageDecoder::kKTX_Format: - case SkImageDecoder::kASTC_Format: // The rest of these are opaque. case SkImageDecoder::kPKM_Format: case SkImageDecoder::kWBMP_Format: diff --git a/tests/TextureCompressionTest.cpp b/tests/TextureCompressionTest.cpp index da7a87bd41..8694389fe7 100644 --- a/tests/TextureCompressionTest.cpp +++ b/tests/TextureCompressionTest.cpp @@ -12,32 +12,6 @@ #include "SkTextureCompressor.h" #include "Test.h" -// TODO: Create separate tests for RGB and RGBA data once -// ASTC and ETC1 decompression is implemented. - -static bool decompresses_a8(SkTextureCompressor::Format fmt) { - switch (fmt) { - case SkTextureCompressor::kLATC_Format: - case SkTextureCompressor::kR11_EAC_Format: - return true; - - default: - return false; - } -} - -static bool compresses_a8(SkTextureCompressor::Format fmt) { - switch (fmt) { - case SkTextureCompressor::kLATC_Format: - case SkTextureCompressor::kR11_EAC_Format: - case SkTextureCompressor::kASTC_12x12_Format: - return true; - - default: - return false; - } -} - /** * Make sure that we properly fail when we don't have multiple of four image dimensions. */ @@ -64,9 +38,6 @@ DEF_TEST(CompressAlphaFailDimensions, reporter) { for (int i = 0; i < SkTextureCompressor::kFormatCnt; ++i) { const SkTextureCompressor::Format fmt = static_cast<SkTextureCompressor::Format>(i); - if (!compresses_a8(fmt)) { - continue; - } SkAutoDataUnref data(SkTextureCompressor::CompressBitmapToFormat(bitmap, fmt)); REPORTER_ASSERT(reporter, NULL == data); } @@ -98,9 +69,6 @@ DEF_TEST(CompressAlphaFailColorType, reporter) { for (int i = 0; i < SkTextureCompressor::kFormatCnt; ++i) { const SkTextureCompressor::Format fmt = static_cast<SkTextureCompressor::Format>(i); - if (!compresses_a8(fmt)) { - continue; - } SkAutoDataUnref data(SkTextureCompressor::CompressBitmapToFormat(bitmap, fmt)); REPORTER_ASSERT(reporter, NULL == data); } @@ -166,7 +134,10 @@ DEF_TEST(CompressCheckerboard, reporter) { // Ignore formats for RGBA data, since the decompressed buffer // won't match the size and contents of the original. - if (!decompresses_a8(fmt) || !compresses_a8(fmt)) { + // TODO: Create separate tests for RGB and RGBA data once + // ASTC and ETC1 decompression is implemented. + if (SkTextureCompressor::kASTC_12x12_Format == fmt || + SkTextureCompressor::kETC1_Format == fmt) { continue; } |